Re: [PATCH v2] mm/damon: validate min_region_size to be power of 2

Liew Rui Yan
2026-04-03T08:29:15Z

Hi SeongJae,

Sorry for missing the discussion before sending out v3. I was too
focused on the code and missed the context of your questions.

On Thu, 2 Apr 2026 07:03:14 -0700 SeongJae Park <sj@kernel.org> wrote:

> On Thu, 2 Apr 2026 13:37:56 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
> [...]
>
> Could you please further elaborate visible user impact of the problem and
> reproduction steps if available?

Yes, I have provided it in the cover letter of v3 [1].

> [...]
>
> Should we add Fixes: and Cc: stable@ ?
>
> If we should Cc: stable@, and if the changes for DAMON_RECLAIM and
> DAMON_LRU_SORT deserve different Fixes:, I think this patch is better to be
> split into two patches, one for DAMON_RECLAIM, and the other for
> DAMON_LRU_SORT.

Yes, I agree. I have split the changes into two separate patches in v3
[1]:
- Patch 1 Fixes:
2e0fe9245d6b ("mm/damon/lru_sort: support addr_unit for DAMON_LRU_SORT")
- Patch 2 Fixes:
7db551fcfb2a ("mm/damon/reclaim: support addr_unit for DAMON_RECLAIM")

Both patches are now CC-ed to <stable@vger.kernel.org>.

> [...]
>
> Seems you forgot the patch [1] before renaming of the subject.

Thank you again for reminding me, I have added the missing references
to the changelog in v3 [1].

>
> [...]
>
> The code changes look good to me.
>
> [1] https://lore.kernel.org/20260327062627.66426-1-aethernet65535@gmail.com

Thank you for your review and patience.

[1] https://lore.kernel.org/20260403052837.58063-1-aethernet65535@gmail.com

Best regards,
Rui Yan