linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>,
	hannes@cmpxchg.org, david@kernel.org, mhocko@kernel.org,
	zhengqi.arch@bytedance.com, yuzhao@google.com,
	shakeel.butt@linux.dev, willy@infradead.org,
	Liam.Howlett@oracle.com, axelrasmussen@google.com,
	yuanchu@google.com, weixugc@google.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mm/vmscan: prevent MGLRU reclaim from pinning address space
Date: Fri, 27 Mar 2026 12:53:14 -0700	[thread overview]
Message-ID: <20260327125314.98f1087225ee48d4feb97345@linux-foundation.org> (raw)
In-Reply-To: <CAJuCfpFrQQDipONQN-ie-tWVNx7m_=jxyqsh0gGD9CE7HN7RLA@mail.gmail.com>

On Fri, 27 Mar 2026 08:20:06 -0700 Suren Baghdasaryan <surenb@google.com> wrote:

> > Given you have cleared up my concerns, this LGTM, so:
> >
> > Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
> 
> Hi Andrew,
> Any concerns about this patch or do you want someone maintaining MGLRU
> to Ack it before pulling into your tree?

That would of course be welcome.  But Suren+Lorenzo is more than
enough for me.

> The change is quite simple and I explain in my reply why it's safe,
> Sashiko seems to like it and I extensively tested it on Android.
> Please let me know if anything else is needed.

I think that if the fix is valuable enough for Android to backport then
we at least should have the Fixes: there to help others who are using
MGLRU on older kernels.  (We don't have an "Improves:"!) And if it's a
really big improvement then we could even pretend it's a bugfix and
sneak it into -stable ;)

But the changelog doesn't say much at all about how this change affects
users.  Just "delays".  So can you please expand on this (numbers are
always nice) and I can paste that into the changelog.

Thanks.


  reply	other threads:[~2026-03-27 19:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-22  7:08 Suren Baghdasaryan
2026-03-23 13:43 ` Lorenzo Stoakes (Oracle)
2026-03-23 16:19   ` Suren Baghdasaryan
2026-03-23 17:06     ` Lorenzo Stoakes (Oracle)
2026-03-23 17:24       ` Suren Baghdasaryan
2026-03-27 15:20       ` Suren Baghdasaryan
2026-03-27 19:53         ` Andrew Morton [this message]
2026-03-27 20:12           ` Suren Baghdasaryan
2026-03-23 13:43 ` Lorenzo Stoakes (Oracle)
2026-03-23 16:26   ` Suren Baghdasaryan
2026-03-23 17:02     ` Lorenzo Stoakes (Oracle)
2026-03-23 17:43       ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260327125314.98f1087225ee48d4feb97345@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=axelrasmussen@google.com \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=weixugc@google.com \
    --cc=willy@infradead.org \
    --cc=yuanchu@google.com \
    --cc=yuzhao@google.com \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox