From: Liew Rui Yan <aethernet65535@gmail.com>
To: sj@kernel.org
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
Liew Rui Yan <aethernet65535@gmail.com>
Subject: [PATCH] mm/damon: validate addr_unit to be power of 2
Date: Fri, 27 Mar 2026 14:26:27 +0800 [thread overview]
Message-ID: <20260327062627.66426-1-aethernet65535@gmail.com> (raw)
Problem
=======
The 'addr_unit' must be a power of 2 for correct address alignment
calculations. Previously, writing a non-power-of-2 value
(e.g., addr_unit=3) would be accepted by the sysfs store callback, but
cause kdamond to exit unexpectedly during parameter application, failing
silently without returning an error to userspace.
Solution
========
Add an is_power_of_2() check in damon_commit_ctx() to reject invalid
inputs immediately with -EINVAL.
When damon_commit_ctx() fails, the kdamond thread terminates as
designed.
The issue is found by sashiko [1].
[1] https://lore.kernel.org/20260325025317.86571-1-sj@kernel.org
Signed-off-by: Liew Rui Yan <aethernet65535@gmail.com>
---
mm/damon/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index db6c67e52d2b..6bad85a47a79 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1330,6 +1330,8 @@ int damon_commit_ctx(struct damon_ctx *dst, struct damon_ctx *src)
dst->maybe_corrupted = true;
if (!is_power_of_2(src->min_region_sz))
return -EINVAL;
+ if (!src->addr_unit || !is_power_of_2(src->addr_unit))
+ return -EINVAL;
err = damon_commit_schemes(dst, src);
if (err)
--
2.53.0
next reply other threads:[~2026-03-27 6:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 6:26 Liew Rui Yan [this message]
2026-03-27 6:45 ` Liew Rui Yan
2026-03-27 12:10 ` Liew Rui Yan
2026-03-27 8:11 ` (sashiko review) " Liew Rui Yan
2026-03-27 8:27 ` Liew Rui Yan
2026-03-27 14:14 ` SeongJae Park
2026-03-27 14:56 ` Liew Rui Yan
2026-03-28 0:14 ` SeongJae Park
2026-03-28 2:26 ` Liew Rui Yan
2026-03-28 13:29 ` SeongJae Park
2026-03-28 14:13 ` SeongJae Park
2026-03-28 17:44 ` Liew Rui Yan
2026-03-28 18:06 ` SeongJae Park
2026-03-28 18:43 ` Liew Rui Yan
2026-03-29 3:20 ` SeongJae Park
2026-03-29 7:51 ` Liew Rui Yan
2026-03-29 15:15 ` SeongJae Park
2026-03-30 6:08 ` Liew Rui Yan
2026-03-30 7:17 ` Liew Rui Yan
2026-03-30 23:34 ` SeongJae Park
2026-03-30 23:33 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260327062627.66426-1-aethernet65535@gmail.com \
--to=aethernet65535@gmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox