From: Andrew Morton <akpm@linux-foundation.org>
To: Chunyu Hu <chuhu@redhat.com>
Cc: david@kernel.org, shuah@kernel.org, linux-mm@kvack.org,
ljs@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, ziy@nvidia.com,
baolin.wang@linux.alibaba.com, npache@redhat.com,
ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
lance.yang@linux.dev
Subject: Re: [PATCH v6 4/6] selftests/mm/vm_util: robust write_file()
Date: Thu, 26 Mar 2026 23:03:49 -0700 [thread overview]
Message-ID: <20260326230349.dcd0b30030c7d460e8b0f319@linux-foundation.org> (raw)
In-Reply-To: <20260324013316.2590422-5-chuhu@redhat.com>
On Tue, 24 Mar 2026 09:33:14 +0800 Chunyu Hu <chuhu@redhat.com> wrote:
> Add two more checks for buflen and numwritten. The buflen should be at
> least one, otherwise the 'buflen - 1' could underflow and cause trouble.
> The numwritten should be equal to 'buflen - 1'. The test will exit if
> any of these conditions aren't met.
>
> Additionally, add more print information when a write failure occurs or
> a truncated write happens, providing clearer diagnostics.
This one has no review and AI review did identify a kinda-bug. Maybe
nobody calls write_file() with buflen==1, but still worth addressing I
think.
https://sashiko.dev/#/patchset/20260324013316.2590422-1-chuhu%40redhat.com
Chunyu, could you please take a look?
Thanks.
next prev parent reply other threads:[~2026-03-27 6:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 1:33 [PATCH v6 0/6] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 1/6] selftests/mm/guard-regions: skip collapse test when thp not enabled Chunyu Hu
2026-03-27 7:43 ` Lorenzo Stoakes (Oracle)
2026-03-29 9:45 ` Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 2/6] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 3/6] selftests/mm: move write_file helper to vm_util Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 4/6] selftests/mm/vm_util: robust write_file() Chunyu Hu
2026-03-27 6:03 ` Andrew Morton [this message]
2026-03-29 9:21 ` Chunyu Hu
2026-03-27 7:46 ` Lorenzo Stoakes (Oracle)
2026-03-29 9:30 ` Chunyu Hu
2026-03-27 12:32 ` Mike Rapoport
2026-03-29 9:27 ` Chunyu Hu
2026-03-31 11:00 ` Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 5/6] selftests/mm: split_huge_page_test: skip the test when thp is not available Chunyu Hu
2026-03-24 1:33 ` [PATCH v6 6/6] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-24 16:09 ` [PATCH v6 0/6] selftests/mm: skip several tests when thp is " Andrew Morton
2026-03-27 13:24 ` David Hildenbrand (Arm)
2026-03-29 9:05 ` Chunyu Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326230349.dcd0b30030c7d460e8b0f319@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chuhu@redhat.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox