From: Andrew Morton <akpm@linux-foundation.org>
To: Junyao Zhao <junzhao@redhat.com>
Cc: vbabka@kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_alloc: fix indentation for VM_WARN_ONCE
Date: Thu, 26 Mar 2026 20:19:57 -0700 [thread overview]
Message-ID: <20260326201957.d064134395f3b832de29d048@linux-foundation.org> (raw)
In-Reply-To: <CAMZL0nYFrtfQbVs2F63S3y1kDnLGeQpURxd+OqGE3YkZ7Ad9Tg@mail.gmail.com>
On Fri, 27 Mar 2026 11:00:19 +0800 Junyao Zhao <junzhao@redhat.com> wrote:
> >From d7442d455218ffff67f890bb39d273d7555bed1c Mon Sep 17 00:00:00 2001
> From: Junyao Zhao <junzhao@redhat.com>
> Date: Thu, 26 Mar 2026 04:58:14 -0400
> Subject: [PATCH] mm/page_alloc: fix indentation for VM_WARN_ONCE
>
> Replace leading spaces with a tab to follow kernel coding style.
>
> Reported by checkpatch.pl
Thanks.
This is rather too minor to add, sorry. If it was modifying a whoops
which was added in the current development tree then OK.
Also, the current development tree's __del_page_from_free_list() looks
nothing like yours, so maybe you're developing against an older kernel?
And your email suffers wordwrapping and tabs-to-spaces issues. Please
fix that email client configuration next time.
> Signed-off-by: Junyao Zhao <junzhao@redhat.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 2d4b6f1a554e..d2e04ecddb8b 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -884,7 +884,7 @@ static inline void
> __del_page_from_free_list(struct page *page, struct zone *zon
> {
> int nr_pages = 1 << order;
>
> - VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
> + VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
> "page type is %d, passed migratetype is %d (nr=%d)\n",
> get_pageblock_migratetype(page), migratetype, nr_pages);
>
> --
> 2.52.0
prev parent reply other threads:[~2026-03-27 3:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 3:00 Junyao Zhao
2026-03-27 3:19 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326201957.d064134395f3b832de29d048@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=junzhao@redhat.com \
--cc=linux-mm@kvack.org \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox