linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>
Cc: Qi Zheng <qi.zheng@linux.dev>,
	hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com,
	roman.gushchin@linux.dev, shakeel.butt@linux.dev,
	muchun.song@linux.dev, david@kernel.org, ziy@nvidia.com,
	harry.yoo@oracle.com, yosry.ahmed@linux.dev,
	imran.f.khan@oracle.com, kamalesh.babulal@oracle.com,
	axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com,
	chenridong@huaweicloud.com, mkoutny@suse.com,
	hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com,
	lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	"Harry Yoo (Oracle)" <harry@kernel.org>,
	Qi Zheng <zhengqi.arch@bytedance.com>
Subject: Re: [PATCH v2 4/4] mm: memcontrol: fix unexpected massive positive number in memcg_state_val_in_pages()
Date: Thu, 26 Mar 2026 17:06:22 -0700	[thread overview]
Message-ID: <20260326170622.8fa7ca34d1425c241525bd41@linux-foundation.org> (raw)
In-Reply-To: <9ee51ac2-c87c-44f6-b983-44ac9007cb35@lucifer.local>

On Thu, 26 Mar 2026 09:38:02 +0000 "Lorenzo Stoakes (Oracle)" <ljs@kernel.org> wrote:

> >
> > If Andrew needs me to merge this patchset into "[PATCH v6 00/33] Eliminate
> > Dying Memory Cgroup" [1], then I will develop and send v7.
> >
> > [1].
> > https://lore.kernel.org/all/cover.1772711148.git.zhengqi.arch@bytedance.com/
> 
> Oh that's your series too :)
> 
> That would be ideal unless that's already in mm-stable, as the series ordering
> will give us strict ordering on patches.
> 
> Anyway let's wait for Andrew on that!

<trying to catch up here>

Gee, I'd rather not churn that 33 patch series.  Could of course do so
in the normal fashion, if that's considered particularly desirable.

As I understand it, Qi will be preparing a v3 and I should stage that
ahead of "Eliminate ..." to avoid a bisection hole?

If so, that works.

<checks>

Well dang, this series ("fix unexpected type conversions and potential
overflows") is at least textually dependent on "Eliminate ...".

Options:

a) Redo this "fix unexpected ..." series on top of "Eliminate ..."
   and tolerate the bisection hole (easiest).

   Am I correct in believing that the concern here is a runtime
   bisection hole?  And that the bug is pretty unlikely to hit even if
   our unlucky bisector happens to hit that hole?  If so, we can live
   with that, surely.  Every darn hotfix we do creates a runtime
   bisecton hole!

b) Redo this series on top of mm-stable or mainline or whatever then
   I stage this series ahead of "Eliminate ..." and fix up the merge
   issues (probably OK)

c) Qi redoes everything as a single series.  That's OK.

If we choose c) then please lmk and I'll drop both series to give Qi a
clean run at mm-unstable.



  reply	other threads:[~2026-03-27  0:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 14:13 [PATCH v2 0/4] fix unexpected type conversions and potential overflows Qi Zheng
2026-03-25 14:13 ` [PATCH v2 1/4] mm: memcontrol: correct the type of stats_updates to unsigned long Qi Zheng
2026-03-25 15:28   ` Lorenzo Stoakes (Oracle)
2026-03-26  2:32     ` Qi Zheng
2026-03-26  8:05       ` Lorenzo Stoakes (Oracle)
2026-03-26  8:19         ` Harry Yoo (Oracle)
2026-03-26  8:20         ` Qi Zheng
2026-03-25 14:13 ` [PATCH v2 2/4] mm: memcontrol: change val type to long in __mod_memcg_{lruvec_}state() Qi Zheng
2026-03-26  9:19   ` Lorenzo Stoakes (Oracle)
2026-03-26 14:37     ` David Laight
2026-03-27  2:37       ` Qi Zheng
2026-03-25 14:13 ` [PATCH v2 3/4] mm: memcontrol: correct the nr_pages parameter type of mem_cgroup_update_lru_size() Qi Zheng
2026-03-25 14:13 ` [PATCH v2 4/4] mm: memcontrol: fix unexpected massive positive number in memcg_state_val_in_pages() Qi Zheng
2026-03-26  9:16   ` Lorenzo Stoakes (Oracle)
2026-03-26  9:21     ` Lorenzo Stoakes (Oracle)
2026-03-26  9:32     ` Qi Zheng
2026-03-26  9:38       ` Lorenzo Stoakes (Oracle)
2026-03-27  0:06         ` Andrew Morton [this message]
2026-03-27  2:42           ` Qi Zheng
2026-03-27  3:13             ` Andrew Morton
2026-03-27  7:51               ` Lorenzo Stoakes (Oracle)
2026-03-25 14:24 ` [PATCH v2 0/4] fix unexpected type conversions and potential overflows Qi Zheng
2026-03-25 23:57 ` Andrew Morton
2026-03-26  0:28   ` Andrew Morton
2026-03-26  2:30   ` Qi Zheng
2026-03-26  3:27     ` Andrew Morton
2026-03-26  7:14 ` Michal Hocko
2026-03-26  7:51   ` Harry Yoo (Oracle)
2026-03-26  8:18     ` Michal Hocko
2026-03-26  9:22       ` Lorenzo Stoakes (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326170622.8fa7ca34d1425c241525bd41@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=apais@linux.microsoft.com \
    --cc=axelrasmussen@google.com \
    --cc=bhe@redhat.com \
    --cc=chenridong@huaweicloud.com \
    --cc=david@kernel.org \
    --cc=hamzamahfooz@linux.microsoft.com \
    --cc=hannes@cmpxchg.org \
    --cc=harry.yoo@oracle.com \
    --cc=harry@kernel.org \
    --cc=hughd@google.com \
    --cc=imran.f.khan@oracle.com \
    --cc=kamalesh.babulal@oracle.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=mkoutny@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=qi.zheng@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=usamaarif642@gmail.com \
    --cc=weixugc@google.com \
    --cc=yosry.ahmed@linux.dev \
    --cc=yuanchu@google.com \
    --cc=zhengqi.arch@bytedance.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox