From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69083106F315 for ; Thu, 26 Mar 2026 09:55:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9B6A6B00A5; Thu, 26 Mar 2026 05:55:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 938E16B00A7; Thu, 26 Mar 2026 05:55:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78C6E6B00A6; Thu, 26 Mar 2026 05:55:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 58EE26B00A3 for ; Thu, 26 Mar 2026 05:55:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2C87FE07E6 for ; Thu, 26 Mar 2026 09:55:25 +0000 (UTC) X-FDA: 84587756610.01.26416C7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id CEFBCC0008 for ; Thu, 26 Mar 2026 09:55:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kZE4RrNN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ftluw92P; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kZE4RrNN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ftluw92P; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1774518923; a=rsa-sha256; cv=none; b=moAKAmtVoI8HKZBnhHPE/cA8gLJrYr7MANnpeSw/3AjHbCLxkOKp546aJ1rMMpUPbh+75J nv+bBsL2iCFZxsx8Im7giOpdAUU8P0l6qXS1I3Gg6hP8jg7c9DQuiqcy9bDEgsb2Hk/JkH DdFCRjw18CC0SBTTkN6vxqszNaSFbrA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kZE4RrNN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ftluw92P; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kZE4RrNN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ftluw92P; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1774518923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rW80C6AuNNamkUQ9haKOUGA55hbQ71BVZqxu2HXjQpY=; b=yV9IHUqWfmFqjgWqubDB6mVU5D3URCkHdVvxoDg9Ud0+ND0gP1y5XhIUX+Vo/Ltx2et4gd PGkoBPCMzcL9WMKmJB8BFQw1RZZ5Wb05LL1zV++zbuv5zH+T8BtHJkV1EKORKjOyaeSRes NKZJwhAA9WZ0kuAWO87VAtlcbo1VkOw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2EE2A4D27F; Thu, 26 Mar 2026 09:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1774518897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rW80C6AuNNamkUQ9haKOUGA55hbQ71BVZqxu2HXjQpY=; b=kZE4RrNNdLTLuWN5RPCoxgFYXXE9zDXKfCGafFlMmh+Cu8e0Ol+lfoYL75PfV/EAOe/trO tgh9xQKddQpLaot8fSgcxmjjPD34PbZZSKwxMNGKur9cUu+nHuRXRijku6eiaxVo2NE6VC lJ0rETumkD3FR0Y6tlr+t/13pnqvLgY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1774518897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rW80C6AuNNamkUQ9haKOUGA55hbQ71BVZqxu2HXjQpY=; b=ftluw92PLfQAyjYGTv9/iNz1MGwGCLQvby/dsMa6kTyax8l6sQkvF6htKDRUrw7GRU7YMs UH5H4g3kmK5FskAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1774518897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rW80C6AuNNamkUQ9haKOUGA55hbQ71BVZqxu2HXjQpY=; b=kZE4RrNNdLTLuWN5RPCoxgFYXXE9zDXKfCGafFlMmh+Cu8e0Ol+lfoYL75PfV/EAOe/trO tgh9xQKddQpLaot8fSgcxmjjPD34PbZZSKwxMNGKur9cUu+nHuRXRijku6eiaxVo2NE6VC lJ0rETumkD3FR0Y6tlr+t/13pnqvLgY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1774518897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rW80C6AuNNamkUQ9haKOUGA55hbQ71BVZqxu2HXjQpY=; b=ftluw92PLfQAyjYGTv9/iNz1MGwGCLQvby/dsMa6kTyax8l6sQkvF6htKDRUrw7GRU7YMs UH5H4g3kmK5FskAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 225944A0AE; Thu, 26 Mar 2026 09:54:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rhFiCHECxWnDYAAAD6G6ig (envelope-from ); Thu, 26 Mar 2026 09:54:57 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E6087A0BC4; Thu, 26 Mar 2026 10:54:48 +0100 (CET) From: Jan Kara To: Cc: , Christian Brauner , Al Viro , , Ted Tso , "Tigran A. Aivazian" , David Sterba , OGAWA Hirofumi , Muchun Song , Oscar Salvador , David Hildenbrand , linux-mm@kvack.org, linux-aio@kvack.org, Benjamin LaHaise , Jan Kara Subject: [PATCH 14/42] fs: Rename generic_file_fsync() to simple_fsync() Date: Thu, 26 Mar 2026 10:54:08 +0100 Message-ID: <20260326095354.16340-56-jack@suse.cz> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326082428.31660-1-jack@suse.cz> References: <20260326082428.31660-1-jack@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=7169; i=jack@suse.cz; h=from:subject; bh=fPJkdtE9HIUWD963RofAKXHTr9yY2ungJEXA11VPK4c=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBpxQI+K+GSrneinOSDRxrfJGqm8QflH7K2MAw1q Oaj6xF4l2iJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCacUCPgAKCRCcnaoHP2RA 2W+wB/98NzHfSwSJB7lub0JKUpOYSs9hmi+KgU8jgNUW4ZNt8Dvov5SZ6Vuf6qZG+36h934dLmb Sx11SvYjaomANJ7bsoYnIpXbQGz99ty0YagA4wCpLsxsMxQgjS9s6KdnSRdR9G+Z5q6bQkx28KJ W5RNJTckz8VLEioNsxnyolpncbHBvBCkMi5jPg3r2aS20eg7OMoR5hQV1iluSy464I1k8KgTBd5 HdRh5ke2sGJjbPtMafeUrh9OvMpDXhc2ojR+mK5EH+KaS5ebyhnJLDhcw+MSCAiYtlyScEJdTSR 6jIkHipx+aSKVmiE1xGHebNSKCzaIUtVaehZIPGtLea3B9al X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit X-Stat-Signature: o3g4d7m7nhwy7dyiiiak6n1jk7exwn46 X-Rspamd-Queue-Id: CEFBCC0008 X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1774518922-348224 X-HE-Meta: U2FsdGVkX19oxKOVAeMz4IDdvU/UZH1GouqH7T0yTU9ZPG8CvRWBlmSgzQ5X4fyjF2DY1IvYVLCC7UzbIpDqaeOynqAxaSi+0iYx71wbTY5/8RDv90bb4XBgNFJ+Ei0H+Urfa0pkMnsGNNwQ2oo/WhBT4TQGV77j9HJNsy3qg7iGDaz1/Fh/514t8dk+QsI7TOW1+xStxdE0vAduerWO0oqjprtOA1BUCxkc5M+d+rcko65DIl74bxg7zGg8fHU22ABUlZTk284M+rXnqv/5n0DyKnD5YppX043P24q5MMqNstaGVkn4lj9RKnoLCaJQkkvhWYf+Y/dwcneXtCFNjPvEYB+UylVXimIgOmlPNniYR0xvGYNFYsrxA7IOw+dXVz/DknxcVW38cnjUPZPYtaQ+pbNN5vsPsa5XCk77HgwmWFQnNiWxv5OvOS2SZ1OAkyPKbc/XjjEDHJ/AYesKeEGo+h9W+HQzPLnvDVJylROMLZ1Q7+/9+6h6cvjwnUQw/t8FWsEZ/d44RxiicWQynuUBqwxSC2/DDBGsvhUakHCx2sCGwdnCUfacmnqXkat4lC9QOei5eCiDBBziDtBUK7qJRYgRzr6O3kJ4NZxDW6PVCgsnMKqSm8LF1aXTFRNrav3FGAwsUQVsI680K0Qe+Vz9pmW2qPKO30wT/7LJlPnsEDUFtWSaoYJgCrhjO7QuOZeCqN6ELo3sRWZAwD5SiaYuG62gvWsygJ5i89UStn+97A72VE86dQLs4cSrnx+7FxveOwnXC21YLXxMCuK4MmpkcWJtoRDa05GWSYGwCrdzA7F9mvddYM1H7qnpBkTiotUGhRZdvD7LaUYxuq25/5BoQn3VGBw5mTaBEiq6kPw4l6xWfaAOsWlomWB1iPV2ytsF+Wfa75pak2mOFkIhT9kub3Mzz3769zSBtmiVjJcdZxshskfvjsKRBvSun6CMxgFs8EY0DETf3GLwHD6 VYn64tFV 0hNuy6pke8NE/+xWAHeyyxthadquem0SKOYdyMmALJLqQWYzDnrE8iulbGeMHksR6L5qGX3ORyqsHjb/aW9cZFZrUu2QLQk10WICrOyVRZcsfo6vQWQIRhIR6i1s7FqQwCxXB4w4ys02c1/opscGMfxk5LlP7YNPjpeYKbEV3EexyvkxKrAuOiJ1jSxSD8H95oxFcSTjpHc6rD1+A1DZeyeI3KnFNQXKbfjWi+ktmU2Ugroz89Xko4mQ1bo+iiFuljwiKZriuHkSL7FpOygI9h/iGPRGUx9pFhBBBpEAS4rWJaOwQIe9NPhbjHFHJkl0wkGNDuT58Naqpe77Pokauaxc3asrZDNBnYP4IOCSQzMmkJqI= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The implementation is now really basic so rename generic_file_fsync() simple_fsync() and __generic_file_fsync() to simple_fsync_noflush(). Signed-off-by: Jan Kara --- fs/adfs/dir.c | 2 +- fs/adfs/file.c | 2 +- fs/exfat/file.c | 2 +- fs/libfs.c | 26 ++++++++++++-------------- fs/omfs/file.c | 2 +- fs/qnx4/dir.c | 2 +- fs/qnx6/dir.c | 2 +- fs/ufs/dir.c | 2 +- fs/ufs/file.c | 2 +- include/linux/fs.h | 4 ++-- 10 files changed, 22 insertions(+), 24 deletions(-) diff --git a/fs/adfs/dir.c b/fs/adfs/dir.c index 493500f37cb9..b8e23e8124ed 100644 --- a/fs/adfs/dir.c +++ b/fs/adfs/dir.c @@ -389,7 +389,7 @@ const struct file_operations adfs_dir_operations = { .read = generic_read_dir, .llseek = generic_file_llseek, .iterate_shared = adfs_iterate, - .fsync = generic_file_fsync, + .fsync = simple_fsync, }; static int diff --git a/fs/adfs/file.c b/fs/adfs/file.c index cd13165fd904..4a1828b3f88f 100644 --- a/fs/adfs/file.c +++ b/fs/adfs/file.c @@ -26,7 +26,7 @@ const struct file_operations adfs_file_operations = { .llseek = generic_file_llseek, .read_iter = generic_file_read_iter, .mmap_prepare = generic_file_mmap_prepare, - .fsync = generic_file_fsync, + .fsync = simple_fsync, .write_iter = generic_file_write_iter, .splice_read = filemap_splice_read, }; diff --git a/fs/exfat/file.c b/fs/exfat/file.c index 90cd540afeaa..4e8d34a75b66 100644 --- a/fs/exfat/file.c +++ b/fs/exfat/file.c @@ -577,7 +577,7 @@ int exfat_file_fsync(struct file *filp, loff_t start, loff_t end, int datasync) if (unlikely(exfat_forced_shutdown(inode->i_sb))) return -EIO; - err = __generic_file_fsync(filp, start, end, datasync); + err = simple_fsync_noflush(filp, start, end, datasync); if (err) return err; diff --git a/fs/libfs.c b/fs/libfs.c index e67e43c6509a..327d8108ed9f 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -1538,19 +1538,18 @@ struct dentry *generic_fh_to_parent(struct super_block *sb, struct fid *fid, EXPORT_SYMBOL_GPL(generic_fh_to_parent); /** - * __generic_file_fsync - generic fsync implementation for simple filesystems + * simple_fsync_noflush - generic fsync implementation for simple filesystems * * @file: file to synchronize * @start: start offset in bytes * @end: end offset in bytes (inclusive) * @datasync: only synchronize essential metadata if true * - * This is a generic implementation of the fsync method for simple - * filesystems which track all non-inode metadata in the buffers list - * hanging off the address_space structure. + * This function is an fsync handler for simple filesystems. It writes out + * dirty data, inode (if dirty), but does not issue a cache flush. */ -int __generic_file_fsync(struct file *file, loff_t start, loff_t end, - int datasync) +int simple_fsync_noflush(struct file *file, loff_t start, loff_t end, + int datasync) { struct inode *inode = file->f_mapping->host; int err; @@ -1573,30 +1572,29 @@ int __generic_file_fsync(struct file *file, loff_t start, loff_t end, ret = err; return ret; } -EXPORT_SYMBOL(__generic_file_fsync); +EXPORT_SYMBOL(simple_fsync_noflush); /** - * generic_file_fsync - generic fsync implementation for simple filesystems - * with flush + * simple_fsync - fsync implementation for simple filesystems with flush * @file: file to synchronize * @start: start offset in bytes * @end: end offset in bytes (inclusive) * @datasync: only synchronize essential metadata if true * + * This function is an fsync handler for simple filesystems. It writes out + * dirty data, inode (if dirty), and issues a cache flush. */ - -int generic_file_fsync(struct file *file, loff_t start, loff_t end, - int datasync) +int simple_fsync(struct file *file, loff_t start, loff_t end, int datasync) { struct inode *inode = file->f_mapping->host; int err; - err = __generic_file_fsync(file, start, end, datasync); + err = simple_fsync_noflush(file, start, end, datasync); if (err) return err; return blkdev_issue_flush(inode->i_sb->s_bdev); } -EXPORT_SYMBOL(generic_file_fsync); +EXPORT_SYMBOL(simple_fsync); /** * generic_check_addressable - Check addressability of file system diff --git a/fs/omfs/file.c b/fs/omfs/file.c index 49a1de5a827f..28f3b113340e 100644 --- a/fs/omfs/file.c +++ b/fs/omfs/file.c @@ -334,7 +334,7 @@ const struct file_operations omfs_file_operations = { .read_iter = generic_file_read_iter, .write_iter = generic_file_write_iter, .mmap_prepare = generic_file_mmap_prepare, - .fsync = generic_file_fsync, + .fsync = simple_fsync, .splice_read = filemap_splice_read, }; diff --git a/fs/qnx4/dir.c b/fs/qnx4/dir.c index 6402715ab377..a9038d231be4 100644 --- a/fs/qnx4/dir.c +++ b/fs/qnx4/dir.c @@ -71,7 +71,7 @@ const struct file_operations qnx4_dir_operations = .llseek = generic_file_llseek, .read = generic_read_dir, .iterate_shared = qnx4_readdir, - .fsync = generic_file_fsync, + .fsync = simple_fsync, .setlease = generic_setlease, }; diff --git a/fs/qnx6/dir.c b/fs/qnx6/dir.c index ae0c9846833d..135fb42f6936 100644 --- a/fs/qnx6/dir.c +++ b/fs/qnx6/dir.c @@ -275,7 +275,7 @@ const struct file_operations qnx6_dir_operations = { .llseek = generic_file_llseek, .read = generic_read_dir, .iterate_shared = qnx6_readdir, - .fsync = generic_file_fsync, + .fsync = simple_fsync, .setlease = generic_setlease, }; diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c index 43f1578ab866..f611f965cb96 100644 --- a/fs/ufs/dir.c +++ b/fs/ufs/dir.c @@ -652,7 +652,7 @@ const struct file_operations ufs_dir_operations = { .release = ufs_dir_release, .read = generic_read_dir, .iterate_shared = ufs_readdir, - .fsync = generic_file_fsync, + .fsync = simple_fsync, .llseek = ufs_dir_llseek, .setlease = generic_setlease, }; diff --git a/fs/ufs/file.c b/fs/ufs/file.c index 809c7a4603f8..85c509ced7f9 100644 --- a/fs/ufs/file.c +++ b/fs/ufs/file.c @@ -41,7 +41,7 @@ const struct file_operations ufs_file_operations = { .write_iter = generic_file_write_iter, .mmap_prepare = generic_file_mmap_prepare, .open = generic_file_open, - .fsync = generic_file_fsync, + .fsync = simple_fsync, .splice_read = filemap_splice_read, .splice_write = iter_file_splice_write, .setlease = generic_setlease, diff --git a/include/linux/fs.h b/include/linux/fs.h index 8b3dd145b25e..0fc0cb23000e 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3295,8 +3295,8 @@ void simple_offset_destroy(struct offset_ctx *octx); extern const struct file_operations simple_offset_dir_operations; -extern int __generic_file_fsync(struct file *, loff_t, loff_t, int); -extern int generic_file_fsync(struct file *, loff_t, loff_t, int); +extern int simple_fsync_noflush(struct file *, loff_t, loff_t, int); +extern int simple_fsync(struct file *, loff_t, loff_t, int); extern int generic_check_addressable(unsigned, u64); -- 2.51.0