From: Chenghao Duan <duanchenghao@kylinos.cn>
To: pasha.tatashin@soleen.com, rppt@kernel.org, pratyush@kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: jianghaoran@kylinos.cn, duanchenghao@kylinos.cn
Subject: [PATCH v3 7/7] mm/memfd_luo: fix integer overflow in memfd_luo_preserve_folios
Date: Thu, 26 Mar 2026 16:47:27 +0800 [thread overview]
Message-ID: <20260326084727.118437-8-duanchenghao@kylinos.cn> (raw)
In-Reply-To: <20260326084727.118437-1-duanchenghao@kylinos.cn>
In memfd_luo_preserve_folios(), two variables had types that could cause
silent data loss with large files:
1. 'size' was declared as 'long', truncating the 64-bit result of
i_size_read(). On 32-bit systems a 4GB file would be truncated to 0,
causing the function to return early and discard all data.
2. 'max_folios' was declared as 'unsigned int', causing overflow for
sparse files larger than 4TB. For example, a 16TB+4KB file would
calculate 0x100000001 folios but truncate to 1 when assigned to
max_folios, causing memfd_pin_folios() to pin only the first folio.
Fix by changing both variables to 'u64' to match the types returned
by i_size_read() and the folio count calculations.
This issue was identified by the AI review.
https://sashiko.dev/#/patchset/20260323110747.193569-1-duanchenghao@kylinos.cn
Signed-off-by: Chenghao Duan <duanchenghao@kylinos.cn>
---
mm/memfd_luo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memfd_luo.c b/mm/memfd_luo.c
index f8e8f99b1848..4b4fa2f658d9 100644
--- a/mm/memfd_luo.c
+++ b/mm/memfd_luo.c
@@ -88,8 +88,8 @@ static int memfd_luo_preserve_folios(struct file *file,
{
struct inode *inode = file_inode(file);
struct memfd_luo_folio_ser *folios_ser;
- unsigned int max_folios;
- long i, size, nr_pinned;
+ u64 size, max_folios;
+ long i, nr_pinned;
struct folio **folios;
int err = -EINVAL;
pgoff_t offset;
--
2.25.1
next prev parent reply other threads:[~2026-03-26 8:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 8:47 [PATCH v3 0/7] Modify memfd_luo code Chenghao Duan
2026-03-26 8:47 ` [PATCH v3 1/7] mm/memfd: use folio_nr_pages() for shmem inode accounting Chenghao Duan
2026-04-02 1:23 ` Pasha Tatashin
2026-04-02 10:59 ` Pratyush Yadav
2026-03-26 8:47 ` [PATCH v3 2/7] mm/memfd_luo: optimize shmem_recalc_inode calls in retrieve path Chenghao Duan
2026-04-02 11:02 ` Pratyush Yadav
2026-03-26 8:47 ` [PATCH v3 3/7] mm/memfd_luo: remove unnecessary memset in zero-size memfd path Chenghao Duan
2026-03-26 8:47 ` [PATCH v3 4/7] mm/memfd_luo: use i_size_write() to set inode size during retrieve Chenghao Duan
2026-03-26 8:47 ` [PATCH v3 5/7] mm/memfd_luo: fix physical address conversion in put_folios cleanup Chenghao Duan
2026-04-02 1:30 ` Pasha Tatashin
2026-04-02 11:06 ` Pratyush Yadav
2026-04-02 17:43 ` Andrew Morton
2026-03-26 8:47 ` [PATCH v3 6/7] mm/memfd_luo: remove folio from page cache when accounting fails Chenghao Duan
2026-04-02 1:32 ` Pasha Tatashin
2026-04-02 11:52 ` Pratyush Yadav
2026-04-02 17:54 ` Andrew Morton
2026-04-03 9:07 ` Pratyush Yadav
2026-03-26 8:47 ` Chenghao Duan [this message]
2026-04-02 1:39 ` [PATCH v3 7/7] mm/memfd_luo: fix integer overflow in memfd_luo_preserve_folios Pasha Tatashin
2026-04-02 12:06 ` Pratyush Yadav
2026-04-02 17:58 ` Andrew Morton
2026-04-03 9:06 ` Pratyush Yadav
2026-03-26 23:36 ` [PATCH v3 0/7] Modify memfd_luo code Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326084727.118437-8-duanchenghao@kylinos.cn \
--to=duanchenghao@kylinos.cn \
--cc=akpm@linux-foundation.org \
--cc=jianghaoran@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox