Re: [PATCH 2/6] mm: add vma_desc_test_all() and use it

David Hildenbrand (Arm)
2026-03-25T08:59:12Z

On 3/25/26 08:31, Vlastimil Babka (SUSE) wrote:
> On 3/5/26 11:50, Lorenzo Stoakes (Oracle) wrote:
>> erofs and zonefs are using vma_desc_test_any() twice to check whether all
>> of VMA_SHARED_BIT and VMA_MAYWRITE_BIT are set, this is silly, so add
>> vma_desc_test_all() to test all flags and update erofs and zonefs to use
>> it.
>>
>> While we're here, update the helper function comments to be more
>> consistent.
>>
>> Also add the same to the VMA test headers.
>>
>> Signed-off-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
>
> I thought I saw David review all of the series and so focused on other
> stuff, didn't notice he skipped this one :)

I think I skipped it because it looked too mechanical when scanning and
I was like "ofc I trust Lorenzo on that one blindly". So I missed to reply.

Tag provided now if it helps.

--
Cheers,

David