From: Chenghao Duan <duanchenghao@kylinos.cn>
To: pasha.tatashin@soleen.com, rppt@kernel.org, pratyush@kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: jianghaoran@kylinos.cn, Chenghao Duan <duanchenghao@kylinos.cn>
Subject: [PATCH v2 3/4] mm/memfd_luo: remove unnecessary memset in zero-size memfd path
Date: Mon, 23 Mar 2026 19:07:46 +0800 [thread overview]
Message-ID: <20260323110747.193569-4-duanchenghao@kylinos.cn> (raw)
In-Reply-To: <20260323110747.193569-1-duanchenghao@kylinos.cn>
The memset(kho_vmalloc, 0, sizeof(*kho_vmalloc)) call in the zero-size
file handling path is unnecessary because the allocation of the ser
structure already uses the __GFP_ZERO flag, ensuring the memory is
already zero-initialized.
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Signed-off-by: Chenghao Duan <duanchenghao@kylinos.cn>
---
mm/memfd_luo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/memfd_luo.c b/mm/memfd_luo.c
index 2a01eaff03c2..bf827e574bec 100644
--- a/mm/memfd_luo.c
+++ b/mm/memfd_luo.c
@@ -103,7 +103,6 @@ static int memfd_luo_preserve_folios(struct file *file,
if (!size) {
*nr_foliosp = 0;
*out_folios_ser = NULL;
- memset(kho_vmalloc, 0, sizeof(*kho_vmalloc));
return 0;
}
--
2.25.1
next prev parent reply other threads:[~2026-03-23 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 11:07 [PATCH v2 0/4] Modify memfd_luo code Chenghao Duan
2026-03-23 11:07 ` [PATCH v2 1/4] mm/memfd: use folio_nr_pages() for shmem inode accounting Chenghao Duan
2026-03-23 11:07 ` [PATCH v2 2/4] mm/memfd_luo: optimize shmem_recalc_inode calls in retrieve path Chenghao Duan
2026-03-23 11:07 ` Chenghao Duan [this message]
2026-03-23 11:07 ` [PATCH v2 4/4] mm/memfd_luo: use i_size_write() to set inode size during retrieve Chenghao Duan
2026-03-23 21:09 ` [PATCH v2 0/4] Modify memfd_luo code Andrew Morton
2026-03-24 1:54 ` Chenghao Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323110747.193569-4-duanchenghao@kylinos.cn \
--to=duanchenghao@kylinos.cn \
--cc=akpm@linux-foundation.org \
--cc=jianghaoran@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox