Re: [PATCH 08/41] udf: Switch to generic_buffers_fsync()

Jan Kara
2026-03-24T12:24:46Z

On Mon 23-03-26 22:38:09, Christoph Hellwig wrote:
> On Fri, Mar 20, 2026 at 02:41:03PM +0100, Jan Kara wrote:
> > UDF uses metadata bh list attached to inode. Switch it to
> > generic_buffers_fsync() instead of generic_file_fsync().
>
> Can you explain this a bit more? Right now the only difference between
> generic_file_fsync and generic_buffers_fsync is that the former takes
> i_rwsem and the other does not. I'd expect the commit log to explain
> why dropping the lock is safe and desirable.
>
> Same for the other similar patches.

Yeah, I was a bit sloppy with the explanation here and put it only into the
last patch 41. If we move that patch early in the series, explanations
won't be needed which is a good thing I guess.

Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR