Re: [PATCH 28/41] fs: Move metadata bhs tracking to a separate struct

Christoph Hellwig
2026-03-24T05:47:21Z

On Fri, Mar 20, 2026 at 02:41:23PM +0100, Jan Kara wrote:
> Instead of tracking metadata bhs for a mapping using i_private_list and
> i_private_lock we create a dedicated mapping_metadata_bhs struct for it.

s/we //g ?

> So far this struct is embedded in address_space but that will be
> switched for per-fs private inode parts later in the series. This also
> changes the locking from bdev mapping's i_private_lock to lock embedded

Instead of "to lock" I'd expect "to a new lock" or similar.

> + /*
> + * The locking dance is ugly here. We need to acquire lock

s/lock/the lock/

> + * protecting metadata bh list while possibly racing with bh

"the metadata bh list" (or spell out the field name without the "the").

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>