Re: [PATCH RFC v2 1/7] mm: memory_failure: Clarify the MF_DELAYED definition

Lisa Wang
2026-03-23T21:19:06Z

On Sun, Mar 22, 2026 at 02:34:59PM -0700, Jiaqi Yan wrote:
> > [...snip...]
> > * MF_DELAYED - The m-f() handler marks the page as PG_hwpoisoned'ed.
>
> nit: would it be worth correcting PG_hwpoisoned to PG_hwpoison'ed? as
> there is really no "PG_hwpoisoned" page flag.

I will change PG_hwpoisoned'ed to PG_hwpoison'ed in the next version.

> > - * The page is unmapped, and is removed from the LRU or file mapping.
> > - * An attempt to access the page again will trigger page fault and the
> > - * PF handler will kill the process.
> > + * It means the page was partially isolated (e.g. removed from file mapping
>
> nit: what about "unmapped"?

Thanks to point this out.
I will change to "It means the page was unmapped and partially isolated
(e.g. ..." in the next version.

> > + * or the LRU) but full cleanup is deferred (e.g. the metadata for the
> > + * memory, as in struct page/folio, is still referenced). Any further
> > + * access to the page will result in the process being killed.
> > *
> > * MF_RECOVERED - The m-f() handler marks the page as PG_hwpoisoned'ed.
> > * The page has been completely isolated, that is, unmapped, taken out of
> >
> > --
> > 2.53.0.959.g497ff81fa9-goog
> >
>
> Reviewed-by: Jiaqi Yan <jiaqiyan@google.com>