From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
linux-block@vger.kernel.org, linux-mm@kvack.org,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: [PATCH] zram: change scan_slots to return void
Date: Tue, 17 Mar 2026 12:23:19 +0900 [thread overview]
Message-ID: <20260317032349.753645-1-senozhatsky@chromium.org> (raw)
scan_slots_for_writeback() and scan_slots_for_recompress()
work in a "best effort" fashion, if they cannot allocate
memory for a new pp-slot candidate they just return and
post-processing selects slots that were successfully
scanned thus far. scan_slots functions never return
errors and their callers never check the return status,
so convert them to return void.
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
drivers/block/zram/zram_drv.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 7e45b8c8c33d..1b0e1c02ece7 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1212,9 +1212,9 @@ static int parse_mode(char *val, u32 *mode)
return 0;
}
-static int scan_slots_for_writeback(struct zram *zram, u32 mode,
- unsigned long lo, unsigned long hi,
- struct zram_pp_ctl *ctl)
+static void scan_slots_for_writeback(struct zram *zram, u32 mode,
+ unsigned long lo, unsigned long hi,
+ struct zram_pp_ctl *ctl)
{
u32 index = lo;
@@ -1246,8 +1246,6 @@ static int scan_slots_for_writeback(struct zram *zram, u32 mode,
break;
index++;
}
-
- return 0;
}
static ssize_t writeback_store(struct device *dev,
@@ -2379,8 +2377,8 @@ static bool highest_priority_algorithm(struct zram *zram, u32 prio)
return true;
}
-static int scan_slots_for_recompress(struct zram *zram, u32 mode, u32 prio,
- struct zram_pp_ctl *ctl)
+static void scan_slots_for_recompress(struct zram *zram, u32 mode, u32 prio,
+ struct zram_pp_ctl *ctl)
{
unsigned long nr_pages = zram->disksize >> PAGE_SHIFT;
unsigned long index;
@@ -2415,8 +2413,6 @@ static int scan_slots_for_recompress(struct zram *zram, u32 mode, u32 prio,
if (!ok)
break;
}
-
- return 0;
}
/*
--
2.53.0.851.ga537e3e6e9-goog
next reply other threads:[~2026-03-17 3:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 3:23 Sergey Senozhatsky [this message]
2026-03-18 0:57 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317032349.753645-1-senozhatsky@chromium.org \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox