From: Christian Brauner <brauner@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Deepanshu Kartikey <kartikey406@gmail.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, kees@kernel.org, akpm@linux-foundation.org,
david@kernel.org, ljs@kernel.org, Liam.Howlett@oracle.com,
vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org,
syzbot+bbe6b99feefc3a0842de@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] kernel/fork: validate exit_signal in kernel_clone()
Date: Tue, 17 Mar 2026 15:10:08 +0100 [thread overview]
Message-ID: <20260317-federn-umsiedeln-3afae949282a@brauner> (raw)
In-Reply-To: <ablNqvlB9NQlRcw8@redhat.com>
On Tue, Mar 17, 2026 at 01:48:42PM +0100, Oleg Nesterov wrote:
> On 03/16, Deepanshu Kartikey wrote:
> >
> > Note that this is a user-visible change: previously, passing an invalid
> > exit_signal to clone() was silently accepted. The man page for clone()
> > does not document any defined behavior for invalid exit_signal values,
> > so rejecting them with -EINVAL is the correct behavior. It is unlikely
> > that any sane application relies on passing an invalid exit_signal.
>
> Agreed...
>
> > - if (unlikely((args.exit_signal & ~((u64)CSIGNAL)) ||
> > - !valid_signal(args.exit_signal)))
> > + if (unlikely(args.exit_signal & ~((u64)CSIGNAL)))
> > return -EINVAL;
>
> I guess this can die too, but OK, this needs another patch/changelog.
>
> Acked-by: Oleg Nesterov <oleg@redhat.com>
>
>
> Andrew, I will slightly update the changelog and resend
> do_notify_parent-sanitize-the-valid_signal-checks.patch
> in reply to this patch from Deepanshu.
I'll take this via the pidfs/kernel tree. I also have a bunch of work
touching this stuff queued there.
next prev parent reply other threads:[~2026-03-17 14:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 15:19 Deepanshu Kartikey
2026-03-17 12:48 ` Oleg Nesterov
2026-03-17 14:10 ` Christian Brauner [this message]
2026-03-17 14:19 ` Oleg Nesterov
2026-03-17 13:58 ` [PATCH -mm v2] do_notify_parent: sanitize the valid_signal() checks Oleg Nesterov
2026-03-17 14:38 ` Deepanshu Kartikey
2026-03-17 18:34 ` Andrew Morton
2026-03-17 19:08 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317-federn-umsiedeln-3afae949282a@brauner \
--to=brauner@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bsegall@google.com \
--cc=david@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kartikey406@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=syzbot+bbe6b99feefc3a0842de@syzkaller.appspotmail.com \
--cc=vbabka@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox