Re: [PATCH v2 07/22] vfio/pci: Notify PCI subsystem about devices preserved across Live Update

David Matlack
2026-03-16T17:09:41Z

On Mon, Mar 16, 2026 at 9:03 AM Vipin Sharma <vipinsh@google.com> wrote:
>
> On Thu, Jan 29, 2026 at 09:24:54PM +0000, David Matlack wrote:
> > diff --git a/drivers/vfio/pci/vfio_pci_liveupdate.c b/drivers/vfio/pci/vfio_pci_liveupdate.c
> > @@ -192,10 +200,24 @@ static struct liveupdate_file_handler vfio_pci_liveupdate_fh = {
> >
> > int __init vfio_pci_liveupdate_init(void)
> > {
> > + int ret;
> > +
> > if (!liveupdate_enabled())
> > return 0;
> >
> > - return liveupdate_register_file_handler(&vfio_pci_liveupdate_fh);
> > + ret = liveupdate_register_file_handler(&vfio_pci_liveupdate_fh);
> > + if (ret)
> > + return ret;
> > +
> > + ret = pci_liveupdate_register_fh(&vfio_pci_liveupdate_fh);
>
> May be we should rename pci_liveupdate_register_fh() to something like
> pci_register_to_liveupdate_flb(). In the current way, it is confusing to
> why same handler is getting registered at two places.
>
> Above name will also make it similar to IOMMU series as well
> https://lore.kernel.org/kvm/20260203220948.2176157-2-skhawaja@google.com/

Will do.