Re: [PATCH v2 02/22] PCI: Add API to track PCI devices preserved across Live Update

David Matlack
2026-02-24T00:01:29Z

On Mon, Feb 23, 2026 at 3:43 PM Samiullah Khawaja <skhawaja@google.com> wrote:
>
> On Mon, Feb 23, 2026 at 03:08:19PM -0800, David Matlack wrote:
> >On Mon, Feb 23, 2026 at 2:04 PM Samiullah Khawaja <skhawaja@google.com> wrote:
> >> On Thu, Jan 29, 2026 at 09:24:49PM +0000, David Matlack wrote:
> >
> >> >Drivers can notify the PCI subsystem whenever a device is preserved and
> >> >unpreserved with the following APIs:
> >> >
> >> > pci_liveupdate_outgoing_preserve(pci_dev)
> >> > pci_liveupdate_outgoing_unpreserve(pci_dev)
> >>
> >> nit: Preserve and Unpreserve can only be done from outgoing kernel, maybe
> >> remove the "outgoing" from the function name.
> >
> >That's reasonable, I can make that change in v3.
>
> I should have added it earlier, but the same applies to the
> pci_liveupdate_incoming_finish() as it can only be done with incoming
> kernel. Maybe we can remove incoming from it also for consistency?

Yeah I can make that change as well.

I was erring on the side of being overly explicity with the
incoming/outgoing terminology, but I agree it's unnecessary in these
APIs.