Re: [PATCH v2 07/22] vfio/pci: Notify PCI subsystem about devices preserved across Live Update

Jason Gunthorpe
2026-03-03T21:07:51Z

On Thu, Feb 26, 2026 at 04:03:53PM -0700, Alex Williamson wrote:
> > @@ -203,5 +225,6 @@ void vfio_pci_liveupdate_cleanup(void)
> > if (!liveupdate_enabled())
> > return;
> >
> > + WARN_ON_ONCE(pci_liveupdate_unregister_fh(&vfio_pci_liveupdate_fh));
>
> This is propagation of a poor API choice in liveupdate, the unregister
> should return void, it shouldn't be allowed to fail, IMO. Thanks,

+1

"destroy" functions that fail are evil. :)

Jason