From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CC78EB1056 for ; Tue, 10 Mar 2026 14:16:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 850276B00C3; Tue, 10 Mar 2026 10:16:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FDEE6B00C4; Tue, 10 Mar 2026 10:16:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B5876B00C5; Tue, 10 Mar 2026 10:16:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5878C6B00C3 for ; Tue, 10 Mar 2026 10:16:52 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2C81E1C0D5 for ; Tue, 10 Mar 2026 14:16:52 +0000 (UTC) X-FDA: 84530354664.03.3C17049 Received: from relay.hostedemail.com (unirelay10 [10.200.18.73]) by imf06.hostedemail.com (Postfix) with ESMTP id 146FA180015 for ; Tue, 10 Mar 2026 14:16:49 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1773152210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u1O5Z146YMk8FHwWYHIeq5l+sJXYGn84l3Uu3PDpBrg=; b=1mt4i6PLY3qUCkCFrhr2j57cpdBX3926oK0YgALbC3S2jtv4SJRp3zYL8jLwRFQZeUcC0I t/dwk0IB8q4RabcKI+93JTzBquC8koKzLLVIaL72+8JsEpxLx/WggeZQYEv/oXK4pN5OE+ 7hv1k2f9sG2o65hG27T8tZZy5xuZ8c0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1773152210; a=rsa-sha256; cv=none; b=MMmAJaVtYEGUcnx/M3TgYlIyZ/IJJmkcMNW/ZMHQ939t4pXAeHg/ETeC8YgWZaa6gorJzF bET4t2OLE/XIEz+pgg1Glt+IZlXSsrIQxt2Nda7/v0ZmO6rcBqeaiwTDXnfJ7PD7QQHd50 jJbRh6wnE2wi8cXfDQqYGZkone8UJJk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; none Received: from omf16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BF2B9C0E36; Tue, 10 Mar 2026 14:16:43 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf16.hostedemail.com (Postfix) with ESMTPA id D3F9D2000E; Tue, 10 Mar 2026 14:14:32 +0000 (UTC) Date: Tue, 10 Mar 2026 10:14:42 -0400 From: Steven Rostedt To: Philipp Hahn Cc: amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev, Julia Lawall , Nicolas Palix , Chris Mason , David Sterba , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Theodore Ts'o , Andreas Dilger , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Miklos Szeredi , Konstantin Komarov , Andreas Gruenbacher , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Jan Kara , Phillip Lougher , Alexander Viro , Christian Brauner , Jan Kara , Masami Hiramatsu , Mathieu Desnoyers , Tejun Heo , David Vernet , Andrea Righi , Changwoo Min , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Max Filippov , Paolo Bonzini , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Jamal Hadi Salim , Jiri Pirko , Marcelo Ricardo Leitner , Xin Long , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Jon Maloy , Johannes Berg , Catalin Marinas , Russell King , John Crispin , Thomas Bogendoerfer , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Alex Deucher , Christian =?UTF-8?B?S8O2bmln?= , Sandy Huang , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Andy Yan , Igor Russkikh , Andrew Lunn , Pavan Chebbi , Michael Chan , Potnuri Bharat Teja , Tony Nguyen , Przemek Kitszel , Taras Chornyi , Maxime Coquelin , Alexandre Torgue , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , Heiner Kallweit , Marc Zyngier , Thomas Gleixner , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vinod Koul , Linus Walleij , Ulf Hansson , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Martin K. Petersen" , Eduardo Valentin , Keerthy , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alex Williamson , Mark Greer , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Shuah Khan , Kieran Bingham , Mauro Carvalho Chehab , Joerg Roedel , Will Deacon , Robin Murphy , Lee Jones , Pavel Machek , Dave Penkler , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Justin Sanders , Jens Axboe , Georgi Djakov , Michael Turquette , Stephen Boyd , Philipp Zabel , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Pali =?UTF-8?B?Um9ow6Fy?= , Dmitry Torokhov Subject: Re: [PATCH 00/61] treewide: Use IS_ERR_OR_NULL over manual NULL check - refactor Message-ID: <20260310101220.24a5c5e9@gandalf.local.home> In-Reply-To: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/9Mzn/qfZFEp1e7RgFq11s4n8TXcGF42g= X-HE-Meta: U2FsdGVkX1/sr455L+OeqDWIUsSflk6pOnirfnKU4P+1ptXPBptvvQtdgLpKUro5xpE5mwL9OSxc8De42fWUKW3UA0xDjLt8deOx7Rt+YD2zdLsgLNPt+GtW9t0OIk6HGza/DLYz3Vzwa6W2j9RFRkt0u8kU/4nSdzQFXg0XUCPq0O7Zih2HPR5kbJC2dqX8fgpgG6kXbyGWAJWC5H8NEAgNiaeFS1ibRza8HlDqKtmihYdG70k1ID4dNk90G/xB/tCbIhXs0SuHsvdkjj/J9rzzD7qFP/bRWTfcgm+WhH9Nv5Rz067I1rPqmO4dO7ez X-HE-Tag-Orig: 1773152072-399195 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 146FA180015 X-Stat-Signature: t3hdewhrhasw7f3gorx5jroa8bfttu61 X-Rspam-User: X-HE-Tag: 1773152209-187552 X-HE-Meta: U2FsdGVkX1/TUa8mwbRvOfb0KoV1Pqg02D4NAyfST8ke8pNVXUJZb9bX8bR/xMvosblNhu9eHUCaQLFYgoS6sLCSONq5YbaFVC0gUEmMEJtOK9wMcIU+K/kS8koJE8W0GtADSF/2+/jECuTArAHsgTzNdUsyI8+MZKxQ4s0/eCQEGzTAOiJx+FptU6SvXTj3G26ulcnr4lECbD+esm6wzYC7grFbkNGob9Ts1F266dpXuvEtJPuVoMTK6QdjZYp0R8poXslqgyI8d49E+pvlvJ0YoFei1vUXrRS5UgGCQnslUaXjKtxSp/TqchWb2MPx6xUdBVZb7O7XsUGbm6XRKxAVibLHG+KlIzYunq/nWh6H41wR/bH1p/CbZErvz116P1500OyU4oMfCZcxM559/uXXxRjkgqSvSWqy+oZ1vJU5Sin1tOxyLyFW3IeNqIlrQsBwEyAIflnmmMuHJJixUr4wcoI6j0rPBoXpgzZ7FRhtcnRQlQSU7Oi75ilYq5kYO/hQZUxkQtzmOc0HyP0p7/YghD2Lnde8Knw9yfTpSssHpH3rGNbcjTAemgzwYqID/KpEkjyyQMSRjIh49HcXg9a8FRJ6HsLkm0GpxvfHPER2UfUIC0iWsZ7UkRjRfXLxfiVmYvEh+jlT8zxK3TGQIv4SNQq8l8rht6ElPD6ZLjIS/zjVhZMq+ySKMDB5JbmhH4B9pF0p7nTdSNtcX9Cs+0xCFme1QJ7Sbw510yK7h3E4T/Ru1e5b4BaQ53w9UEdd5n3JVNE+KfsoqQTFmb2Wid4WAtpOYT+a/xSxgCb+6u2NTaxqrxTkRTl24NWbqdOntBNZF7RPbVt+FqnGuLbXPIRSh2GOHvZuqPlMlJyydQS9vyvidQp3S2R2T51/mBWBZcuIuI0DzPxXXihgc0gmJww5RhwBAiWlAmVlqyrqZEH/ohQc4NACjxOOD6m06qXC4UmQfAfEo7PhWVR9Gkq i12d3zRg 5a/rRpcdf66lFMab2tLBdqrLUD4SwLkuNdwtoPHwBhvvmPgMOgoFIISLdLw== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 10 Mar 2026 12:48:26 +0100 Philipp Hahn wrote: > While doing some static code analysis I stumbled over a common pattern, > where IS_ERR() is combined with a NULL check. For that there is > IS_ERR_OR_NULL(). > > I've written a Coccinelle patch to find and patch those instances. > The patches follow grouped by subsystem. Honestly, the IS_ERR_OR_NULL() looks worse in a lot of the locations you updated. Just because we have IS_ERR_OR_NULL() doesn't mean we need to go and replace every location that can use it. NAK for any code this touches that I'm responsible for. -- Steve