* [PATCH] mm: optimize once judgment with clang
@ 2026-03-07 6:54 Xie Yuanbin
2026-03-07 8:12 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: Xie Yuanbin @ 2026-03-07 6:54 UTC (permalink / raw)
To: akpm, david, ljs, Liam.Howlett, vbabka, rppt, surenb, mhocko,
nathan, nick.desaulniers+lkml, morbo, justinstitt
Cc: linux-mm, linux-kernel, llvm, Xie Yuanbin
commit 242b872239f6a7deacbc ("include/linux/once_lite.h: fix judgment in
WARN_ONCE with clang") helps optimize performance and size under the
clang compiler, but the modification is not complete.
Port the modification to WARN_ON_ONCE_GFP(), VM_WARN_ON_ONCE_PAGE(),
VM_WARN_ON_ONCE_FOLIO(), VM_WARN_ON_ONCE_MM() and VM_WARN_ON_ONCE_VMA().
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Xie Yuanbin <qq570070308@gmail.com>
---
include/linux/mmdebug.h | 8 ++++----
mm/internal.h | 3 ++-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index ab60ffba08f5..a167c5aa525e 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -60,7 +60,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi);
static bool __section(".data..once") __warned; \
int __ret_warn_once = !!(cond); \
\
- if (unlikely(__ret_warn_once && !__warned)) { \
+ if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \
dump_page(page, "VM_WARN_ON_ONCE_PAGE(" __stringify(cond)")");\
__warned = true; \
WARN_ON(1); \
@@ -80,7 +80,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi);
static bool __section(".data..once") __warned; \
int __ret_warn_once = !!(cond); \
\
- if (unlikely(__ret_warn_once && !__warned)) { \
+ if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \
dump_page(&folio->page, "VM_WARN_ON_ONCE_FOLIO(" __stringify(cond)")");\
__warned = true; \
WARN_ON(1); \
@@ -91,7 +91,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi);
static bool __section(".data..once") __warned; \
int __ret_warn_once = !!(cond); \
\
- if (unlikely(__ret_warn_once && !__warned)) { \
+ if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \
dump_mm(mm); \
__warned = true; \
WARN_ON(1); \
@@ -102,7 +102,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi);
static bool __section(".data..once") __warned; \
int __ret_warn_once = !!(cond); \
\
- if (unlikely(__ret_warn_once && !__warned)) { \
+ if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \
dump_vma(vma); \
__warned = true; \
WARN_ON(1); \
diff --git a/mm/internal.h b/mm/internal.h
index 6e1162e13289..52367f52d623 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -93,7 +93,8 @@ struct pagetable_move_control {
static bool __section(".data..once") __warned; \
int __ret_warn_once = !!(cond); \
\
- if (unlikely(!(gfp & __GFP_NOWARN) && __ret_warn_once && !__warned)) { \
+ if (unlikely(__ret_warn_once) && !(gfp & __GFP_NOWARN) && \
+ unlikely(!__warned)) { \
__warned = true; \
WARN_ON(1); \
} \
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: optimize once judgment with clang
2026-03-07 6:54 [PATCH] mm: optimize once judgment with clang Xie Yuanbin
@ 2026-03-07 8:12 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2026-03-07 8:12 UTC (permalink / raw)
To: Xie Yuanbin
Cc: akpm, david, ljs, Liam.Howlett, vbabka, surenb, mhocko, nathan,
nick.desaulniers+lkml, morbo, justinstitt, linux-mm,
linux-kernel, llvm
On Sat, Mar 07, 2026 at 02:54:04PM +0800, Xie Yuanbin wrote:
> commit 242b872239f6a7deacbc ("include/linux/once_lite.h: fix judgment in
> WARN_ONCE with clang") helps optimize performance and size under the
> clang compiler, but the modification is not complete.
How much does it actually optimize for size?
Note that performance is really not critical here because we are already
dealing with slow path of debug code.
> Port the modification to WARN_ON_ONCE_GFP(), VM_WARN_ON_ONCE_PAGE(),
> VM_WARN_ON_ONCE_FOLIO(), VM_WARN_ON_ONCE_MM() and VM_WARN_ON_ONCE_VMA().
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Xie Yuanbin <qq570070308@gmail.com>
> ---
> include/linux/mmdebug.h | 8 ++++----
> mm/internal.h | 3 ++-
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
> index ab60ffba08f5..a167c5aa525e 100644
> --- a/include/linux/mmdebug.h
> +++ b/include/linux/mmdebug.h
> @@ -60,7 +60,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi);
> static bool __section(".data..once") __warned; \
> int __ret_warn_once = !!(cond); \
> \
> - if (unlikely(__ret_warn_once && !__warned)) { \
> + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \
> dump_page(page, "VM_WARN_ON_ONCE_PAGE(" __stringify(cond)")");\
> __warned = true; \
> WARN_ON(1); \
> @@ -80,7 +80,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi);
> static bool __section(".data..once") __warned; \
> int __ret_warn_once = !!(cond); \
> \
> - if (unlikely(__ret_warn_once && !__warned)) { \
> + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \
> dump_page(&folio->page, "VM_WARN_ON_ONCE_FOLIO(" __stringify(cond)")");\
> __warned = true; \
> WARN_ON(1); \
> @@ -91,7 +91,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi);
> static bool __section(".data..once") __warned; \
> int __ret_warn_once = !!(cond); \
> \
> - if (unlikely(__ret_warn_once && !__warned)) { \
> + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \
> dump_mm(mm); \
> __warned = true; \
> WARN_ON(1); \
> @@ -102,7 +102,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi);
> static bool __section(".data..once") __warned; \
> int __ret_warn_once = !!(cond); \
> \
> - if (unlikely(__ret_warn_once && !__warned)) { \
> + if (unlikely(__ret_warn_once) && unlikely(!__warned)) { \
> dump_vma(vma); \
> __warned = true; \
> WARN_ON(1); \
> diff --git a/mm/internal.h b/mm/internal.h
> index 6e1162e13289..52367f52d623 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -93,7 +93,8 @@ struct pagetable_move_control {
> static bool __section(".data..once") __warned; \
> int __ret_warn_once = !!(cond); \
> \
> - if (unlikely(!(gfp & __GFP_NOWARN) && __ret_warn_once && !__warned)) { \
> + if (unlikely(__ret_warn_once) && !(gfp & __GFP_NOWARN) && \
> + unlikely(!__warned)) { \
> __warned = true; \
> WARN_ON(1); \
> } \
> --
> 2.51.0
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-07 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-07 6:54 [PATCH] mm: optimize once judgment with clang Xie Yuanbin
2026-03-07 8:12 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox