From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53023EC046F for ; Tue, 3 Mar 2026 09:22:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95A4F6B00A6; Tue, 3 Mar 2026 04:22:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 931326B00AE; Tue, 3 Mar 2026 04:22:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DB6A6B00B4; Tue, 3 Mar 2026 04:22:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 653116B00A6 for ; Tue, 3 Mar 2026 04:22:26 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 011E71402E7 for ; Tue, 3 Mar 2026 09:22:25 +0000 (UTC) X-FDA: 84504211092.22.CAA5CCF Received: from gateway1.sungrowpower.com (unknown [202.111.193.14]) by imf19.hostedemail.com (Postfix) with SMTP id 0015C1A0012 for ; Tue, 3 Mar 2026 09:22:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of liying3@sungrowpower.com designates 202.111.193.14 as permitted sender) smtp.mailfrom=liying3@sungrowpower.com; dmarc=pass (policy=quarantine) header.from=sungrowpower.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1772529744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references; bh=wgCgsAoIzHeBMnXD3PxHuJ9tRcqaahLwVKqf+CEbko0=; b=i91G2tz/RzUdjDrbXb3bT4lRV3eeU2PjVPM8WoDZ/aSuWXyveaEiTczhabiuU76HX/FbuR Z0WMpsXTLzqstGFgP/rB1s99+s6JICeJMFpBhWOhCld8IrW7hulsv2gwIRMPE42J6cs8rh 8h/C6cLlDrBHFD4ZSeQecuWsUELd3PU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of liying3@sungrowpower.com designates 202.111.193.14 as permitted sender) smtp.mailfrom=liying3@sungrowpower.com; dmarc=pass (policy=quarantine) header.from=sungrowpower.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1772529744; a=rsa-sha256; cv=none; b=kkitdrVWTt/AWc9C3HTLHH2XEOrQwnv67IrmGcULJBWansDu5SPLwM7eCWvd/vFSwS2ra6 Fbioj1FgPtFwDekkALhj9YlhdFKnl2pG4xBPCq3BvhH7vdcLRbsjQseYYhzOfi2IVBSLnx qLxWk89336bYy5zFmAKGo6SaWTfpajc= Received: from liying3-L1 (unknown [112.28.154.154]) by email-gw.sungrowpower.com (MailData Gateway V2.8.8) with ESMTPSA id D72E720C474E2; Tue, 3 Mar 2026 17:21:55 +0800 (CST) Date: Tue, 3 Mar 2026 17:21:55 +0800 X-MD-Sfrom: liying3@sungrowpower.com X-MD-SrcIP: 112.28.154.154 From: "liying3@sungrowpower.com" To: "David Hildenbrand (Arm)" , "Matthew Wilcox" Cc: akpm , linux-mm , linux-kernel , victor7q , "Greg Kroah-Hartman" Subject: Re: Re: [BUG] mm/mempolicy: possible double-unlock in migrate_to_node() on 6.6 References: <2026030310525141773825@sungrowpower.com>, , X-Priority: 3 X-GUID: 40AEB2D0-C33A-488A-9B0A-AA2F1AAAF0D2 X-Has-Attach: no X-Mailer: Foxmail 7.2.25.398[cn] Mime-Version: 1.0 Message-ID: <2026030317215560288527@sungrowpower.com> Content-Type: multipart/alternative; boundary="----=_001_NextPart261848388678_=----" X-Stat-Signature: ctmg1afyf6b7bj7t7ugjs64wzwx8p5tu X-Rspamd-Server: rspam09 X-Rspam-User: X-Rspamd-Queue-Id: 0015C1A0012 X-HE-Tag: 1772529742-223644 X-HE-Meta: U2FsdGVkX18uf8jOMExllH78W6zWp8CkZldfCvevdaUCcvViCYhD7KYO6jqybW/jguDjVOVt/Ba5NfCNka4vaRgBjIlH+34vmRJGpPdGb720XoQBTEkDGm3k9CXDNUNYqvTNac2421XHskbbm14BP2dc7dn1yFKy5r+0pg67fhQUtsEJFsxqJG7RgASVqBf+Y5aMDD4E4ys+cnwsnwyigIa8WhJTYsOiO0PZG4hzc/POzafPWQCn0wdLzcCa5enmePLlgPByI4MyVpLR5+p7gGRfHGbX2kqNuokr8lCkkaC4LaJ96Km8dKS4REvizJ1T/4evhh5bxJWIcJ2ULBHYhHXAi8vSgqgIbHhiAedNvYFsW8kyPSoxajQEejZHr1ZL0CsKPEzdGsSTRX8JRb/TLdQt57VX8awy1eH3g2HjkxhkxoDU511EdSXUvDUv6FFc2foOcfGl52nezF9sejhA7RCQuNbbYdjkKfZufJajKXgrOU53JBSvhIZtIijpfwYI3BNUqfQ/oVMdfG1R9y4zTywVsvSMP0rJvpG6tRqOTGbGaYa3suQiqaHTAH37Kk8kiDRc3zAaE59krxKUqWz+wKDbsgZiHFfbBmaZb675tDwUriAve8rkOK7OPCiQj+F8xyMKK0J3254mRvVTfm8zVL6QALE6943qZGdQJA6gLboG0KPSo8qgyglA3bOM0hfLpqoNY3nO2daKHO8Y8RCjU7x4THbHHWZdQ6yXVmG0ezkeBcPsy7hvUOMSvt9cwTXjswbFHnJrGUhDzL4/0NjYmJiKrTU1Fsd5gbIdXUYezVtUJR4rQ35/M+dIh+52EeXiJp2gK4ZPiFogkhs2SbOXosp0f7Gz1cVNuHZ3taRrdxWxloCK0J74aammp5Up0BMrIAT4zT6pHp194kn6r8+R1hjAOuCFsgUbi8SVLiKdffGtqSzh31wKwByzWPDibmXy1m2XScCnK5Q= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This is a multi-part message in MIME format. ------=_001_NextPart261848388678_=---- Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 VGhhbmtzIGZvciB5b3VyIGNvbmZpcm0sIHBsZWFzZSBoZWxwIHRvIHByb2Nlc3MgaXQuDQoNCg0K DQpCZXN0IFJlZ2FyZHMsDQpMaSBZaW5nICwgTGlnaHQgU3RvcmFnZSBHcm91cC4gIFNlbmlvciBF bWJlZGRlZCBTb2Z0d2FyZSBFbmdpbmVlcg0KVGVsOiAt77ybIEZheDogLQ0KTW9iaWxlOiArODYt MTU2NTE5NjM5ODENCmxpeWluZzNAc3VuZ3Jvd3Bvd2VyLmNvbSANCnd3dy5zdW5ncm93cG93ZXIu Y29tDQpTVU5HUk9XIFBPV0VSIFNVUFBMWSBDby4sIEx0ZC4gDQpBZGQ6IE5vLjE2OTkgWGl5b3Ug UmQuLCBOZXcgJiBIaWdoIFRlY2hub2xvZ3kgSW5kdXN0cmlhbCBEZXZlbG9wbWVudCBab25lLCBI ZWZlaSwgUC4gUi4gQ2hpbmEuLCAyMzAwODgNCiANCkZyb206IERhdmlkIEhpbGRlbmJyYW5kIChB cm0pDQpEYXRlOiAyMDI2LTAzLTAzIDE3OjA0DQpUbzogTWF0dGhldyBXaWxjb3g7IGxpeWluZzNA c3VuZ3Jvd3Bvd2VyLmNvbQ0KQ0M6IGFrcG07IGxpbnV4LW1tOyBsaW51eC1rZXJuZWw7IHZpY3Rv cjdxOyBHcmVnIEtyb2FoLUhhcnRtYW4NClN1YmplY3Q6IFJlOiBbQlVHXSBtbS9tZW1wb2xpY3k6 IHBvc3NpYmxlIGRvdWJsZS11bmxvY2sgaW4gbWlncmF0ZV90b19ub2RlKCkgb24gNi42DQpPbiAz LzMvMjYgMDU6MTUsIE1hdHRoZXcgV2lsY294IHdyb3RlOg0KPiBPbiBUdWUsIE1hciAwMywgMjAy NiBhdCAxMDo1Mjo1MUFNICswODAwLCBsaXlpbmczQHN1bmdyb3dwb3dlci5jb20gd3JvdGU6DQo+ PiBIaSBBbmRyZXcsDQo+Pg0KPj4gSSBmb3VuZCB0aGF0IGEgZml4IGlzIHJlcXVpcmVkIGZvciB0 aGlzIHN1Ym1pc3Npb24gaW4gYnJhbmNoIDYuNi4NCj4+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcv cHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3N0YWJsZS9saW51eC5naXQvY29tbWl0Lz9pZD1hMTNi MmI5YjBiMGIwNDYxMmM3ZDgxZTNiM2RmYjQ4NWM1ZjdhYmMzIA0KPiANCj4gQWdyZWVkLCBhbHRo b3VnaCB5b3VyIGVtYWlsIHNob3VsZCBtb3JlIHByb3Blcmx5IGhhdmUgYmVlbiBkaXJlY3RlZCB0 bw0KPiBEYXZpZCBhbmQgcG9zc2libHkgR3JlZy4gIEFyZSB5b3UgZ29pbmcgdG8gc3VibWl0IGEg cGF0Y2ggdG8gZml4IHRoaXMsDQo+IG9yIGRvIHlvdSBwcmVmZXIgdGhhdCBzb21lYm9keSBlbHNl IGRvZXMgaXQ/DQo+IA0KPj4gUmVnYXJkaW5nIHRoZSBkaWZmZXJlbmNlIGJldHdlZW4gYnJhbmNo ZXMgNi42IGFuZCA2LjEyLCBpbiBicmFuY2ggNi42LCBtbWFwX3JlYWRfbG9jaygpIGFuZCBtbWFw X3JlYWRfdW5sb2NrKCkgYXJlIGNhbGxlZCBvdXRzaWRlIHRoZSBtaWdyYXRlX3RvX25vZGUoKSBm dW5jdGlvbi4gDQo+PiBUaGVyZWZvcmUsIG1tYXBfcmVhZF91bmxvY2sobW0pIHNob3VsZCBub3Qg YmUgaW52b2tlZCBpbnNpZGUgbWlncmF0ZV90b19ub2RlKCk7IG90aGVyd2lzZSwgaXQgd291bGQg cmVzdWx0IGluIGEgZG91YmxlIHVubG9jayBvZiB0aGUgbW0uDQo+PiBkaWZmIC0tZ2l0IGEvbW0v bWVtcG9saWN5LmMgYi9tbS9tZW1wb2xpY3kuYw0KPj4gaW5kZXggNTRmMWI3OGQxYjJjMGYuLjk0 Yzc0YzU5NGQxMDJhIDEwMDY0NA0KPj4gLS0tIGEvbW0vbWVtcG9saWN5LmMNCj4+ICsrKyBiL21t L21lbXBvbGljeS5jDQo+PiBAQCAtMTA3MSw2ICsxMDcxLDEwIEBAIHN0YXRpYyBsb25nIG1pZ3Jh dGVfdG9fbm9kZShzdHJ1Y3QgbW1fc3RydWN0ICptbSwgaW50IHNvdXJjZSwgaW50IGRlc3QsDQo+ PiBWTV9CVUdfT04oIShmbGFncyAmIChNUE9MX01GX01PVkUgfCBNUE9MX01GX01PVkVfQUxMKSkp Ow0KPj4gdm1hID0gZmluZF92bWEobW0sIDApOw0KPj4gKyBpZiAodW5saWtlbHkoIXZtYSkpIHsN Cj4+ICsgbW1hcF9yZWFkX3VubG9jayhtbSk7IC8vIHRoaXMgbGluZSBzaG91bGQgYmUgZGVsZXRl ZA0KPj4gKyByZXR1cm4gMDsNCj4+ICsgfQ0KIA0KUmlnaHQsIHRoYXQgdW5sb2NrIG11c3QgZ28u IExldCBtZSBrbm93IGlmIEkgc2hvdWxkIHByZXBhcmUgYSBmaXguDQogDQotLSANCkNoZWVycywN CiANCkRhdmlkDQo= ------=_001_NextPart261848388678_=---- Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =0A
Thanks for your confirm, please help to process it.
=0A

=0A
=0A=0A =0A Normal=0A = 0=0A =0A =0A = =0A 7.8 =E7=A3=85=0A 0=0A 2=0A = =0A false=0A false=0A false=0A =0A = EN-US=0A ZH-CN=0A X-NONE= =0A =0A =0A =0A =0A <= /w:ULTrailSpace>=0A =0A =0A =0A =0A =0A =0A =0A =0A = =0A =0A =0A =0A =0A MicrosoftInternetExplorer4=0A = =0A =0A =0A =0A =0A = =0A =0A =0A =0A <= m:wrapIndent m:val=3D"1440">=0A =0A =0A =0A=0A=0A=0A

Best Regards,

Li Ying , Light Storage Group.  Senior Embedded Sof= tware Engineer

Tel: -=EF=BC=9B Fax: -

Mobile: +86-15651963981

liyin= g3@sungrowpower.com 

www.sungrowpower.com<= /span>

SUNGROW POWER SUPPLY Co., Ltd. 

Add: No.1699 Xiyou Rd., New & High Technology Industr= ial Development Zone, Hefei, P. R. China., 230088

=0A
 
Date: 2026-03-03 17:04
CC: akpm; <= a href=3D"mailto:linux-mm@kvack.org">linux-mm; linux-kernel; victor7q; Greg Kroa= h-Hartman
Subject: Re: [BUG] mm/mempolicy: possi= ble double-unlock in migrate_to_node() on 6.6
O= n 3/3/26 05:15, Matthew Wilcox wrote:
=0A
> On Tue, Mar 03, 20= 26 at 10:52:51AM +0800, liying3@sungrowpower.com wrote:
=0A
>&= gt; Hi Andrew,
=0A
>>
=0A
>> I found that a = fix is required for this submission in branch 6.6.
=0A
>> h= ttps://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id= =3Da13b2b9b0b0b04612c7d81e3b3dfb485c5f7abc3
=0A
>
=0A> Agreed, although your email should more properly have been directe= d to
=0A
> David and possibly Greg.  Are you going to sub= mit a patch to fix this,
=0A
> or do you prefer that somebody = else does it?
=0A
>
=0A
>> Regarding the diffe= rence between branches 6.6 and 6.12, in branch 6.6, mmap_read_lock() and m= map_read_unlock() are called outside the migrate_to_node() function. =0A
>> Therefore, mmap_read_unlock(mm) should not be invoked in= side migrate_to_node(); otherwise, it would result in a double unlock of t= he mm.
=0A
>> diff --git a/mm/mempolicy.c b/mm/mempolicy.c<= /div>=0A
>> index 54f1b78d1b2c0f..94c74c594d102a 100644
=0A=
>> --- a/mm/mempolicy.c
=0A
>> +++ b/mm/mempolic= y.c
=0A
>> @@ -1071,6 +1071,10 @@ static long migrate_to_no= de(struct mm_struct *mm, int source, int dest,
=0A
>> VM_BU= G_ON(!(flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)));
=0A
>&= gt; vma =3D find_vma(mm, 0);
=0A
>> + if (unlikely(!vma)) {=
=0A
>> + mmap_read_unlock(mm); // this line should be dele= ted
=0A
>> + return 0;
=0A
>> + }
=0A 
=0A
Right, that unlock must go. Let me know if I should= prepare a fix.
=0A
 
=0A
--
=0A
Cheers,<= /div>=0A
 
=0A
David
=0A
=0A ------=_001_NextPart261848388678_=------ david@kernel.org;willy@infradead.org;akpm@linux-foundation.org;linux-mm@kvack.org;linux-kernel@vger.kernel.org;victor7q@163.com;gregkh@linuxfoundation.org;