From: Alexey Suchkov <aleks.koyf@gmail.com>
To: aleks.koyf@gmail.com
Cc: akpm@linux-foundation.org, dywoq.contact@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH] [PATCH v2] mm: initialize 'seq' in gup_fast to remove -Wmaybe-uninitialized warning
Date: Mon, 2 Mar 2026 22:34:05 +0300 [thread overview]
Message-ID: <20260302193405.37961-1-dywoq.contact@gmail.com> (raw)
In-Reply-To: <20260302191237.34375-1-dywoq.contact@gmail.com>
The local variable 'seq' in gup_fast (mm/gup.c) was declared
without initialization, which can trigger:
mm/gup.c:3165:20: warning: ‘seq’ may be used uninitialized [-Wmaybe-uninitialized]
Initialize 'seq' to 0. This does not change behavior, since
read_seqcount_retry() always writes to it before use.
Changes since v1:
- Removes the accidental formatting from v1.
Signed-off-by: Alexey Suchkov <dywoq.contact@gmail.com>
---
mm/gup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/gup.c b/mm/gup.c
index 8e7dc2c6e..879798de5 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -3131,7 +3131,7 @@ static unsigned long gup_fast(unsigned long start, unsigned long end,
{
unsigned long flags;
int nr_pinned = 0;
- unsigned seq;
+ unsigned int seq = 0;
if (!IS_ENABLED(CONFIG_HAVE_GUP_FAST) ||
!gup_fast_permitted(start, end))
--
2.53.0
next prev parent reply other threads:[~2026-03-02 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 19:12 [PATCH] " Alexey Suchkov
2026-03-02 19:22 ` Matthew Wilcox
2026-03-02 19:34 ` Alexey Suchkov [this message]
2026-03-02 19:44 ` [PATCH] [PATCH v2] " Matthew Wilcox
2026-03-02 19:57 ` Alexey Suchkov
2026-03-02 19:48 ` Joshua Hahn
2026-03-02 19:53 ` Matthew Wilcox
2026-03-02 20:09 ` Alexey Suchkov
2026-03-02 20:43 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302193405.37961-1-dywoq.contact@gmail.com \
--to=aleks.koyf@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dywoq.contact@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox