From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v2 05/10] mm/damon/core: add damon_merge_two_regions() debug_sanity check
Date: Sun, 1 Mar 2026 09:43:20 -0800 [thread overview]
Message-ID: <20260301174327.76849-6-sj@kernel.org> (raw)
In-Reply-To: <20260301174327.76849-1-sj@kernel.org>
A data corruption could cause damon_merge_two_regions() creating zero
length DAMON regions. Add a sanity check for that under
CONFIG_DAMON_DEBUG_SANITY.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/core.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 2b5aed89d449d..8a3738a17cdd9 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -2473,6 +2473,21 @@ static void kdamond_apply_schemes(struct damon_ctx *c)
mutex_unlock(&c->walk_control_lock);
}
+#ifdef CONFIG_DAMON_DEBUG_SANITY
+static void damon_verify_merge_two_regions(
+ struct damon_region *l, struct damon_region *r)
+{
+ /* damon_merge_two_regions() may created incorrect left region */
+ WARN_ONCE(l->ar.start >= l->ar.end, "l: %lu-%lu, r: %lu-%lu\n",
+ l->ar.start, l->ar.end, r->ar.start, r->ar.end);
+}
+#else
+static void damon_verify_merge_two_regions(
+ struct damon_region *l, struct damon_region *r)
+{
+}
+#endif
+
/*
* Merge two adjacent regions into one region
*/
@@ -2486,6 +2501,7 @@ static void damon_merge_two_regions(struct damon_target *t,
l->nr_accesses_bp = l->nr_accesses * 10000;
l->age = (l->age * sz_l + r->age * sz_r) / (sz_l + sz_r);
l->ar.end = r->ar.end;
+ damon_verify_merge_two_regions(l, r);
damon_destroy_region(r, t);
}
--
2.47.3
next prev parent reply other threads:[~2026-03-01 17:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 17:43 [RFC PATCH v2 00/10] mm/damon: add optional debugging-purpose sanity checks SeongJae Park
2026-03-01 17:43 ` [RFC PATCH v2 01/10] mm/damon: add CONFIG_DAMON_DEBUG_SANITY SeongJae Park
2026-03-01 17:43 ` [RFC PATCH v2 02/10] mm/damon/core: add damon_new_region() debug_sanity check SeongJae Park
2026-03-01 17:43 ` [RFC PATCH v2 03/10] mm/damon/core: add damon_del_region() " SeongJae Park
2026-03-01 17:43 ` [RFC PATCH v2 04/10] mm/damon/core: add damon_nr_regions() " SeongJae Park
2026-03-01 17:43 ` SeongJae Park [this message]
2026-03-01 17:43 ` [RFC PATCH v2 06/10] mm/damon/core: add damon_merge_regions_of() " SeongJae Park
2026-03-01 17:43 ` [RFC PATCH v2 07/10] mm/damon/core: add damon_split_region_at() " SeongJae Park
2026-03-01 17:43 ` [RFC PATCH v2 08/10] mm/damon/core: add damon_reset_aggregated() " SeongJae Park
2026-03-01 17:43 ` [RFC PATCH v2 09/10] mm/damon/tests/.kunitconifg: enable DAMON_DEBUG_SANITY SeongJae Park
2026-03-01 17:43 ` [RFC PATCH v2 10/10] selftests/damon/config: " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260301174327.76849-6-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox