From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BECBFD9E1A for ; Thu, 26 Feb 2026 22:52:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 902EF6B0145; Thu, 26 Feb 2026 17:52:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ACE36B0266; Thu, 26 Feb 2026 17:52:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AFC66B0272; Thu, 26 Feb 2026 17:52:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5A26C6B0145 for ; Thu, 26 Feb 2026 17:52:34 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 098E11C0C8 for ; Thu, 26 Feb 2026 22:52:34 +0000 (UTC) X-FDA: 84488108628.20.DDD51F7 Received: from flow-b7-smtp.messagingengine.com (flow-b7-smtp.messagingengine.com [202.12.124.142]) by imf15.hostedemail.com (Postfix) with ESMTP id B3299A0009 for ; Thu, 26 Feb 2026 22:52:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=shazbot.org header.s=fm3 header.b="o83TYSm/"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="m QieDi2"; dmarc=pass (policy=none) header.from=shazbot.org; spf=pass (imf15.hostedemail.com: domain of alex@shazbot.org designates 202.12.124.142 as permitted sender) smtp.mailfrom=alex@shazbot.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1772146352; a=rsa-sha256; cv=none; b=T4e6TeQ5EXHD3YkwngDtCjlfKpA84LCzmeCzUAzPtDFZ9FrBVjEOJp4bvJmdAJYWMy1eF7 qeA2fGxE11rq+FBu3yVzuilZjLaofaF+6e5C+8Zu3b3eYrEVZSTvO+RG4H1bHe1H0mgzK2 c21Ag/9ibRugvWuZXoISLfrD26/POwc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=shazbot.org header.s=fm3 header.b="o83TYSm/"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="m QieDi2"; dmarc=pass (policy=none) header.from=shazbot.org; spf=pass (imf15.hostedemail.com: domain of alex@shazbot.org designates 202.12.124.142 as permitted sender) smtp.mailfrom=alex@shazbot.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1772146352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=44uo4P/92yZYJcD163y8UHc8z0ZnnckxsAr9PpEhJjk=; b=MUdYm/TkO+ultAm40iAPaJ3YOEHLiXWDV4EQX8HSAaLCQ3WfinvGEnWIxsAJz1Kx6He3M1 y+TDm42j0/Gtfbrf6E7RU28U4ZSQnvgeiIiMlr1pNAYZqeuAMuzX2ANQwv8XLnKwENLyUi 6nA2BMJ4LR/gGiNJz6KWgtbWYWUGoXA= Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailflow.stl.internal (Postfix) with ESMTP id EBF011300BCC; Thu, 26 Feb 2026 17:52:28 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Thu, 26 Feb 2026 17:52:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1772146348; x=1772153548; bh=44uo4P/92yZYJcD163y8UHc8z0ZnnckxsAr9PpEhJjk=; b= o83TYSm/N5K9/2/Rtg8QOuuro4N9DEyyzUyMSplPsN/HHQ4SFtKbd1kGwp9qti8C CvLnqaRv1nJft8p4Y0Kfx3UPhzpppkvrC3+lmXar4Ih+r8yDS0BN+r95ELWuTHYO LCH/xD+NNQ8d3oFyo9vLoYiOMntUFokn9INVsNwb636AF3cZMrDdHlVhQMR4hO1e 7s/OGnE5phRQfxWBF2pc2Hg3jHNw/z+Oa4xIIRlaqUKDmzxaCH0q3AglMZJTnAod GTcOFeay+bxbwjKYMCmBRbqswfGfBbi04mYW7an6R05gtlnDK29AoHRFU/SkoAEi tVIotca6drSoW2xWOmNd8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1772146348; x= 1772153548; bh=44uo4P/92yZYJcD163y8UHc8z0ZnnckxsAr9PpEhJjk=; b=m QieDi29aKWQhWaRpHtkJFXYVNhddIFR7f1/l5RV2JXj5JOe+34TRrGuQiPCDv/8q sjM36sYZIDHM2TGPHAxCACtHKdowQytZzI4RflFQSb3CxaENKe8Em93flZZh1XI2 fjmRj009hat7tVQzvk6S123bFzQGqrO6/M+F9i94o1mZyJkarnMR7K8UZ54Bh24T fNJNab9xC16c8ohNRSoahEGm5WdPpm7ZXwjCDtv+SC8JsjDGZsJdZDeAb0FOwzzL 1pOU0SrAsFwH342Fb6sIn9fs1m27yGiPdJBtFl9p6I7LXjWkkQds8iaA3hT0mKZu hLXSXHpBe9Y8dHfXiA/Fw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvgeejfeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkjghfofggtgfgsehtjeertdertddvnecuhfhrohhmpeetlhgvgicu hghilhhlihgrmhhsohhnuceorghlvgigsehshhgriigsohhtrdhorhhgqeenucggtffrrg htthgvrhhnpedvkeefjeekvdduhfduhfetkedugfduieettedvueekvdehtedvkefgudeg veeuueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grlhgvgiesshhhrgiisghothdrohhrghdpnhgspghrtghpthhtohepgeehpdhmohguvgep shhmthhpohhuthdprhgtphhtthhopegumhgrthhlrggtkhesghhoohhglhgvrdgtohhmpd hrtghpthhtoheprghjrgihrggthhgrnhgurhgrsehnvhhiughirgdrtghomhdprhgtphht thhopehgrhgrfhesrghmrgiiohhnrdgtohhmpdhrtghpthhtoheprghmrghsthhrohesfh gsrdgtohhmpdhrtghpthhtoheprghpohhpphhlvgesnhhvihguihgrrdgtohhmpdhrtghp thhtoheprghkphhmsehlihhnuhigqdhfohhunhgurghtihhonhdrohhrghdprhgtphhtth hopegrnhhkihhtrgesnhhvihguihgrrdgtohhmpdhrtghpthhtohepsghhvghlghgrrghs sehgohhoghhlvgdrtghomhdprhgtphhtthhopegthhhrihhslheskhgvrhhnvghlrdhorh hg X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Feb 2026 17:52:23 -0500 (EST) Date: Thu, 26 Feb 2026 15:52:22 -0700 From: Alex Williamson To: David Matlack Cc: Adithya Jayachandran , Alexander Graf , Alex Mastro , Alistair Popple , Andrew Morton , Ankit Agrawal , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Kevin Tian , kexec@lists.infradead.org, kvm@vger.kernel.org, Leon Romanovsky , Leon Romanovsky , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Lukas Wunner , " =?UTF-8?B?TWljaGHFgg==?= Winiarski" , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Raghavendra Rao Ananta , Rodrigo Vivi , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , "Thomas =?UTF-8?B?SGVsbHN0csO2bQ==?=" , Tomita Moeko , Vipin Sharma , Vivek Kasireddy , William Tu , Yi Liu , Zhu Yanjun , alex@shazbot.org Subject: Re: [PATCH v2 06/22] vfio/pci: Retrieve preserved device files after Live Update Message-ID: <20260226155222.5452a741@shazbot.org> In-Reply-To: <20260129212510.967611-7-dmatlack@google.com> References: <20260129212510.967611-1-dmatlack@google.com> <20260129212510.967611-7-dmatlack@google.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B3299A0009 X-Stat-Signature: sffecknyz5ngq66nzh1qb96893jt3snf X-Rspam-User: X-HE-Tag: 1772146351-952177 X-HE-Meta: U2FsdGVkX1+ldS21zPh29C1mMEKRBbc9IpFVkY2ellUj7ug5ucYsD3pCIxhudZ2C9eK8pBjw6j+0pi2nS0KlzKMsCRDVLtQ4Wcr9mdeFFojbDtqA04YJT5gomoJu6ckv88bQZV9sbNaldg+UASNe4ONAzdFIIBMUuMm4Bz83AbIkUgx46NMh5XLm/jtMCwQqwGPJtXJcQGj1xxYIgN4GZGiwQM905n3zL4Hj4qRZ7LbgVUb3+6vWIAjByutj1uaSLNXEiTx8QdrG2t163Qrr/gUjCOytMU2xJSCZzfesT5PedVWZruVT2e/NkzuiaPpmJfAI8J2/dCK3ojq3etJrJ85ykGUxm0EC74Vnig4IwENM7DoKBr5FGPLlIHtuRNLW34/JZzenO984ZFQcqMYgzVOdpHelvu70UgbZK5FzSSNYYZkegtM3rUDD1MMXj84S/D0gItMF8KZW5u57Uh3KG+JGauw+nMXD0U2v4nBxDli8/nUaoaMHzJl8jz2iREphKbXnJQvw9e4ngVR5e9LRdI+gMowX73Nzlb7tkpxqJYgbCfaPBnUXn6BpR2V09LdFh5gRqC78f+hna5qa+WhlIMB/eKjts9En+htJhfUKz4jPUkliC+Y8WIXR00i2/0etmcYPCJ4iPa17Oz6Nyu5x8dz16dvIBMSbFR1vlAA6Wb7iqvksjVX1MzulsfxQrDOtTIHWYZ9JsV+ieaEdocfS5f2MFXcCw7Xztlq9vE0ZbpJ9r6Zxc42EX8F7hMtkqdyxCr0+Zga4a7a5haPAurOYZyHNzEXzCtj8tl+BWpZU6LeRlpy4lzOPZfVu+bfgb2HS+patHQScg0LvAB/Qv8Y3TtGSIhDSc1yzcLbwBJFrQf3gvHCuSxYAlKGIMU3Gh9DDDV146pFL/zTWMdw07YfH5Ri8nlgTSsC+ptaI/3+8XNUlvkJYaBe+luntadHT5/dnnVjiuTk9hmSIc+N+oQI 19P9Sr+0 k7PBjVCt05s+m6Oxdeiwr3v5nDZFiQNUOQwZS2N/9WzRKJbU9FopX74GcioZ4UvZfBDxRYy8mwHackOEmHjQ31cAjvYE7DhqV9XF7rUlws1RvXGtsECo+WC9CG7RPYfr2M1cYCOWhaKGktWhO/52zCOI0xETkWYSqqZ+jDsxGLSLV/i3bqIYB/cIuXPncl8W7xSBr3GWl/F5EnnkltlsjeeZY5DAVlwfNFpLoWcTuKLjFapIXmi5E2CF5YL/V8ShJjf9rSNLm1SlEc9fZWAnz44qxy7tOFOnF3DlecgO4mVABcOLejPmscGvsOXwAetYDmjI5ILlAxTNdG4+n920kYUwyaWpoHugWNMQK Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 29 Jan 2026 21:24:53 +0000 David Matlack wrote: > From: Vipin Sharma > > Enable userspace to retrieve preserved VFIO device files from VFIO after > a Live Update by implementing the retrieve() and finish() file handler > callbacks. > > Use an anonymous inode when creating the file, since the retrieved > device file is not opened through any particular cdev inode, and the > cdev inode does not matter in practice. > > For now the retrieved file is functionally equivalent a opening the > corresponding VFIO cdev file. Subsequent commits will leverage the > preserved state associated with the retrieved file to preserve bits of > the device across Live Update. > > Signed-off-by: Vipin Sharma > Co-developed-by: David Matlack > Signed-off-by: David Matlack > --- > drivers/vfio/device_cdev.c | 21 ++++++--- > drivers/vfio/pci/vfio_pci_liveupdate.c | 60 +++++++++++++++++++++++++- > drivers/vfio/vfio_main.c | 13 ++++++ > include/linux/vfio.h | 12 ++++++ > 4 files changed, 98 insertions(+), 8 deletions(-) > > diff --git a/drivers/vfio/device_cdev.c b/drivers/vfio/device_cdev.c > index 8ceca24ac136..935f84a35875 100644 > --- a/drivers/vfio/device_cdev.c > +++ b/drivers/vfio/device_cdev.c > @@ -16,14 +16,8 @@ void vfio_init_device_cdev(struct vfio_device *device) > device->cdev.owner = THIS_MODULE; > } > > -/* > - * device access via the fd opened by this function is blocked until > - * .open_device() is called successfully during BIND_IOMMUFD. > - */ > -int vfio_device_fops_cdev_open(struct inode *inode, struct file *filep) > +int __vfio_device_fops_cdev_open(struct vfio_device *device, struct file *filep) > { > - struct vfio_device *device = container_of(inode->i_cdev, > - struct vfio_device, cdev); > struct vfio_device_file *df; > int ret; > > @@ -52,6 +46,19 @@ int vfio_device_fops_cdev_open(struct inode *inode, struct file *filep) > vfio_device_put_registration(device); > return ret; > } > +EXPORT_SYMBOL_GPL(__vfio_device_fops_cdev_open); I really dislike that we're exporting the underscore variant, which implies it's an internal function that the caller should understand the constraints, without outlining any constraints. I'm not sure what a good alternative is. We can drop fops since this isn't called from file_operations. Maybe vfio_device_cdev_open_file(). > + > +/* > + * device access via the fd opened by this function is blocked until > + * .open_device() is called successfully during BIND_IOMMUFD. > + */ > +int vfio_device_fops_cdev_open(struct inode *inode, struct file *filep) > +{ > + struct vfio_device *device = container_of(inode->i_cdev, > + struct vfio_device, cdev); > + > + return __vfio_device_fops_cdev_open(device, filep); > +} > > static void vfio_df_get_kvm_safe(struct vfio_device_file *df) > { > diff --git a/drivers/vfio/pci/vfio_pci_liveupdate.c b/drivers/vfio/pci/vfio_pci_liveupdate.c > index f01de98f1b75..7f4117181fd0 100644 > --- a/drivers/vfio/pci/vfio_pci_liveupdate.c > +++ b/drivers/vfio/pci/vfio_pci_liveupdate.c > @@ -8,6 +8,8 @@ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > +#include > +#include > #include > #include > #include > @@ -108,13 +110,68 @@ static int vfio_pci_liveupdate_freeze(struct liveupdate_file_op_args *args) > return ret; > } > > +static int match_device(struct device *dev, const void *arg) > +{ > + struct vfio_device *device = container_of(dev, struct vfio_device, device); > + const struct vfio_pci_core_device_ser *ser = arg; > + struct pci_dev *pdev; > + > + pdev = dev_is_pci(device->dev) ? to_pci_dev(device->dev) : NULL; > + if (!pdev) > + return false; > + > + return ser->bdf == pci_dev_id(pdev) && ser->domain == pci_domain_nr(pdev->bus); > +} > + > static int vfio_pci_liveupdate_retrieve(struct liveupdate_file_op_args *args) > { > - return -EOPNOTSUPP; > + struct vfio_pci_core_device_ser *ser; > + struct vfio_device *device; > + struct file *file; > + int ret; > + > + ser = phys_to_virt(args->serialized_data); > + > + device = vfio_find_device(ser, match_device); > + if (!device) > + return -ENODEV; > + > + /* > + * Simulate opening the character device using an anonymous inode. The > + * returned file has the same properties as a cdev file (e.g. operations > + * are blocked until BIND_IOMMUFD is called). > + */ > + file = anon_inode_getfile_fmode("[vfio-device-liveupdate]", > + &vfio_device_fops, NULL, > + O_RDWR, FMODE_PREAD | FMODE_PWRITE); > + if (IS_ERR(file)) { > + ret = PTR_ERR(file); > + goto out; > + } > + > + ret = __vfio_device_fops_cdev_open(device, file); > + if (ret) { > + fput(file); Don't we end up calling vfio_device_fops.release with NULL file->private_data here with inevitable segfaults? Thanks, Alex > + goto out; > + } > + > + args->file = file; > + > +out: > + /* Drop the reference from vfio_find_device() */ > + put_device(&device->device); > + > + return ret; > +} > + > +static bool vfio_pci_liveupdate_can_finish(struct liveupdate_file_op_args *args) > +{ > + return args->retrieved; > } > > static void vfio_pci_liveupdate_finish(struct liveupdate_file_op_args *args) > { > + kho_restore_free(phys_to_virt(args->serialized_data)); > } > > static const struct liveupdate_file_ops vfio_pci_liveupdate_file_ops = { > @@ -123,6 +180,7 @@ static const struct liveupdate_file_ops vfio_pci_liveupdate_file_ops = { > .unpreserve = vfio_pci_liveupdate_unpreserve, > .freeze = vfio_pci_liveupdate_freeze, > .retrieve = vfio_pci_liveupdate_retrieve, > + .can_finish = vfio_pci_liveupdate_can_finish, > .finish = vfio_pci_liveupdate_finish, > .owner = THIS_MODULE, > }; > diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c > index 276f615f0c28..89c5feef75d5 100644 > --- a/drivers/vfio/vfio_main.c > +++ b/drivers/vfio/vfio_main.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1758,6 +1759,18 @@ int vfio_dma_rw(struct vfio_device *device, dma_addr_t iova, void *data, > } > EXPORT_SYMBOL(vfio_dma_rw); > > +struct vfio_device *vfio_find_device(const void *data, device_match_t match) > +{ > + struct device *device; > + > + device = class_find_device(vfio.device_class, NULL, data, match); > + if (!device) > + return NULL; > + > + return container_of(device, struct vfio_device, device); > +} > +EXPORT_SYMBOL_GPL(vfio_find_device); > + > /* > * Module/class support > */ > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > index 9aa1587fea19..dc592dc00f89 100644 > --- a/include/linux/vfio.h > +++ b/include/linux/vfio.h > @@ -419,4 +419,16 @@ int vfio_virqfd_enable(void *opaque, int (*handler)(void *, void *), > void vfio_virqfd_disable(struct virqfd **pvirqfd); > void vfio_virqfd_flush_thread(struct virqfd **pvirqfd); > > +#if IS_ENABLED(CONFIG_VFIO_DEVICE_CDEV) > +int __vfio_device_fops_cdev_open(struct vfio_device *device, struct file *filep); > +#else > +static inline int __vfio_device_fops_cdev_open(struct vfio_device *device, > + struct file *filep) > +{ > + return -EOPNOTSUPP; > +} > +#endif /* IS_ENABLED(CONFIG_VFIO_DEVICE_CDEV) */ > + > +struct vfio_device *vfio_find_device(const void *data, device_match_t match); > + > #endif /* VFIO_H */