From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Clapinski <mclapinski@google.com>
Cc: Evangelos Petrongonas <epetron@amazon.de>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Mike Rapoport <rppt@kernel.org>,
Pratyush Yadav <pratyush@kernel.org>,
Alexander Graf <graf@amazon.com>,
kexec@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] kho: make preserved pages compatible with deferred struct page init
Date: Tue, 24 Feb 2026 10:30:22 -0800 [thread overview]
Message-ID: <20260224103022.37b8b6d1cd11e11aef192c87@linux-foundation.org> (raw)
In-Reply-To: <20260220165203.3213375-3-mclapinski@google.com>
On Fri, 20 Feb 2026 17:52:03 +0100 Michal Clapinski <mclapinski@google.com> wrote:
> From: Evangelos Petrongonas <epetron@amazon.de>
>
> When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, struct page
> initialization is deferred to parallel kthreads that run later
> in the boot process.
>
> During KHO restoration, deserialize_bitmap() writes metadata for
> each preserved memory region. However, if the struct page has not been
> initialized, this write targets uninitialized memory, potentially
> leading to errors like:
> BUG: unable to handle page fault for address: ...
>
> Fix this by introducing kho_get_preserved_page(), which ensures
> all struct pages in a preserved region are initialized by calling
> init_deferred_page() which is a no-op when deferred init is disabled
> or when the struct page is already initialized.
>
> ...
>
> static void __init deserialize_bitmap(unsigned int order,
> struct khoser_mem_bitmap_ptr *elm)
> {
Doesn't exist any more!
Can you please rework, retest and resend against mm.git's mm-new
branch?
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Thanks.
prev parent reply other threads:[~2026-02-24 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 16:52 [PATCH v4 0/2] kho: add support for " Michal Clapinski
2026-02-20 16:52 ` [PATCH v4 1/2] kho: fix deferred init of kho scratch Michal Clapinski
2026-02-23 11:07 ` Mike Rapoport
2026-02-20 16:52 ` [PATCH v4 2/2] kho: make preserved pages compatible with deferred struct page init Michal Clapinski
2026-02-24 18:30 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224103022.37b8b6d1cd11e11aef192c87@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=epetron@amazon.de \
--cc=graf@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mclapinski@google.com \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox