linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
	"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
	"Dave Hansen" <dave.hansen@linux.intel.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	akpm@linux-foundation.org, Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Subject: [PATCH v6 3/4] x86/mm/pat: Convert populate_pgd() to use page table apis
Date: Wed, 18 Feb 2026 18:03:53 -0800	[thread overview]
Message-ID: <20260219020354.321088-4-vishal.moola@gmail.com> (raw)
In-Reply-To: <20260219020354.321088-1-vishal.moola@gmail.com>

We need all allocation and free sites to use the ptdesc APIs in order to
allocate them separately from regular pages. Convert the remaining
get_zeroed_page() calls to the generic page table apis, since those
use ptdescs already.

Pass through init_mm since these are kernel page tables, both functions
need it to identify kernel page tables. Also, the generic
implementations don't use the second argument. Pass it a placeholder so
we don't have to reimplement it or risk breaking other architectures.

Its not obvious if these pages get freed. Regardless, the only other
possible free paths have already been converted, and my frozen page
table test kernel hasn't found any issues.

Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
---
 arch/x86/mm/pat/set_memory.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
index 655bef618ea0..8f74d4bfd591 100644
--- a/arch/x86/mm/pat/set_memory.c
+++ b/arch/x86/mm/pat/set_memory.c
@@ -1746,7 +1746,11 @@ static int populate_pgd(struct cpa_data *cpa, unsigned long addr)
 	pgd_entry = cpa->pgd + pgd_index(addr);
 
 	if (pgd_none(*pgd_entry)) {
-		p4d = (p4d_t *)get_zeroed_page(GFP_KERNEL);
+		/* The generic implementation of p4d_alloc_one()
+		 * doesn't use the second argument. Pass it 0 as
+		 * a placeholder.
+		 */
+		p4d = p4d_alloc_one(&init_mm, 0);
 		if (!p4d)
 			return -1;
 
@@ -1758,7 +1762,11 @@ static int populate_pgd(struct cpa_data *cpa, unsigned long addr)
 	 */
 	p4d = p4d_offset(pgd_entry, addr);
 	if (p4d_none(*p4d)) {
-		pud = (pud_t *)get_zeroed_page(GFP_KERNEL);
+		/* The generic implementation of pud_alloc_one()
+		 * doesn't use the second argument. Pass it 0 as
+		 * a placeholder.
+		 */
+		pud = pud_alloc_one(&init_mm, 0);
 		if (!pud)
 			return -1;
 
-- 
2.53.0



  parent reply	other threads:[~2026-02-19  2:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19  2:03 [PATCH v6 0/4] Convert x86/mm/pat to generic " Vishal Moola (Oracle)
2026-02-19  2:03 ` [PATCH v6 1/4] x86/mm/pat: Convert pte code to use " Vishal Moola (Oracle)
2026-02-19  2:03 ` [PATCH v6 2/4] x86/mm/pat: Convert pmd " Vishal Moola (Oracle)
2026-02-19  2:03 ` Vishal Moola (Oracle) [this message]
2026-02-19  2:03 ` [PATCH v6 4/4] x86/mm/pat: Convert split_large_page() to use ptdescs Vishal Moola (Oracle)
2026-02-20 10:25 ` [PATCH v6 0/4] Convert x86/mm/pat to generic page table apis Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260219020354.321088-4-vishal.moola@gmail.com \
    --to=vishal.moola@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rppt@kernel.org \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox