linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Gregory Price <gourry@gourry.net>
Cc: linux-mm@kvack.org, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-team@meta.com,
	david@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org,
	rafael@kernel.org, dakr@kernel.org, akpm@linux-foundation.org,
	lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
	vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH] mm: name the anonymous MMOP enum as enum mmop
Date: Thu, 12 Feb 2026 10:13:25 -0800	[thread overview]
Message-ID: <20260212181325.riolqzwvhqjmv6mk@offworld> (raw)
In-Reply-To: <20260211215447.2194189-1-gourry@gourry.net>

On Wed, 11 Feb 2026, Gregory Price wrote:

>Give the MMOP enum (MMOP_OFFLINE, MMOP_ONLINE, etc) a proper type
>name so the compiler can help catch invalid values being assigned to
>variables of this type.
>
>Leave the existing functions returning int alone to allow for
>value-or-error pattern to remain unchanged without churn.
>
>mmop_default_online_type is left as int because it uses the -1
>sentinal value to signal it hasn't been initialized yet.
>
>Keep the uint8_t buffer in offline_and_remove_memory() as-is for
>space efficiency, with an explicit cast when we consume the value.
>
>Move the enum definition before the CONFIG_MEMORY_HOTPLUG guard so
>it is unconditionally available for struct memory_block in memory.h.
>
>No functional change.

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>


  parent reply	other threads:[~2026-02-12 18:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 21:54 Gregory Price
2026-02-11 22:18 ` Cheatham, Benjamin
2026-02-12 16:33   ` Gregory Price
2026-02-12  8:56 ` David Hildenbrand (Arm)
2026-02-12 16:03 ` Dave Jiang
2026-02-12 18:13 ` Davidlohr Bueso [this message]
2026-02-19 11:18 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260212181325.riolqzwvhqjmv6mk@offworld \
    --to=dave@stgolabs.net \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=dakr@kernel.org \
    --cc=david@kernel.org \
    --cc=gourry@gourry.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathan.cameron@huawei.com \
    --cc=kernel-team@meta.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=rafael@kernel.org \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox