* Re: [PATCH] selftests/mm: Remove duplicate include of unistd.h
2026-02-11 6:43 [PATCH] selftests/mm: Remove duplicate include of unistd.h Chen Ni
@ 2026-02-12 1:18 ` Miaohe Lin
2026-02-12 1:19 ` SeongJae Park
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Miaohe Lin @ 2026-02-12 1:18 UTC (permalink / raw)
To: Chen Ni
Cc: nao.horiguchi, david, lorenzo.stoakes, Liam.Howlett, vbabka,
rppt, surenb, mhocko, linux-mm, linux-kselftest, linux-kernel,
akpm, shuah
On 2026/2/11 14:43, Chen Ni wrote:
> Remove duplicate inclusion of unistd.h in memory-failure.c to clean up
> redundant code.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Oh, I missed that. Thanks.
Acked-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks.
.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] selftests/mm: Remove duplicate include of unistd.h
2026-02-11 6:43 [PATCH] selftests/mm: Remove duplicate include of unistd.h Chen Ni
2026-02-12 1:18 ` Miaohe Lin
@ 2026-02-12 1:19 ` SeongJae Park
2026-02-12 16:44 ` Liam R. Howlett
2026-02-12 17:03 ` Dev Jain
3 siblings, 0 replies; 5+ messages in thread
From: SeongJae Park @ 2026-02-12 1:19 UTC (permalink / raw)
To: Chen Ni
Cc: SeongJae Park, akpm, shuah, linmiaohe, nao.horiguchi, david,
lorenzo.stoakes, Liam.Howlett, vbabka, rppt, surenb, mhocko,
linux-mm, linux-kselftest, linux-kernel
On Wed, 11 Feb 2026 14:43:11 +0800 Chen Ni <nichen@iscas.ac.cn> wrote:
> Remove duplicate inclusion of unistd.h in memory-failure.c to clean up
> redundant code.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/mm: Remove duplicate include of unistd.h
2026-02-11 6:43 [PATCH] selftests/mm: Remove duplicate include of unistd.h Chen Ni
2026-02-12 1:18 ` Miaohe Lin
2026-02-12 1:19 ` SeongJae Park
@ 2026-02-12 16:44 ` Liam R. Howlett
2026-02-12 17:03 ` Dev Jain
3 siblings, 0 replies; 5+ messages in thread
From: Liam R. Howlett @ 2026-02-12 16:44 UTC (permalink / raw)
To: Chen Ni
Cc: akpm, shuah, linmiaohe, nao.horiguchi, david, lorenzo.stoakes,
vbabka, rppt, surenb, mhocko, linux-mm, linux-kselftest,
linux-kernel
* Chen Ni <nichen@iscas.ac.cn> [260211 01:44]:
> Remove duplicate inclusion of unistd.h in memory-failure.c to clean up
> redundant code.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> tools/testing/selftests/mm/memory-failure.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/memory-failure.c b/tools/testing/selftests/mm/memory-failure.c
> index 3d9e0b9ffb41..032ed952057c 100644
> --- a/tools/testing/selftests/mm/memory-failure.c
> +++ b/tools/testing/selftests/mm/memory-failure.c
> @@ -13,7 +13,6 @@
> #include <unistd.h>
> #include <signal.h>
> #include <setjmp.h>
> -#include <unistd.h>
> #include <fcntl.h>
> #include <sys/vfs.h>
> #include <linux/magic.h>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/mm: Remove duplicate include of unistd.h
2026-02-11 6:43 [PATCH] selftests/mm: Remove duplicate include of unistd.h Chen Ni
` (2 preceding siblings ...)
2026-02-12 16:44 ` Liam R. Howlett
@ 2026-02-12 17:03 ` Dev Jain
3 siblings, 0 replies; 5+ messages in thread
From: Dev Jain @ 2026-02-12 17:03 UTC (permalink / raw)
To: Chen Ni, akpm, shuah
Cc: linmiaohe, nao.horiguchi, david, lorenzo.stoakes, Liam.Howlett,
vbabka, rppt, surenb, mhocko, linux-mm, linux-kselftest,
linux-kernel
On 11/02/26 12:13 pm, Chen Ni wrote:
> Remove duplicate inclusion of unistd.h in memory-failure.c to clean up
> redundant code.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
Reviewed-by: Dev Jain <dev.jain@arm.com>
> tools/testing/selftests/mm/memory-failure.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/memory-failure.c b/tools/testing/selftests/mm/memory-failure.c
> index 3d9e0b9ffb41..032ed952057c 100644
> --- a/tools/testing/selftests/mm/memory-failure.c
> +++ b/tools/testing/selftests/mm/memory-failure.c
> @@ -13,7 +13,6 @@
> #include <unistd.h>
> #include <signal.h>
> #include <setjmp.h>
> -#include <unistd.h>
> #include <fcntl.h>
> #include <sys/vfs.h>
> #include <linux/magic.h>
^ permalink raw reply [flat|nested] 5+ messages in thread