From: Honglei Huang <honglei1.huang@amd.com>
To: <Felix.Kuehling@amd.com>, <alexander.deucher@amd.com>,
<christian.koenig@amd.com>, <Ray.Huang@amd.com>
Cc: <dmitry.osipenko@collabora.com>, <Xinhui.Pan@amd.com>,
<airlied@gmail.com>, <daniel@ffwll.ch>,
<amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <akpm@linux-foundation.org>,
<honghuan@amd.com>
Subject: [PATCH v3 5/8] drm/amdkfd: Implement batch userptr page management
Date: Fri, 6 Feb 2026 14:25:54 +0800 [thread overview]
Message-ID: <20260206062557.3718801-6-honglei1.huang@amd.com> (raw)
In-Reply-To: <20260206062557.3718801-1-honglei1.huang@amd.com>
From: Honglei Huang <honghuan@amd.com>
Add core page management functions for batch userptr allocations.
This adds:
- get_user_pages_batch(): gets user pages for a single range within
a batch allocation using HMM
- set_user_pages_batch(): populates TTM page array from multiple
HMM ranges
Signed-off-by: Honglei Huang <honghuan@amd.com>
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 54 +++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index af6db20de..7aca1868d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -1200,6 +1200,60 @@ static const struct mmu_interval_notifier_ops amdgpu_amdkfd_hsa_batch_ops = {
.invalidate = amdgpu_amdkfd_invalidate_userptr_batch,
};
+static int get_user_pages_batch(struct mm_struct *mm,
+ struct kgd_mem *mem,
+ struct user_range_info *range,
+ struct hmm_range **range_hmm, bool readonly)
+{
+ struct vm_area_struct *vma;
+ int r = 0;
+
+ *range_hmm = NULL;
+
+ if (!mmget_not_zero(mm))
+ return -ESRCH;
+
+ mmap_read_lock(mm);
+ vma = vma_lookup(mm, range->start);
+ if (unlikely(!vma)) {
+ r = -EFAULT;
+ goto out_unlock;
+ }
+
+ r = amdgpu_hmm_range_get_pages(&mem->batch_notifier, range->start,
+ range->size >> PAGE_SHIFT, readonly,
+ NULL, range_hmm);
+
+out_unlock:
+ mmap_read_unlock(mm);
+ mmput(mm);
+ return r;
+}
+
+static int set_user_pages_batch(struct ttm_tt *ttm,
+ struct user_range_info *ranges,
+ uint32_t nranges)
+{
+ uint32_t i, j, k = 0, range_npfns;
+
+ for (i = 0; i < nranges; ++i) {
+ if (!ranges[i].range || !ranges[i].range->hmm_pfns)
+ return -EINVAL;
+
+ range_npfns = (ranges[i].range->end - ranges[i].range->start) >>
+ PAGE_SHIFT;
+
+ if (k + range_npfns > ttm->num_pages)
+ return -EOVERFLOW;
+
+ for (j = 0; j < range_npfns; ++j)
+ ttm->pages[k++] =
+ hmm_pfn_to_page(ranges[i].range->hmm_pfns[j]);
+ }
+
+ return 0;
+}
+
/* Reserving a BO and its page table BOs must happen atomically to
* avoid deadlocks. Some operations update multiple VMs at once. Track
* all the reservation info in a context structure. Optionally a sync
--
2.34.1
next prev parent reply other threads:[~2026-02-06 6:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 6:25 [PATCH v3 0/8] drm/amdkfd: Add batch userptr allocation support Honglei Huang
2026-02-06 6:25 ` [PATCH v3 1/8] drm/amdkfd: Add userptr batch allocation UAPI structures Honglei Huang
2026-02-06 6:25 ` [PATCH v3 2/8] drm/amdkfd: Add user_range_info infrastructure to kgd_mem Honglei Huang
2026-02-06 6:25 ` [PATCH v3 3/8] drm/amdkfd: Implement interval tree for userptr ranges Honglei Huang
2026-02-06 6:25 ` [PATCH v3 4/8] drm/amdkfd: Add batch MMU notifier support Honglei Huang
2026-02-06 6:25 ` Honglei Huang [this message]
2026-02-06 6:25 ` [PATCH v3 6/8] drm/amdkfd: Add batch allocation function and export API Honglei Huang
2026-02-06 6:25 ` [PATCH v3 7/8] drm/amdkfd: Unify userptr cleanup and update paths Honglei Huang
2026-02-06 6:25 ` [PATCH v3 8/8] drm/amdkfd: Wire up batch allocation in ioctl handler Honglei Huang
2026-02-06 13:56 ` [PATCH v3 0/8] drm/amdkfd: Add batch userptr allocation support Christian König
2026-02-09 6:14 ` Honglei Huang
2026-02-09 10:16 ` Christian König
2026-02-09 12:52 ` Honglei Huang
2026-02-09 12:59 ` Christian König
2026-02-09 13:11 ` Honglei Huang
2026-02-09 13:27 ` Christian König
2026-02-09 14:16 ` Honglei Huang
2026-02-09 14:25 ` Christian König
2026-02-09 14:44 ` Honglei Huang
2026-02-09 15:07 ` Christian König
2026-02-09 15:46 ` Honglei Huang
2026-02-09 17:37 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206062557.3718801-6-honglei1.huang@amd.com \
--to=honglei1.huang@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=honghuan@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox