[PATCH] mm: bail out from partial cgroup_reclaim inside shrink_lruvec

[PATCH] mm: bail out from partial cgroup_reclaim inside shrink_lruvec

[zhaoyang.huang]

From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>

Oversize reclaiming observed in "echo xxx > memory.reclaim". This commit
would like to sync the stop creteria in shrink_node_memcgs to
shrink_lruvec to have partial cgroup_reclaim bail out as early as it can
be.

Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
 mm/vmscan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 670fe9fae5ba..03bda1094621 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4832,8 +4832,8 @@ static bool should_abort_scan(struct lruvec *lruvec, struct scan_control *sc)
 	int i;
 	enum zone_watermarks mark;
 
-	/* don't abort memcg reclaim to ensure fairness */
-	if (!root_reclaim(sc))
+	/* don't abort full walk memcg reclaim to ensure fairness */
+	if (!root_reclaim(sc) && sc->memcg_full_walk)
 		return false;
 
 	if (sc->nr_reclaimed >= max(sc->nr_to_reclaim, compact_gap(sc->order)))
-- 
2.25.1

Re: [PATCH] mm: bail out from partial cgroup_reclaim inside shrink_lruvec

[Zhaoyang Huang]

On Thu, Feb 5, 2026 at 2:47 PM zhaoyang.huang <zhaoyang.huang@unisoc.com> wrote:
>
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> Oversize reclaiming observed in "echo xxx > memory.reclaim". This commit
> would like to sync the stop criteria in shrink_node_memcgs to
> shrink_lruvec to have partial cgroup_reclaim bail out as early as it can
> be.
>
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> ---
>  mm/vmscan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 670fe9fae5ba..03bda1094621 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4832,8 +4832,8 @@ static bool should_abort_scan(struct lruvec *lruvec, struct scan_control *sc)
>         int i;
>         enum zone_watermarks mark;
>
> -       /* don't abort memcg reclaim to ensure fairness */
> -       if (!root_reclaim(sc))
> +       /* don't abort full walk memcg reclaim to ensure fairness */
> +       if (!root_reclaim(sc) && sc->memcg_full_walk)
>                 return false;
>
>         if (sc->nr_reclaimed >= max(sc->nr_to_reclaim, compact_gap(sc->order)))
> --
Talk more about motivation. Nowadays, android systems replace madivse
with memory.reclaim to implement user space memory management which
desires to reclaim a certain amount of memcg's memory. However,
oversized reclaiming is observed as there is no limitation within
try_to_shrink_lruvec when MGLRU enabled. This commit would like to fix
this by judging sc->memcg_full_walk.

> 2.25.1
>