From: Joshua Hahn <joshua.hahnjy@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Ingyu Jang <ingyujang25@korea.ac.kr>,
linux-mm@kvack.org, akpm@linux-foundation.org, david@kernel.org
Subject: Re: [Question] Dead code in copy_pud_range() for copy_huge_pud() error check?
Date: Mon, 2 Feb 2026 07:50:20 -0800 [thread overview]
Message-ID: <20260202155021.381552-1-joshua.hahnjy@gmail.com> (raw)
In-Reply-To: <aYDEsAWxcdU4PcvM@casper.infradead.org>
On Mon, 2 Feb 2026 15:37:20 +0000 Matthew Wilcox <willy@infradead.org> wrote:
> On Mon, Feb 02, 2026 at 07:28:38AM -0800, Joshua Hahn wrote:
> > My guess is that copy_pud_range tried to imitate copy_pmd_range and added
> > the -ENOMEM check. copy_huge_pmd can return -ENOMEM though, so it seems
> > like this is what was missed when copying the function over.
> >
> > If you have other changes in this area, this might be a good candidate
> > for a small fix-up to be included in the series? : -) The whole if
> > block inside pud_trans_huge(...) can be simplified quite a bit:
>
> Please don't encourage people to make changes to mm code when you aren't
> the maintainer. The last thing we need is more tweaky little changes
> that need to be carefully reviewed in case they have a subtle bug.
Hello Matthew,
You're right, sorry about that. I'll be more mindful in the future.
Have a great day!
Joshua
next prev parent reply other threads:[~2026-02-02 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 17:28 Ingyu Jang
2026-02-02 15:28 ` Joshua Hahn
2026-02-02 15:37 ` Matthew Wilcox
2026-02-02 15:50 ` Joshua Hahn [this message]
2026-02-02 15:40 ` David Hildenbrand (arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202155021.381552-1-joshua.hahnjy@gmail.com \
--to=joshua.hahnjy@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=ingyujang25@korea.ac.kr \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox