linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>
Cc: Kevin Lourenco <klourencodev@gmail.com>,
	linux-mm@kvack.org, Kevin Lourenco <k.lourenco@criteo.com>
Subject: Re: [PATCH] mm/fadvise: validate offset in generic_fadvise
Date: Sat, 31 Jan 2026 16:43:10 -0800	[thread overview]
Message-ID: <20260131164310.048caf9636063986a8b517e6@linux-foundation.org> (raw)
In-Reply-To: <1690da61-412a-457a-9bb4-1135838135da@kernel.org>

On Tue, 6 Jan 2026 20:46:14 +0100 "David Hildenbrand (Red Hat)" <david@kernel.org> wrote:

> > Since I think nobody intentionally passes negative values and since
> > that makes no sense semantically speaking, I think we can consider it
> 
> Well, then why document negative length? ;) We should be as clear as 
> possible in the documentation.
> 
> If POSIX would have been clearer we wouldn't have this discussion :)
> 
> > unnecessary to update the man page right now and only think about it
> > in the future if a negative offset gains a new meaning, for example.
> > 
> > Wdyt?
> 
> Likely we should really update the man page to reflect reality. 
> "Starting with Linux v7.0, posix_fadvise() will fail with ...".
> 
> Given that FreeBSD rejects negative offsets I guess we are good.

I'm still not sure what to do with this.

Kevin, would you have time to update the changelog with the additional
things we've discussed: linux manpages, POSIX, freebsd etc?  Then
please resend, cc'ing linux-fsdevel, Jan Kara and anyone else we can
think of ;)

Thanks.


  reply	other threads:[~2026-02-01  0:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-22 14:18 klourencodev
2025-12-22 17:52 ` Andrew Morton
2025-12-22 23:38   ` Kevin Lourenco
2025-12-23  9:45 ` David Hildenbrand (Red Hat)
2025-12-23 16:16   ` Kevin Lourenco
2026-01-06 19:46     ` David Hildenbrand (Red Hat)
2026-02-01  0:43       ` Andrew Morton [this message]
2026-02-04 20:41         ` Kevin Lourenco
2026-02-08 13:57           ` [PATCH v2] " klourencodev
2026-02-09  8:06             ` David Hildenbrand (Arm)
2026-02-09 10:56             ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260131164310.048caf9636063986a8b517e6@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=k.lourenco@criteo.com \
    --cc=klourencodev@gmail.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox