linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: lirongqing <lirongqing@baidu.com>
To: <sj@kernel.org>, <akpm@linux-foundation.org>,
	<damon@lists.linux.dev>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Cc: Li RongQing <lirongqing@baidu.com>
Subject: [PATCH] mm/damon: remove __read_mostly from memory_idle_ms_percentiles
Date: Fri, 30 Jan 2026 03:56:03 -0500	[thread overview]
Message-ID: <20260130085603.1814-1-lirongqing@baidu.com> (raw)

From: Li RongQing <lirongqing@baidu.com>

The 'memory_idle_ms_percentiles' array in DAMON_STAT is updated
frequently by the kernel to reflect the latest idle time statistics.
Marking it as '__read_mostly' is inappropriate for data that is
regularly written to, as it can lead to cache pollution in the
read-mostly section.

Remove the '__read_mostly' annotation to accurately reflect the
variable's usage pattern.

Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 mm/damon/stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/damon/stat.c b/mm/damon/stat.c
index ed8e362..5c4eec0 100644
--- a/mm/damon/stat.c
+++ b/mm/damon/stat.c
@@ -34,7 +34,7 @@ module_param(estimated_memory_bandwidth, ulong, 0400);
 MODULE_PARM_DESC(estimated_memory_bandwidth,
 		"Estimated memory bandwidth usage in bytes per second");
 
-static long memory_idle_ms_percentiles[101] __read_mostly = {0,};
+static long memory_idle_ms_percentiles[101] = {0,};
 module_param_array(memory_idle_ms_percentiles, long, NULL, 0400);
 MODULE_PARM_DESC(memory_idle_ms_percentiles,
 		"Memory idle time percentiles in milliseconds");
-- 
2.9.4



             reply	other threads:[~2026-01-30  8:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30  8:56 lirongqing [this message]
2026-01-30 15:38 ` SeongJae Park
2026-01-30 15:43   ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260130085603.1814-1-lirongqing@baidu.com \
    --to=lirongqing@baidu.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox