From: "D. Wythe" <alibuda@linux.alibaba.com >
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "D. Wythe" <alibuda@linux.alibaba.com>,
Leon Romanovsky <leon@kernel.org>,
Uladzislau Rezki <urezki@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Dust Li <dust.li@linux.alibaba.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sidraya Jayagond <sidraya@linux.ibm.com>,
Wenjia Zhang <wenjia@linux.ibm.com>,
Mahanta Jambigi <mjambigi@linux.ibm.com>,
Simon Horman <horms@kernel.org>,
Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, oliver.yang@linux.alibaba.com
Subject: Re: [PATCH net-next 2/3] mm: vmalloc: export find_vm_area()
Date: Fri, 30 Jan 2026 16:51:31 +0800 [thread overview]
Message-ID: <20260130085131.GA122673@j66a10360.sqa.eu95> (raw)
In-Reply-To: <20260129132058.GC2307128@ziepe.ca>
On Thu, Jan 29, 2026 at 09:20:58AM -0400, Jason Gunthorpe wrote:
> On Thu, Jan 29, 2026 at 07:36:09PM +0800, D. Wythe wrote:
>
> > > From there you can check the resulting scatterlist and compute the
> > > page_size to pass to ib_map_mr_sg().
>
> I should clarify this is done after DMA mapping the scatterlist. dma
> mapping can improve the page size.
>
> And maybe the core code should be helping compute the MR's target page
> size for a scatterlist.. We already have code to do this in umem, and
> it is a pretty bit tricky considering the IOVA related rules.
>
Hi Jason,
After a deep dive into ib_umem_find_best_pgsz(), I have to say it is
much more subtle than it first appears. The IOVA-to-PA relative offset
rules, in particular, make it quite easy to get wrong.
While SMC could duplicate this logic, it is certainly not ideal for
maintenance. Are there any plans to refactor this into a generic RDMA
core helper—for instance, one that can determine the best page size
directly from an sg_table or scatterlist?
Best regards,
D. Wythe
next prev parent reply other threads:[~2026-01-30 8:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 8:23 [PATCH net-next 0/3] net/smc: buffer allocation and registration improvements D. Wythe
2026-01-23 8:23 ` [PATCH net-next 1/3] net/smc: cap allocation order for SMC-R physically contiguous buffers D. Wythe
2026-01-23 10:54 ` Alexandra Winter
2026-01-24 9:22 ` D. Wythe
2026-01-23 8:23 ` [PATCH net-next 2/3] mm: vmalloc: export find_vm_area() D. Wythe
2026-01-23 14:44 ` Christoph Hellwig
2026-01-23 18:55 ` Uladzislau Rezki
2026-01-24 9:35 ` D. Wythe
2026-01-24 10:48 ` Uladzislau Rezki
2026-01-24 14:57 ` D. Wythe
2026-01-26 10:28 ` Uladzislau Rezki
2026-01-26 12:02 ` D. Wythe
2026-01-26 16:45 ` Uladzislau Rezki
2026-01-27 13:34 ` Leon Romanovsky
2026-01-28 3:45 ` D. Wythe
2026-01-28 11:13 ` Leon Romanovsky
2026-01-28 12:44 ` D. Wythe
2026-01-28 13:49 ` Leon Romanovsky
2026-01-29 11:03 ` D. Wythe
2026-01-29 12:22 ` Leon Romanovsky
2026-01-29 14:04 ` D. Wythe
2026-01-28 18:06 ` Jason Gunthorpe
2026-01-29 11:36 ` D. Wythe
2026-01-29 13:20 ` Jason Gunthorpe
2026-01-30 8:51 ` D. Wythe [this message]
2026-01-30 15:16 ` Jason Gunthorpe
2026-02-03 9:14 ` D. Wythe
2026-01-23 8:23 ` [PATCH net-next 3/3] net/smc: optimize MTTE consumption for SMC-R buffers D. Wythe
2026-01-23 14:52 ` Christoph Hellwig
2026-01-24 9:25 ` D. Wythe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260130085131.GA122673@j66a10360.sqa.eu95 \
--to=alibuda@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=horms@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjambigi@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=oliver.yang@linux.alibaba.com \
--cc=pabeni@redhat.com \
--cc=sidraya@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=urezki@gmail.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox