From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB917D25B49 for ; Wed, 28 Jan 2026 12:13:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E681B6B0092; Wed, 28 Jan 2026 07:13:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF4D26B008A; Wed, 28 Jan 2026 07:13:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6ABE6B0093; Wed, 28 Jan 2026 07:13:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB71B6B0088 for ; Wed, 28 Jan 2026 07:13:18 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 67EDD1A0624 for ; Wed, 28 Jan 2026 12:13:18 +0000 (UTC) X-FDA: 84381262476.01.894B4BE Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf13.hostedemail.com (Postfix) with ESMTP id BCC7A20005; Wed, 28 Jan 2026 12:13:15 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2025-q2 header.b="gTRY/WK5"; spf=pass (imf13.hostedemail.com: domain of "prvs=048834cd31=clm@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=048834cd31=clm@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1769602396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sd3tTNC9Qi1NraZ3FKZVjxKypYrlKrXHxdzsRn97YZE=; b=VQClwoJq9Y9eeeiP18GRqZIrQxqaNtcjQ0iDS7MbMvu9PdLXXibW6DC77mplXQoudF3kmD p2UdMsYp4n1A94HJmnegIK3ull9SHRG+xNzb+QDcnHL3stnWATaYfCMScJxZ2XQsFyZXJH A8wmTwns+jmPBLvP/jOXTigotkoXp4w= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2025-q2 header.b="gTRY/WK5"; spf=pass (imf13.hostedemail.com: domain of "prvs=048834cd31=clm@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=048834cd31=clm@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1769602396; a=rsa-sha256; cv=none; b=WlAQ9SV6Q7lbYbct+bZpwZB5ceUpAAo/K+vSLYWzwF//7m/jroMSWOEW5MSrBbIduJaf5h hNddYQfqgkl6eAwFlWTXW63Wg1mtUcOnRIIN0zmnwB3Siw6/QfxZIIpin3bOR1BheY90M3 bt/l45pHYSKpY8ZrlxSnh7Ke+0iNfOo= Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60SB138M1478460; Wed, 28 Jan 2026 04:12:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=s2048-2025-q2; bh=Sd3tTNC9Qi1NraZ3FKZVjxKypYrlKrXHxdzsRn97YZE=; b=gTRY/WK5dlMJ +w33bnXlRn1cCiq77T2CcMcXQkZLDeCgVL96iSn62FmkkrRxzBM9MIvA0/cb+Yqp 7K2voFCBRv+61xwztZqJKWxwspJ55PsOpC1EDOp9KTPbF6BIJWuk9ijNdT5ye3hN 2qFlu8Baf7zOiO2sS+AFcRFjCj8EIQBI+FWjL8w8MnzADaoEJNxQSdivlV6UW3he /wb0Y/R32ZcnznUNp/NThA2xnL9bV+ILuQu5yUUX8YQKP21FSmcApEMpZ5O3AuC3 /zWNiD+9HEYCHz+k7PzzpBd2lBlTxy8vvfv8sVuLDoGyHUQax4GHXHh1oNeRoIln Y1F/zIHK8w== Received: from mail.thefacebook.com ([163.114.134.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 4bycg226fm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 28 Jan 2026 04:12:23 -0800 (PST) Received: from devbig003.atn7.facebook.com (2620:10d:c085:108::150d) by mail.thefacebook.com (2620:10d:c08b:78::c78f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.35; Wed, 28 Jan 2026 12:12:18 +0000 From: Chris Mason To: Lorenzo Stoakes CC: Andrew Morton , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , , "H . Peter Anvin" , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Christian Koenig , Huang Rui , Matthew Auld , Matthew Brost , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Theodore Ts'o , Andreas Dilger , Muchun Song , Oscar Salvador , David Hildenbrand , Konstantin Komarov , Mike Marshall , Martin Brandenburg , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Matthew Wilcox , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Zi Yan , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Jann Horn , Pedro Falcato , David Howells , Paul Moore , James Morris , "Serge E . Hallyn" , Yury Norov , Rasmus Villemoes , , , , , , , , , , , , , , , , , Jason Gunthorpe Subject: Re: [PATCH v2 07/13] mm: update secretmem to use VMA flags on mmap_prepare Date: Wed, 28 Jan 2026 04:08:36 -0800 Message-ID: <20260128121200.283932-1-clm@meta.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [2620:10d:c085:108::150d] X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDA5OCBTYWx0ZWRfX/YMdvd0IEW+M mfJ/bYR9k4eRvDbs9QGzO+ygu2VSotJCKMMxUusrpYkrvYdQaFJRWVvBv2EkD12mCpCYEvw+XB/ DwyN2M8BBbTeyqqZ9/i9fDyEPE0MOIwU1pNj8r3a1/SGXN38+xZGlcMtDVhwJA1iofmGT+NTjsa 3wJFzmew6yuj81cYLEWiubhhxDZMBD6hVVMuqCOVg+bB7Gz9bEYCH56KvIcfJ13/7NnDlwWy1ay rut+pW91VzKqtLFjeZDFQXQuymj3+pWlazUmuuQXtfS+yB5rh8eIrZb/ZGDSDilJLhwKOSnwEsm tXIPQzyp+XE21UBIWU7JysVYMwhm9BUIbA4gV+4NNGJrteyEtklAhziLQl5fV0j0MzIV6sri7hz h9QDQw7JEBl4y5dfKeMuesm0LqUNBE+g04KLVmq1Y9FiJcFdRQVCoCh0B4S6SthUPRAGT0RWyAc Vh/HaT4eUcQ+KnB1bbQ== X-Proofpoint-GUID: 6cECoo2vZpz-_Y4sX-WfJbWu0BG9k_53 X-Authority-Analysis: v=2.4 cv=Q63fIo2a c=1 sm=1 tr=0 ts=6979fd27 cx=c_pps a=CB4LiSf2rd0gKozIdrpkBw==:117 a=CB4LiSf2rd0gKozIdrpkBw==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=VZ3cX_PGfQEInpbj4y4A:9 X-Proofpoint-ORIG-GUID: 6cECoo2vZpz-_Y4sX-WfJbWu0BG9k_53 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_02,2026-01-28_01,2025-10-01_01 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BCC7A20005 X-Stat-Signature: 6qo9fgbit497e81u79ehf5bub1m3ons7 X-Rspam-User: X-HE-Tag: 1769602395-215775 X-HE-Meta: U2FsdGVkX19PU9GL/iXM8jw0+ZUEp1ZASIZ6e5vIqvAEybifFX86kJS4UkvyhnefUqKAbualAskTwuFRIyIxnYn6F6PN53plrklns3erx1I0+v0gKRz9lJEwOEamOMy9wRZL+2vZTPPTWRXplaI3DYc1OL/rdKgBcLmwaaRBcBRFg8s7kE4eaDZqjzIRnUUiPPfsZS4qbWFGVlXMYxrq0f7UbJlcJPfApGVPRKa/2oL4VIJE2SbieWD+fgzaAh4s8NX3adhT63VVUxT8er7R27SeHWElCzXKsZm/tOeOfdYuqpLAE50ZlmMDsf/yX3Sqz0sd4878q1lAUUDZN8W8CAQ+AZrz8DmwbzSb6zHJChRyfxq2/sANPu1QN5YnH7SRVRlMFO16tH/G4Zsi3Ixhmdufy47XuPj+vOXYC+pdV4SqvLKZmr8fjmsMRubDUP5IC0O94dfeyLkaS/sD4lZFW67UBxMrYEK5sQm9N0yUVkuDVox1AihI0RkqbBKmeLHz1XVyd6Bwh20j+mwq7n2sHEgy21Jv6IpGxMHepZVwZAqozZkPxS2ymH6TJhYc4uVKL1BC3FPH4RYrYzGayFqHPtKOMy1JxbWNAjFTNgDpkgYOhFVkK5+0/Nar7IzLSTvRRSiI7BLQtjKzdWO+Dpfh1/poTdw39rWcRFhCRoMtdI30PJa49B0EvC7RsAUu0Z/UUrojt57dUMyNYX7ovo7PrH1VGyu51PJWpc6N5O4HZsZQndG6AA7HPFXAFoCxbxqwTDjPHRHfMdNM1oXwU/nFvTsd31XMsnMrWbCXbadzPqVT2Z+FyRjXJOTuB8HfQ19wbQWTCoilsShwrtS8T009xzN8vU/gHJVYv/+6i6sC4OpkVa9YTQDhuzEtTIccoMKMe1QkgVORmebXJ4oud861EoNQGAqllUqmstqSzv82tqUumpiF7TzY+3GgbCO2wXPvA+8vCvrBenJDuB0It8B wthFfvQc 7fHRQlXIdbjp/qEHYBsFq68SBhEGb2YMAtK5iAsgRwlZc/JHb1IGFn/HaALslnvdGVmSPrJWJ1lfss2BzQ/ICgW3hFCtH7jDPcz+PGdprAOtJIR3IFnLFrCyguOTXIkQb55C9GYe03Lsq7IT2iWd+xL6N/MOKHf8eu31SIduaOlo5Jp1GPi+HbwDSWvsAOH+4smG3s3E4MDXxDP2rIRpXNCSwwV7oiY6E7bRUj9ZxLxAfa3NIJB01tA5gvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Lorenzo Stoakes wrote: > This patch updates secretmem to use the new vma_flags_t type which will > soon supersede vm_flags_t altogether. > > In order to make this change we also have to update mlock_future_ok(), we > replace the vm_flags_t parameter with a simple boolean is_vma_locked one, > which also simplifies the invocation here. > > This is laying the groundwork for eliminating the vm_flags_t in > vm_area_desc and more broadly throughout the kernel. > Hi everyone, Running mm-new through AI review flagged this one: > diff --git a/mm/mmap.c b/mm/mmap.c > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -225,12 +225,12 @@ static inline unsigned long round_hint_to_min(unsigned long hint) > return hint; > } > > -bool mlock_future_ok(const struct mm_struct *mm, vm_flags_t vm_flags, > - unsigned long bytes) > +bool mlock_future_ok(const struct mm_struct *mm, bool is_vma_locked, > + unsigned long bytes) > { > unsigned long locked_pages, limit_pages; > > - if (!(vm_flags & VM_LOCKED) || capable(CAP_IPC_LOCK)) > + if (!is_vma_locked || capable(CAP_IPC_LOCK)) > return true; [ ... ] > @@ -416,7 +416,7 @@ > if (!can_do_mlock()) > return -EPERM; > > - if (!mlock_future_ok(mm, vm_flags, len)) > + if (!mlock_future_ok(mm, vm_flags & VM_LOCKED, len)) > return -EAGAIN; This looks correct - do_mmap() now extracts the VM_LOCKED bit from vm_flags and passes that to mlock_future_ok(). However, it appears check_brk_limits() was not updated when mlock_future_ok() changed its signature. The function at mm/mmap.c:111 still passes the raw def_flags value: return mlock_future_ok(current->mm, current->mm->def_flags, len) ? 0 : -EAGAIN; When def_flags has any bit set, this converts to true, incorrectly triggering mlock limit checks even when VM_LOCKED is not set. Should this be passing (current->mm->def_flags & VM_LOCKED) instead? [ ... ] Additionally, the test stub at tools/testing/vma/vma_internal.h:1627 still has the old signature (mm, vm_flags_t vm_flags, bytes) while the production code now uses (mm, bool is_vma_locked, bytes). This could cause compilation issues or mask bugs in the test suite.