linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Jann Horn <jannh@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-rt-devel@lists.linux.dev,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Waiman Long <longman@redhat.com>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v4 04/10] mm/vma: add+use vma lockdep acquire/release defines
Date: Wed, 28 Jan 2026 12:37:49 +0100	[thread overview]
Message-ID: <20260128113749.osNjwNqo@linutronix.de> (raw)
In-Reply-To: <fdae72441949ecf3b4a0ed3510da803e881bb153.1769198904.git.lorenzo.stoakes@oracle.com>

On 2026-01-23 20:12:14 [+0000], Lorenzo Stoakes wrote:
> --- a/include/linux/mmap_lock.h
> +++ b/include/linux/mmap_lock.h
> @@ -78,6 +78,37 @@ static inline void mmap_assert_write_locked(const struct mm_struct *mm)
> +/* Only meaningful if CONFIG_LOCK_STAT is defined. */
> +#define __vma_lockdep_stat_mark_acquired(vma) \
> +	lock_acquired(&vma->vmlock_dep_map, _RET_IP_)
> +

After going through the remaining series, I don't think I found a
matching lock_contended(). So perf/ tracing just give you a few
lock-acquired events. Wouldn't it make sense to also some
lock_contended() events where the caller had to wait before it could
acquire the lock?

Sebastian


  parent reply	other threads:[~2026-01-28 11:37 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23 20:12 [PATCH v4 00/10] mm: add and use vma_assert_stabilised() helper Lorenzo Stoakes
2026-01-23 20:12 ` [PATCH v4 01/10] mm/vma: rename VMA_LOCK_OFFSET to VM_REFCNT_EXCLUDE_READERS_FLAG Lorenzo Stoakes
2026-01-30 16:50   ` Liam R. Howlett
2026-01-23 20:12 ` [PATCH v4 02/10] mm/vma: document possible vma->vm_refcnt values and reference comment Lorenzo Stoakes
2026-01-26  5:15   ` Suren Baghdasaryan
2026-01-26  9:33     ` Lorenzo Stoakes
2026-01-26  9:40   ` Vlastimil Babka
2026-01-30 17:06   ` Liam R. Howlett
2026-01-23 20:12 ` [PATCH v4 03/10] mm/vma: rename is_vma_write_only(), separate out shared refcount put Lorenzo Stoakes
2026-01-26  5:36   ` Suren Baghdasaryan
2026-01-26  9:45     ` Lorenzo Stoakes
2026-01-26 10:12   ` Vlastimil Babka
2026-01-23 20:12 ` [PATCH v4 04/10] mm/vma: add+use vma lockdep acquire/release defines Lorenzo Stoakes
2026-01-28 11:18   ` Sebastian Andrzej Siewior
2026-01-28 11:31     ` Lorenzo Stoakes
2026-01-28 11:37   ` Sebastian Andrzej Siewior [this message]
2026-01-28 11:48     ` Lorenzo Stoakes
2026-01-29 21:30       ` Suren Baghdasaryan
2026-01-23 20:12 ` [PATCH v4 05/10] mm/vma: de-duplicate __vma_enter_locked() error path Lorenzo Stoakes
2026-01-23 20:12 ` [PATCH v4 06/10] mm/vma: clean up __vma_enter/exit_locked() Lorenzo Stoakes
2026-01-26  5:47   ` Suren Baghdasaryan
2026-01-26  9:45     ` Lorenzo Stoakes
2026-01-26 10:25   ` Vlastimil Babka
2026-01-23 20:12 ` [PATCH v4 07/10] mm/vma: introduce helper struct + thread through exclusive lock fns Lorenzo Stoakes
2026-01-26 11:16   ` Vlastimil Babka
2026-01-26 16:09     ` Lorenzo Stoakes
2026-01-26 19:38       ` Andrew Morton
2026-01-26 18:15     ` Suren Baghdasaryan
2026-01-23 20:12 ` [PATCH v4 08/10] mm/vma: improve and document __is_vma_write_locked() Lorenzo Stoakes
2026-01-26 11:30   ` Vlastimil Babka
2026-01-26 16:29     ` Lorenzo Stoakes
2026-01-26 19:21       ` Suren Baghdasaryan
2026-01-28 11:51         ` Lorenzo Stoakes
2026-01-28 13:01           ` Vlastimil Babka
2026-01-28 18:52             ` Suren Baghdasaryan
2026-01-26 16:30   ` Lorenzo Stoakes
2026-01-23 20:12 ` [PATCH v4 09/10] mm/vma: update vma_assert_locked() to use lockdep Lorenzo Stoakes
2026-01-26 13:42   ` Vlastimil Babka
2026-01-26 16:44     ` Lorenzo Stoakes
2026-01-26 17:16       ` Lorenzo Stoakes
2026-01-26 17:37   ` Lorenzo Stoakes
2026-01-23 20:12 ` [PATCH v4 10/10] mm/vma: add and use vma_assert_stabilised() Lorenzo Stoakes
2026-01-23 22:48 ` [PATCH v4 00/10] mm: add and use vma_assert_stabilised() helper Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128113749.osNjwNqo@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=boqun.feng@gmail.com \
    --cc=clrkwllms@kernel.org \
    --cc=david@kernel.org \
    --cc=jannh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=longman@redhat.com \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox