linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>,
	Mike Rapoport <rppt@kernel.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 0/2] liveupdate: fixes in error handling
Date: Tue, 27 Jan 2026 00:02:51 +0100	[thread overview]
Message-ID: <20260126230302.2936817-1-pratyush@kernel.org> (raw)

From: "Pratyush Yadav (Google)" <pratyush@kernel.org>

Hi Andrew,

This series contains some fixes in LUO's error handling paths.

The first patch deals with failed freeze() attempts. The cleanup path
calls unfreeze, and that clears some data needed by later unpreserve
calls.

The second patch is a bit more involved. It deals with failed retrieve()
attempts. To do so properly, it reworks some of the error handling logic
in luo_file core.

Both these fixes are "theoretical" -- in the sense that I have not been
able to reproduce either of them in normal operation. The only supported
file type right now is memfd, and there is nothing userspace can do
right now to make it fail its retrieve or freeze. I need to make the
retrieve or freeze fail by artificially injecting errors. The injected
errors trigger a use-after-free and a double-free.

That said, once more complex file handlers are added or memfd
preservation is used in ways not currently expected or covered by the
tests, we will be able to see them on real systems.

Regards,
Pratyush Yadav

Pratyush Yadav (Google) (2):
  liveupdate: luo_file: do not clear serialized_data on unfreeze
  liveupdate: luo_file: remember retrieve() status

 include/linux/liveupdate.h   |  7 ++++--
 kernel/liveupdate/luo_file.c | 43 +++++++++++++++++++++---------------
 mm/memfd_luo.c               |  7 +++++-
 3 files changed, 36 insertions(+), 21 deletions(-)


base-commit: 2e833046d66a40f9ad3de2948e6ecd791939fa59
-- 
2.52.0.457.g6b5491de43-goog



             reply	other threads:[~2026-01-26 23:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 23:02 Pratyush Yadav [this message]
2026-01-26 23:02 ` [PATCH 1/2] liveupdate: luo_file: do not clear serialized_data on unfreeze Pratyush Yadav
2026-01-28 11:19   ` Mike Rapoport
2026-01-30 18:56     ` Pratyush Yadav
2026-01-30 19:50       ` Andrew Morton
2026-02-02 11:14         ` Pratyush Yadav
2026-01-26 23:02 ` [PATCH 2/2] liveupdate: luo_file: remember retrieve() status Pratyush Yadav
2026-01-28 11:37   ` Mike Rapoport
2026-02-10 13:30     ` Pratyush Yadav
2026-01-31 15:31   ` Pasha Tatashin
2026-02-10 13:31     ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260126230302.2936817-1-pratyush@kernel.org \
    --to=pratyush@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox