From: Andrew Morton <akpm@linux-foundation.org>
To: Andreas Larsson <andreas@gaisler.com>
Cc: chengkaitao <pilgrimtao@gmail.com>,
davem@davemloft.net, david@kernel.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, kevin.brodsky@arm.com,
dave.hansen@linux.intel.com, ziy@nvidia.com,
chengkaitao@kylinos.cn, willy@infradead.org,
zhengqi.arch@bytedance.com, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v5 1/2] sparc: Use vmemmap_populate_hugepages for vmemmap_populate
Date: Mon, 26 Jan 2026 11:09:36 -0800 [thread overview]
Message-ID: <20260126110936.4e47e1b0820198e342339038@linux-foundation.org> (raw)
In-Reply-To: <aaf30e1e-be55-4212-b096-69f71bafd406@gaisler.com>
On Mon, 26 Jan 2026 15:50:34 +0100 Andreas Larsson <andreas@gaisler.com> wrote:
> On 2026-01-11 08:44, chengkaitao wrote:
> > From: Chengkaitao <chengkaitao@kylinos.cn>
> >
> > 1. In the SPARC architecture, reimplemented vmemmap_populate using
> > vmemmap_populate_hugepages.
> > 2. Allow the SPARC arch to fallback to vmemmap_populate_basepages(),
> > when vmemmap_alloc_block returns NULL.
>
> This patch seems to potentially make more functional changes than what
> the descriptions gives impression of.
>
> Given the amount of changes this seems to introduce, more on that below,
> I'd like to see more description on the changes and why they can be done
> than this.
>
> Nit: use active language, "reimplement", not "reimplemented".
Thanks, I'll drop the v5 version of this patchset.
next prev parent reply other threads:[~2026-01-26 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 7:44 [PATCH v5 0/2] Generalize vmemmap_populate_hugepages to sparc chengkaitao
2026-01-11 7:44 ` [PATCH v5 1/2] sparc: Use vmemmap_populate_hugepages for vmemmap_populate chengkaitao
2026-01-26 14:50 ` Andreas Larsson
2026-01-26 19:09 ` Andrew Morton [this message]
2026-01-28 3:25 ` Chengkaitao
2026-02-15 13:04 ` Chengkaitao
2026-01-11 7:44 ` [PATCH v5 2/2] mm: Convert vmemmap_p?d_populate() to static functions chengkaitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260126110936.4e47e1b0820198e342339038@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=andreas@gaisler.com \
--cc=chengkaitao@kylinos.cn \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=kevin.brodsky@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=pilgrimtao@gmail.com \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox