* [PATCH] kho: fix doc for kho_restore_pages()
@ 2026-01-23 19:05 Tycho Andersen
2026-01-25 11:50 ` Mike Rapoport
2026-01-26 12:48 ` Pratyush Yadav
0 siblings, 2 replies; 3+ messages in thread
From: Tycho Andersen @ 2026-01-23 19:05 UTC (permalink / raw)
To: Mike Rapoport, Alexander Graf, Pasha Tatashin, Pratyush Yadav
Cc: kexec, linux-mm, linux-kernel
From: "Tycho Andersen (AMD)" <tycho@kernel.org>
This function returns NULL if kho_restore_page() returns NULL, which
happens in a couple of corner cases. It never returns an error code.
Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>
---
kernel/liveupdate/kexec_handover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
index d4482b6e3cae..4c38ea7987c8 100644
--- a/kernel/liveupdate/kexec_handover.c
+++ b/kernel/liveupdate/kexec_handover.c
@@ -281,7 +281,7 @@ EXPORT_SYMBOL_GPL(kho_restore_folio);
* Restore a contiguous list of order 0 pages that was preserved with
* kho_preserve_pages().
*
- * Return: 0 on success, error code on failure
+ * Return: the first page on success, NULL on failure.
*/
struct page *kho_restore_pages(phys_addr_t phys, unsigned int nr_pages)
{
base-commit: c072629f05d7bca1148ab17690d7922a31423984
--
2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kho: fix doc for kho_restore_pages()
2026-01-23 19:05 [PATCH] kho: fix doc for kho_restore_pages() Tycho Andersen
@ 2026-01-25 11:50 ` Mike Rapoport
2026-01-26 12:48 ` Pratyush Yadav
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2026-01-25 11:50 UTC (permalink / raw)
To: Tycho Andersen
Cc: Alexander Graf, Pasha Tatashin, Pratyush Yadav, kexec, linux-mm,
linux-kernel
On Fri, Jan 23, 2026 at 12:05:06PM -0700, Tycho Andersen wrote:
> From: "Tycho Andersen (AMD)" <tycho@kernel.org>
>
> This function returns NULL if kho_restore_page() returns NULL, which
> happens in a couple of corner cases. It never returns an error code.
>
> Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> kernel/liveupdate/kexec_handover.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index d4482b6e3cae..4c38ea7987c8 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -281,7 +281,7 @@ EXPORT_SYMBOL_GPL(kho_restore_folio);
> * Restore a contiguous list of order 0 pages that was preserved with
> * kho_preserve_pages().
> *
> - * Return: 0 on success, error code on failure
> + * Return: the first page on success, NULL on failure.
> */
> struct page *kho_restore_pages(phys_addr_t phys, unsigned int nr_pages)
> {
>
> base-commit: c072629f05d7bca1148ab17690d7922a31423984
> --
> 2.52.0
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kho: fix doc for kho_restore_pages()
2026-01-23 19:05 [PATCH] kho: fix doc for kho_restore_pages() Tycho Andersen
2026-01-25 11:50 ` Mike Rapoport
@ 2026-01-26 12:48 ` Pratyush Yadav
1 sibling, 0 replies; 3+ messages in thread
From: Pratyush Yadav @ 2026-01-26 12:48 UTC (permalink / raw)
To: Tycho Andersen
Cc: Mike Rapoport, Alexander Graf, Pasha Tatashin, Pratyush Yadav,
kexec, linux-mm, linux-kernel
On Fri, Jan 23 2026, Tycho Andersen wrote:
> From: "Tycho Andersen (AMD)" <tycho@kernel.org>
>
> This function returns NULL if kho_restore_page() returns NULL, which
> happens in a couple of corner cases. It never returns an error code.
>
> Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>
Thanks.
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
[...]
--
Regards,
Pratyush Yadav
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-26 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-23 19:05 [PATCH] kho: fix doc for kho_restore_pages() Tycho Andersen
2026-01-25 11:50 ` Mike Rapoport
2026-01-26 12:48 ` Pratyush Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox