From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Gregory Price <gourry@gourry.net>
Cc: "David Hildenbrand (Red Hat)" <david@kernel.org>,
<linux-mm@kvack.org>, <linux-cxl@vger.kernel.org>,
<nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<virtualization@lists.linux.dev>, <kernel-team@meta.com>,
<dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
<dave.jiang@intel.com>, <mst@redhat.com>, <jasowang@redhat.com>,
<xuanzhuo@linux.alibaba.com>, <eperezma@redhat.com>,
<osalvador@suse.de>, <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/8] mm/memory_hotplug: add APIs for explicit online type control
Date: Fri, 23 Jan 2026 18:25:26 +0000 [thread overview]
Message-ID: <20260123182526.00005ee8@huawei.com> (raw)
In-Reply-To: <aXLCAtwMkSMH3DNj@gourry-fedora-PF4VCD3F>
On Thu, 22 Jan 2026 19:34:10 -0500
Gregory Price <gourry@gourry.net> wrote:
> On Thu, Jan 22, 2026 at 11:41:24PM +0100, David Hildenbrand (Red Hat) wrote:
> >
> > Right, but I don't want any other OOT kernel module to be able to make use
> > of add_memory_driver_managed() to do arbitrary things, because we don't know
> > if it's really user space setting the policy for that memory then.
> >
>
> Ah, this was lost on me.
>
> > So either restrict add_memory_driver_managed() to kmem+virtio_mem
> > completely, or add another variant that will be kmem-only (or however that
> > dax/cxl module is called).
>
> unclear to me how to restrict a function to specific drivers, but i can
> add add_and_online_memory_driver_managed() trivially so no big issue.
Is EXPORT_SYMBOL_GPL_FOR_MODULE() enough?
>
> You'd be ok with with this?
>
> add_and_online_memory_driver_managed(..., online_type) {
> ... existing add_memory_driver_managed() code ...
> }
>
> add_memory_driver_managed(...) {
> add_and_online_memory_driver_managed(..., mhp_get_default_policy());
> }
>
> ~Gregory
>
next prev parent reply other threads:[~2026-01-23 18:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 8:51 Subject: [PATCH 0/8] dax/kmem: add runtime hotplug state control Gregory Price
2026-01-14 8:51 ` [PATCH 1/8] mm/memory_hotplug: pass online_type to online_memory_block() via arg Gregory Price
2026-01-14 9:46 ` David Hildenbrand (Red Hat)
2026-01-14 8:51 ` [PATCH 2/8] mm/memory_hotplug: extract __add_memory_resource() and __offline_memory() Gregory Price
2026-01-14 10:14 ` David Hildenbrand (Red Hat)
2026-01-14 17:11 ` Gregory Price
2026-01-14 8:51 ` [PATCH 3/8] mm/memory_hotplug: add APIs for explicit online type control Gregory Price
2026-01-14 10:21 ` David Hildenbrand (Red Hat)
2026-01-14 17:27 ` Gregory Price
2026-01-22 22:41 ` David Hildenbrand (Red Hat)
2026-01-23 0:34 ` Gregory Price
2026-01-23 18:25 ` Jonathan Cameron [this message]
2026-01-23 19:12 ` Gregory Price
2026-01-27 23:06 ` David Hildenbrand (Red Hat)
2026-01-27 23:31 ` Gregory Price
2026-01-14 8:51 ` [PATCH 4/8] mm/memory_hotplug: return online type from add_memory_driver_managed() Gregory Price
2026-01-14 10:49 ` David Hildenbrand (Red Hat)
2026-01-14 17:28 ` Gregory Price
2026-01-14 8:51 ` [PATCH 5/8] dax/kmem: extract hotplug/hotremove helper functions Gregory Price
2026-01-14 8:51 ` [PATCH 6/8] dax/kmem: add online/offline " Gregory Price
2026-01-14 8:51 ` [PATCH 7/8] dax/kmem: add sysfs interface for runtime hotplug state control Gregory Price
2026-01-14 10:55 ` David Hildenbrand (Red Hat)
2026-01-14 17:32 ` Gregory Price
2026-01-14 18:11 ` Gregory Price
2026-01-22 22:49 ` David Hildenbrand (Red Hat)
2026-01-23 0:43 ` Gregory Price
2026-01-27 23:06 ` David Hildenbrand (Red Hat)
2026-01-14 8:52 ` [PATCH 8/8] dax/kmem: add memory notifier to block external state changes Gregory Price
2026-01-14 9:44 ` David Hildenbrand (Red Hat)
2026-01-14 17:07 ` Gregory Price
2026-01-22 22:44 ` David Hildenbrand (Red Hat)
2026-01-14 17:36 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123182526.00005ee8@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@kernel.org \
--cc=eperezma@redhat.com \
--cc=gourry@gourry.net \
--cc=jasowang@redhat.com \
--cc=kernel-team@meta.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=nvdimm@lists.linux.dev \
--cc=osalvador@suse.de \
--cc=virtualization@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox