From: Andrew Morton <akpm@linux-foundation.org>
To: "Garg, Shivank" <shivankg@amd.com>
Cc: Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
David Hildenbrand <david@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Barry Song <baohua@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@gmail.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: Re: [PATCH V3 2/5] mm/khugepaged: count small VMAs towards scan limit
Date: Fri, 23 Jan 2026 07:37:38 -0800 [thread overview]
Message-ID: <20260123073738.76b9e59521270e45eae70f88@linux-foundation.org> (raw)
In-Reply-To: <836669ac-473f-4c30-a368-c05bfa86c306@amd.com>
On Fri, 23 Jan 2026 16:12:07 +0530 "Garg, Shivank" <shivankg@amd.com> wrote:
> >> I was worrying about a case that doesn't actually happen.
> >>
> > You're right, thp_vma_allowable_order() is taking care of this, making
> > hend <= hstart check redundant.
> >
> > Thank you for catching this.
> >
> > I'll drop this change and send revision keeping only the unsigned int type
> > change for 'progress'.
> >
>
> Hi Andrew,
>
> Please drop this patch.
thud.
> As Dev and Lance noted that the hend <= hstart handling check is redundant.
>
> The 'progress' variable to unsigned int is not critical either.
OK.
Were you thinking of adopting Dev's suggestion?
https://lkml.kernel.org/r/6486c6dd-2702-4a4d-9662-09639532ce6f@arm.com.
If so, let's defer until the next cycle, please. Now is the time to be
focusing on stabilization, test, finishing up review, etc.
next prev parent reply other threads:[~2026-01-23 15:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 19:22 [PATCH V3 0/5] mm/khugepaged: cleanups and scan limit fix Shivank Garg
2026-01-18 19:22 ` [PATCH V3 1/5] mm/khugepaged: remove unnecessary goto 'skip' label Shivank Garg
2026-01-22 7:04 ` Dev Jain
2026-01-22 11:56 ` Nico Pache
2026-01-18 19:22 ` [PATCH V3 2/5] mm/khugepaged: count small VMAs towards scan limit Shivank Garg
2026-01-22 7:32 ` Dev Jain
2026-01-22 8:44 ` Lance Yang
2026-01-22 12:26 ` Garg, Shivank
2026-01-23 10:42 ` Garg, Shivank
2026-01-23 15:37 ` Andrew Morton [this message]
2026-01-23 20:07 ` Garg, Shivank
2026-01-18 19:22 ` [PATCH V3 3/5] mm/khugepaged: change collapse_pte_mapped_thp() to return void Shivank Garg
2026-01-22 12:17 ` Nico Pache
2026-01-18 19:22 ` [PATCH V3 4/5] mm/khugepaged: use enum scan_result for result variables and return types Shivank Garg
2026-01-19 10:24 ` David Hildenbrand (Red Hat)
2026-01-22 9:19 ` Dev Jain
2026-01-22 12:14 ` Nico Pache
2026-01-18 19:23 ` [PATCH V3 5/5] mm/khugepaged: make khugepaged_collapse_control static Shivank Garg
2026-01-22 9:28 ` Dev Jain
2026-01-23 7:48 ` Dev Jain
2026-01-23 9:33 ` Garg, Shivank
2026-01-24 1:21 ` Andrew Morton
2026-01-24 3:02 ` Andrew Morton
2026-01-24 9:02 ` Lorenzo Stoakes
2026-01-24 9:01 ` Lorenzo Stoakes
2026-01-24 10:54 ` Dev Jain
2026-01-24 11:40 ` Lorenzo Stoakes
2026-01-24 11:56 ` Dev Jain
2026-01-24 18:37 ` Garg, Shivank
2026-01-18 20:34 ` [PATCH V3 0/5] mm/khugepaged: cleanups and scan limit fix Andrew Morton
2026-01-19 0:17 ` Zi Yan
2026-01-19 5:50 ` Garg, Shivank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123073738.76b9e59521270e45eae70f88@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shivankg@amd.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox