From: Andrew Morton <akpm@linux-foundation.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
oe-kbuild@lists.linux.dev, lkp@intel.com,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
Jason Gunthorpe <jgg@nvidia.com>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>
Subject: Re: kernel/liveupdate/kexec_handover.c:994 kho_preserve_vmalloc() warn: missing error code 'err'
Date: Thu, 22 Jan 2026 10:42:38 -0800 [thread overview]
Message-ID: <20260122104238.54189a538153a0323453d61f@linux-foundation.org> (raw)
In-Reply-To: <CA+CK2bAyHHoUaT_4dTNK6AH2oyMMhs2sNhuW97hV4yRw7ie9Tg@mail.gmail.com>
On Thu, 22 Jan 2026 13:14:49 -0500 Pasha Tatashin <pasha.tatashin@soleen.com> wrote:
> > --- a/kernel/liveupdate/kexec_handover.c~a
> > +++ a/kernel/liveupdate/kexec_handover.c
> > @@ -1011,8 +1011,10 @@ int kho_preserve_vmalloc(void *ptr, stru
> > chunk->phys[idx++] = phys;
> > if (idx == ARRAY_SIZE(chunk->phys)) {
> > chunk = new_vmalloc_chunk(chunk);
> > - if (!chunk)
> > + if (!chunk) {
> > + err = -ENOMEM;
> > goto err_free;
> > + }
>
> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Cool. I think I'll turn this into a 6.19 hotfix - it is a slight bug
and we don't want people to keep telling us about it.
prev parent reply other threads:[~2026-01-22 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 8:58 Dan Carpenter
2026-01-21 20:39 ` Andrew Morton
2026-01-22 9:49 ` Mike Rapoport
2026-01-22 10:30 ` Pratyush Yadav
2026-01-22 18:14 ` Pasha Tatashin
2026-01-22 18:42 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122104238.54189a538153a0323453d61f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.carpenter@linaro.org \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox