linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	maple-tree@lists.infradead.org, linux-kernel@vger.kernel.org,
	Suren Baghdasaryan <surenb@google.com>,
	Matthew Wilcox <willy@infradead.org>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Alice Ryhl <aliceryhl@google.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Christian Kujau <lists@nerdbynature.de>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: Re: [PATCH 16/28] maple_tree: Start using maple copy node for destination
Date: Fri, 16 Jan 2026 17:36:38 +0800	[thread overview]
Message-ID: <202601161750.eDtUQiJr-lkp@intel.com> (raw)
In-Reply-To: <20260115193647.1695937-17-Liam.Howlett@oracle.com>

Hi Liam,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on next-20260115]
[cannot apply to akpm-mm/mm-nonmm-unstable soc/for-next linus/master v6.19-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Liam-R-Howlett/maple_tree-Move-mas_spanning_rebalance-loop-to-function/20260116-034135
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20260115193647.1695937-17-Liam.Howlett%40oracle.com
patch subject: [PATCH 16/28] maple_tree: Start using maple copy node for destination
config: x86_64-randconfig-121-20260116 (https://download.01.org/0day-ci/archive/20260116/202601161750.eDtUQiJr-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260116/202601161750.eDtUQiJr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601161750.eDtUQiJr-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> lib/maple_tree.c:3355:37: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void [noderef] __rcu * @@     got struct maple_enode * @@
   lib/maple_tree.c:3355:37: sparse:     expected void [noderef] __rcu *
   lib/maple_tree.c:3355:37: sparse:     got struct maple_enode *
>> lib/maple_tree.c:3358:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct maple_enode const *entry @@     got void [noderef] __rcu * @@
   lib/maple_tree.c:3358:17: sparse:     expected struct maple_enode const *entry
   lib/maple_tree.c:3358:17: sparse:     got void [noderef] __rcu *
>> lib/maple_tree.c:3397:19: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct maple_enode *node @@     got void [noderef] __rcu * @@
   lib/maple_tree.c:3397:19: sparse:     expected struct maple_enode *node
   lib/maple_tree.c:3397:19: sparse:     got void [noderef] __rcu *
   lib/maple_tree.c:3139:29: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void [noderef] __rcu * @@     got struct maple_enode * @@
   lib/maple_tree.c:3139:29: sparse:     expected void [noderef] __rcu *
   lib/maple_tree.c:3139:29: sparse:     got struct maple_enode *
>> lib/maple_tree.c:2558:52: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected struct maple_enode *enode @@     got void [noderef] __rcu * @@
   lib/maple_tree.c:2558:52: sparse:     expected struct maple_enode *enode
   lib/maple_tree.c:2558:52: sparse:     got void [noderef] __rcu *
   lib/maple_tree.c:2803:29: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void [noderef] __rcu * @@     got void *content @@
   lib/maple_tree.c:2803:29: sparse:     expected void [noderef] __rcu *
   lib/maple_tree.c:2803:29: sparse:     got void *content
   lib/maple_tree.c:2806:23: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void [noderef] __rcu * @@     got void *entry @@
   lib/maple_tree.c:2806:23: sparse:     expected void [noderef] __rcu *
   lib/maple_tree.c:2806:23: sparse:     got void *entry
>> lib/maple_tree.c:2558:52: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected struct maple_enode *enode @@     got void [noderef] __rcu * @@
   lib/maple_tree.c:2558:52: sparse:     expected struct maple_enode *enode
   lib/maple_tree.c:2558:52: sparse:     got void [noderef] __rcu *
   lib/maple_tree.c:6899:30: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void [noderef] __rcu * @@     got struct maple_node * @@
   lib/maple_tree.c:6899:30: sparse:     expected void [noderef] __rcu *
   lib/maple_tree.c:6899:30: sparse:     got struct maple_node *
   lib/maple_tree.c:6899:30: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void [noderef] __rcu * @@     got struct maple_node * @@
   lib/maple_tree.c:6899:30: sparse:     expected void [noderef] __rcu *
   lib/maple_tree.c:6899:30: sparse:     got struct maple_node *

vim +3355 lib/maple_tree.c

  3317	
  3318	/*
  3319	 * spanning_ascend() - See if a spanning store operation has to keep walking up
  3320	 * the tree
  3321	 * @cp: The maple_copy node
  3322	 * @l_wr_mas: The left maple write state
  3323	 * @r_wr_mas: The right maple write state
  3324	 * @sib: the maple state of the sibling
  3325	 *
  3326	 * Returns: True if another iteration is necessary.
  3327	 */
  3328	static bool spanning_ascend(struct maple_copy *cp, struct ma_state *mas,
  3329				    struct ma_wr_state *l_wr_mas, struct ma_wr_state *r_wr_mas,
  3330				    struct ma_state *sib)
  3331	{
  3332		if (sib->end) {
  3333			if (sib->max < l_wr_mas->mas->min)
  3334				*l_wr_mas->mas = *sib;
  3335			else
  3336				*r_wr_mas->mas = *sib;
  3337		}
  3338	
  3339		cp_dst_to_slots(cp, l_wr_mas->mas->min, r_wr_mas->mas->max, mas);
  3340		if (!cp->min && cp->max == ULONG_MAX) {
  3341			/* New root */
  3342			if (cp->d_count != 1) {
  3343				enum maple_type mt = maple_arange_64;
  3344	
  3345				if (!mt_is_alloc(mas->tree))
  3346					mt = maple_range_64;
  3347	
  3348				cp->data = cp->d_count;
  3349				cp->s_count = 0;
  3350				dst_setup(cp, mas, mt);
  3351				init_cp_src(cp);
  3352				node_copy(mas, cp->src[0].node, 0, cp->data, cp->max, maple_copy,
  3353					  cp->dst[0].node, 0, mt);
  3354				node_finalise(cp->dst[0].node, mt, cp->end + 1);
> 3355				cp->slot[0] = mt_mk_node(cp->dst[0].node, mt);
  3356				cp->height++;
  3357			}
> 3358			WARN_ON_ONCE(cp->dst[0].node != mte_to_node(cp->slot[0]));
  3359			cp->dst[0].node->parent = ma_parent_ptr(mas_tree_parent(mas));
  3360			mas->min = 0;
  3361			mas->max = ULONG_MAX;
  3362			mas->depth = 0;
  3363			mas->node = mas_root_locked(mas);
  3364			return false;
  3365		}
  3366	
  3367		/* Converged and has a single destination */
  3368		if ((cp->d_count == 1) &&
  3369		    (l_wr_mas->mas->node == r_wr_mas->mas->node)) {
  3370			cp->dst[0].node->parent = ma_parent_ptr(mas_mn(mas)->parent);
  3371			return false;
  3372		}
  3373	
  3374		cp->height++;
  3375		wr_mas_ascend(l_wr_mas);
  3376		wr_mas_ascend(r_wr_mas);
  3377		return true;
  3378	}
  3379	
  3380	static noinline void mas_wr_spanning_rebalance(struct ma_state *mas,
  3381			struct ma_wr_state *l_wr_mas, struct ma_wr_state *r_wr_mas)
  3382	{
  3383	
  3384		struct maple_enode *old_enode;
  3385		struct maple_copy cp;
  3386		struct ma_state sib;
  3387	
  3388		cp_leaf_init(&cp, mas, l_wr_mas, r_wr_mas);
  3389		do {
  3390			spanning_data(&cp, l_wr_mas, r_wr_mas, &sib);
  3391			multi_src_setup(&cp, l_wr_mas, r_wr_mas, &sib);
  3392			dst_setup(&cp, mas, l_wr_mas->type);
  3393			cp_data_write(&cp, mas);
  3394		} while (spanning_ascend(&cp, mas, l_wr_mas, r_wr_mas, &sib));
  3395	
  3396		old_enode = mas->node;
> 3397		mas->node = cp.slot[0];
  3398		mas_wmb_replace(mas, old_enode, cp.height);
  3399		mtree_range_walk(mas);
  3400	}
  3401	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


  reply	other threads:[~2026-01-16  9:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 19:36 [PATCH 00/28] maple_tree: Replace big node with maple copy Liam R. Howlett
2026-01-15 19:36 ` [PATCH 01/28] maple_tree: Move mas_spanning_rebalance loop to function Liam R. Howlett
2026-01-15 19:36 ` [PATCH 02/28] maple_tree: Extract use of big node from mas_wr_spanning_store() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 03/28] maple_tree: Remove unnecessary assignment of orig_l index Liam R. Howlett
2026-01-15 19:36 ` [PATCH 04/28] maple_tree: inline mas_spanning_rebalance() into mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 05/28] maple_tree: Make ma_wr_states reliable for reuse in spanning store Liam R. Howlett
2026-01-15 19:36 ` [PATCH 06/28] maple_tree: Remove l_wr_mas from mas_wr_spanning_rebalance Liam R. Howlett
2026-01-15 19:36 ` [PATCH 07/28] maple_tree: Don't pass through height in mas_wr_spanning_store Liam R. Howlett
2026-01-15 19:36 ` [PATCH 08/28] maple_tree: Move maple_subtree_state from mas_wr_spanning_store to mas_wr_spanning_rebalance Liam R. Howlett
2026-01-15 19:36 ` [PATCH 09/28] maple_tree: Correct right ma_wr_state end pivot in mas_wr_spanning_store() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 10/28] maple_tree: Introduce maple_copy node and use it in mas_spanning_rebalance() Liam R. Howlett
2026-01-16  7:45   ` kernel test robot
2026-01-16 19:46     ` Liam R. Howlett
2026-01-15 19:36 ` [PATCH 11/28] maple_tree: Testing update for spanning store Liam R. Howlett
2026-01-15 19:36 ` [PATCH 12/28] maple_tree: Inline mas_spanning_rebalance_loop() into mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 13/28] maple_tree: Change initial big node setup in mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 14/28] maple_tree: Introduce ma_leaf_max_gap() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 15/28] maple_tree: Add gap support, slot and pivot sizes for maple copy Liam R. Howlett
2026-01-15 19:36 ` [PATCH 16/28] maple_tree: Start using maple copy node for destination Liam R. Howlett
2026-01-16  9:36   ` kernel test robot [this message]
2026-01-16 20:19     ` Liam R. Howlett
2026-01-16 22:44       ` Andrew Morton
2026-01-19 15:06         ` Liam R. Howlett
2026-01-15 19:36 ` [PATCH 17/28] maple_tree: inline mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 18/28] maple_tree: Remove unnecessary return statements Liam R. Howlett
2026-01-15 19:36 ` [PATCH 19/28] maple_tree: Separate wr_split_store and wr_rebalance store type code path Liam R. Howlett
2026-01-15 19:36 ` [PATCH 20/28] maple_tree: Add cp_is_new_root() helper Liam R. Howlett
2026-01-15 19:36 ` [PATCH 21/28] maple_tree: Use maple copy node for mas_wr_rebalance() operation Liam R. Howlett
2026-01-15 19:36 ` [PATCH 22/28] maple_tree: Add copy_tree_location() helper Liam R. Howlett
2026-01-15 19:36 ` [PATCH 23/28] maple_tree: Add cp_converged() helper Liam R. Howlett
2026-01-15 19:36 ` [PATCH 24/28] maple_tree: Use maple copy node for mas_wr_split() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 25/28] maple_tree: Remove maple big node and subtree structs Liam R. Howlett
2026-01-15 19:36 ` [PATCH 26/28] maple_tree: Pass maple copy node to mas_wmb_replace() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 27/28] maple_tree: Don't pass end to mas_wr_append() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 28/28] maple_tree: Clean up mas_wr_node_store() Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202601161750.eDtUQiJr-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lists@nerdbynature.de \
    --cc=maple-tree@lists.infradead.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sidhartha.kumar@oracle.com \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox