linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Harry Yoo <harry.yoo@oracle.com>,
	Petr Tesarik <ptesarik@suse.com>,
	 Christoph Lameter <cl@gentwo.org>,
	David Rientjes <rientjes@google.com>,
	 Roman Gushchin <roman.gushchin@linux.dev>
Cc: Hao Li <hao.li@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Uladzislau Rezki <urezki@gmail.com>,
	 "Liam R. Howlett" <Liam.Howlett@oracle.com>,
	 Suren Baghdasaryan <surenb@google.com>,
	 Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	 Alexei Starovoitov <ast@kernel.org>,
	linux-mm@kvack.org,  linux-kernel@vger.kernel.org,
	linux-rt-devel@lists.linux.dev,  bpf@vger.kernel.org,
	kasan-dev@googlegroups.com,  Vlastimil Babka <vbabka@suse.cz>
Subject: [PATCH v3 02/21] slab: add SLAB_CONSISTENCY_CHECKS to SLAB_NEVER_MERGE
Date: Fri, 16 Jan 2026 15:40:22 +0100	[thread overview]
Message-ID: <20260116-sheaves-for-all-v3-2-5595cb000772@suse.cz> (raw)
In-Reply-To: <20260116-sheaves-for-all-v3-0-5595cb000772@suse.cz>

All the debug flags prevent merging, except SLAB_CONSISTENCY_CHECKS. This
is suboptimal because this flag (like any debug flags) prevents the
usage of any fastpaths, and thus affect performance of any aliased
cache. Also the objects from an aliased cache than the one specified for
debugging could also interfere with the debugging efforts.

Fix this by adding the whole SLAB_DEBUG_FLAGS collection to
SLAB_NEVER_MERGE instead of individual debug flags, so it now also
includes SLAB_CONSISTENCY_CHECKS.

Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
---
 mm/slab_common.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/slab_common.c b/mm/slab_common.c
index ee994ec7f251..e691ede0e6a8 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -45,9 +45,8 @@ struct kmem_cache *kmem_cache;
 /*
  * Set of flags that will prevent slab merging
  */
-#define SLAB_NEVER_MERGE (SLAB_RED_ZONE | SLAB_POISON | SLAB_STORE_USER | \
-		SLAB_TRACE | SLAB_TYPESAFE_BY_RCU | SLAB_NOLEAKTRACE | \
-		SLAB_FAILSLAB | SLAB_NO_MERGE)
+#define SLAB_NEVER_MERGE (SLAB_DEBUG_FLAGS | SLAB_TYPESAFE_BY_RCU | \
+		SLAB_NOLEAKTRACE | SLAB_FAILSLAB | SLAB_NO_MERGE)
 
 #define SLAB_MERGE_SAME (SLAB_RECLAIM_ACCOUNT | SLAB_CACHE_DMA | \
 			 SLAB_CACHE_DMA32 | SLAB_ACCOUNT)

-- 
2.52.0



  parent reply	other threads:[~2026-01-16 14:40 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 14:40 [PATCH v3 00/21] slab: replace cpu (partial) slabs with sheaves Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 01/21] mm/slab: add rcu_barrier() to kvfree_rcu_barrier_on_cache() Vlastimil Babka
2026-01-16 14:40 ` Vlastimil Babka [this message]
2026-01-16 17:22   ` [PATCH v3 02/21] slab: add SLAB_CONSISTENCY_CHECKS to SLAB_NEVER_MERGE Suren Baghdasaryan
2026-01-19  3:41   ` Harry Yoo
2026-01-16 14:40 ` [PATCH v3 03/21] mm/slab: move and refactor __kmem_cache_alias() Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 04/21] mm/slab: make caches with sheaves mergeable Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 05/21] slab: add sheaves to most caches Vlastimil Babka
2026-01-20 18:47   ` Breno Leitao
2026-01-21  8:12     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 06/21] slab: introduce percpu sheaves bootstrap Vlastimil Babka
2026-01-17  2:11   ` Suren Baghdasaryan
2026-01-19  3:40     ` Harry Yoo
2026-01-19  9:13       ` Vlastimil Babka
2026-01-19  9:34     ` Vlastimil Babka
2026-01-21 10:52     ` Vlastimil Babka
2026-01-19 11:32   ` Hao Li
2026-01-21 10:54     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 07/21] slab: make percpu sheaves compatible with kmalloc_nolock()/kfree_nolock() Vlastimil Babka
2026-01-18 20:45   ` Suren Baghdasaryan
2026-01-19  4:31   ` Harry Yoo
2026-01-19 10:09     ` Vlastimil Babka
2026-01-19 10:23       ` Vlastimil Babka
2026-01-19 12:06         ` Hao Li
2026-01-16 14:40 ` [PATCH v3 08/21] slab: handle kmalloc sheaves bootstrap Vlastimil Babka
2026-01-19  5:23   ` Harry Yoo
2026-01-20  1:04   ` Hao Li
2026-01-16 14:40 ` [PATCH v3 09/21] slab: add optimized sheaf refill from partial list Vlastimil Babka
2026-01-19  6:41   ` Harry Yoo
2026-01-19  8:02     ` Harry Yoo
2026-01-19 10:54     ` Vlastimil Babka
2026-01-20  1:41       ` Harry Yoo
2026-01-20  9:32         ` Hao Li
2026-01-20 10:22           ` Harry Yoo
2026-01-20  2:32   ` Harry Yoo
2026-01-20  6:33     ` Vlastimil Babka
2026-01-20 10:27       ` Harry Yoo
2026-01-20 10:32         ` Vlastimil Babka
2026-01-20  2:55   ` Hao Li
2026-01-20 17:19   ` Suren Baghdasaryan
2026-01-21 13:22     ` Vlastimil Babka
2026-01-21 16:12       ` Suren Baghdasaryan
2026-01-16 14:40 ` [PATCH v3 10/21] slab: remove cpu (partial) slabs usage from allocation paths Vlastimil Babka
2026-01-20  4:20   ` Harry Yoo
2026-01-20  8:36   ` Hao Li
2026-01-20 18:06   ` Suren Baghdasaryan
2026-01-21 13:56     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 11/21] slab: remove SLUB_CPU_PARTIAL Vlastimil Babka
2026-01-20  5:24   ` Harry Yoo
2026-01-20 12:10   ` Hao Li
2026-01-20 22:25   ` Suren Baghdasaryan
2026-01-21  0:58     ` Harry Yoo
2026-01-21  1:06       ` Harry Yoo
2026-01-21 16:21       ` Suren Baghdasaryan
2026-01-21 14:22     ` Vlastimil Babka
2026-01-21 14:43       ` Vlastimil Babka
2026-01-21 16:22       ` Suren Baghdasaryan
2026-01-16 14:40 ` [PATCH v3 12/21] slab: remove the do_slab_free() fastpath Vlastimil Babka
2026-01-20  5:35   ` Harry Yoo
2026-01-20 12:29   ` Hao Li
2026-01-21 16:57     ` Suren Baghdasaryan
2026-01-16 14:40 ` [PATCH v3 13/21] slab: remove defer_deactivate_slab() Vlastimil Babka
2026-01-20  5:47   ` Harry Yoo
2026-01-20  9:35   ` Hao Li
2026-01-21 17:11     ` Suren Baghdasaryan
2026-01-16 14:40 ` [PATCH v3 14/21] slab: simplify kmalloc_nolock() Vlastimil Babka
2026-01-20 12:06   ` Hao Li
2026-01-21 17:39     ` Suren Baghdasaryan
2026-01-22  1:53   ` Harry Yoo
2026-01-22  8:16     ` Vlastimil Babka
2026-01-22  8:34       ` Harry Yoo
2026-01-16 14:40 ` [PATCH v3 15/21] slab: remove struct kmem_cache_cpu Vlastimil Babka
2026-01-20 12:40   ` Hao Li
2026-01-21 14:29     ` Vlastimil Babka
2026-01-21 17:54       ` Suren Baghdasaryan
2026-01-21 19:03         ` Vlastimil Babka
2026-01-22  3:10   ` Harry Yoo
2026-01-16 14:40 ` [PATCH v3 16/21] slab: remove unused PREEMPT_RT specific macros Vlastimil Babka
2026-01-21  6:42   ` Hao Li
2026-01-21 17:57     ` Suren Baghdasaryan
2026-01-22  3:50   ` Harry Yoo
2026-01-16 14:40 ` [PATCH v3 17/21] slab: refill sheaves from all nodes Vlastimil Babka
2026-01-21 18:30   ` Suren Baghdasaryan
2026-01-22  4:44   ` Harry Yoo
2026-01-22  8:37     ` Vlastimil Babka
2026-01-22  4:58   ` Hao Li
2026-01-22  8:32     ` Vlastimil Babka
2026-01-22  7:02   ` Harry Yoo
2026-01-22  8:42     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 18/21] slab: update overview comments Vlastimil Babka
2026-01-21 20:58   ` Suren Baghdasaryan
2026-01-22  3:54   ` Hao Li
2026-01-22  6:41   ` Harry Yoo
2026-01-22  8:49     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 19/21] slab: remove frozen slab checks from __slab_free() Vlastimil Babka
2026-01-22  0:54   ` Suren Baghdasaryan
2026-01-22  6:31     ` Vlastimil Babka
2026-01-22  5:01   ` Hao Li
2026-01-16 14:40 ` [PATCH v3 20/21] mm/slub: remove DEACTIVATE_TO_* stat items Vlastimil Babka
2026-01-22  0:58   ` Suren Baghdasaryan
2026-01-22  5:17   ` Hao Li
2026-01-16 14:40 ` [PATCH v3 21/21] mm/slub: cleanup and repurpose some " Vlastimil Babka
2026-01-22  2:35   ` Suren Baghdasaryan
2026-01-22  9:30     ` Vlastimil Babka
2026-01-22  5:52   ` Hao Li
2026-01-22  9:30     ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260116-sheaves-for-all-v3-2-5595cb000772@suse.cz \
    --to=vbabka@suse.cz \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=cl@gentwo.org \
    --cc=hao.li@linux.dev \
    --cc=harry.yoo@oracle.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=ptesarik@suse.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=surenb@google.com \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox