From: Joshua Hahn <joshua.hahnjy@gmail.com>
To: Manish Kumar <manish1588@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: prefer 'unsigned int' over bare 'unsigned' in page_alloc.c
Date: Thu, 15 Jan 2026 15:07:52 -0500 [thread overview]
Message-ID: <20260115200753.1002036-1-joshua.hahnjy@gmail.com> (raw)
In-Reply-To: <20260115194845.118064-1-manish1588@gmail.com>
On Fri, 16 Jan 2026 01:18:45 +0530 Manish Kumar <manish1588@gmail.com> wrote:
> Change the declaration of 'seq' from 'unsigned' to 'unsigned int'
> to follow kernel coding style. No functional change.
>
> Signed-off-by: Manish Kumar <manish1588@gmail.com>
Hello Manish, I hope you're doing well!
The patch looks good to me. However, I just have a few comments about the
other patches that you've recently sent out as well.
I think it could be very helpful for reviewers, if you grouped related commits
together (in this case, mm/page_alloc.c cleanups) into a single patchset.
This lets the reviewers view all related commits together, in each others'
contexts.
It would also be super helpful to Cc some of the reviewers / maintainers who
are relevant to the change you are making! scripts/get_maintainer.pl will
give you a good idea of who might be people who are expereinced in the area
and are willing to review the patch.
Thank you for the patchset, have a great day!
Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com>
next prev parent reply other threads:[~2026-01-15 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 19:48 Manish Kumar
2026-01-15 20:07 ` Joshua Hahn [this message]
2026-01-15 20:11 ` Joshua Hahn
2026-01-15 20:08 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115200753.1002036-1-joshua.hahnjy@gmail.com \
--to=joshua.hahnjy@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manish1588@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox