linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Suren Baghdasaryan <surenb@google.com>,
	Matthew Wilcox <willy@infradead.org>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Alice Ryhl <aliceryhl@google.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Christian Kujau <lists@nerdbynature.de>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH 14/28] maple_tree: Introduce ma_leaf_max_gap()
Date: Thu, 15 Jan 2026 14:36:33 -0500	[thread overview]
Message-ID: <20260115193647.1695937-15-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20260115193647.1695937-1-Liam.Howlett@oracle.com>

This is the same as mas_leaf_max_gap(), but the information necessary is
known without a maple state in future code.  Adding this function now
simplifies the review for a subsequent patch.

Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 lib/maple_tree.c | 48 ++++++++++++++++++++++++++++--------------------
 1 file changed, 28 insertions(+), 20 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 4dd1cc73cd27c..366202dc22343 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -1315,26 +1315,14 @@ void wr_mas_setup(struct ma_wr_state *wr_mas, struct ma_state *mas)
 	wr_mas->r_max = mas_safe_pivot(mas, wr_mas->pivots, mas->offset,
 				       wr_mas->type);
 }
-
-/*
- * mas_leaf_max_gap() - Returns the largest gap in a leaf node
- * @mas: the maple state
- *
- * Return: The maximum gap in the leaf.
- */
-static unsigned long mas_leaf_max_gap(struct ma_state *mas)
+static inline unsigned long ma_leaf_max_gap(struct maple_node *mn,
+		enum maple_type mt, unsigned long min, unsigned long max,
+		unsigned long *pivots, void __rcu **slots)
 {
-	enum maple_type mt;
 	unsigned long pstart, gap, max_gap;
-	struct maple_node *mn;
-	unsigned long *pivots;
-	void __rcu **slots;
 	unsigned char i;
 	unsigned char max_piv;
 
-	mt = mte_node_type(mas->node);
-	mn = mas_mn(mas);
-	slots = ma_slots(mn, mt);
 	max_gap = 0;
 	if (unlikely(ma_is_dense(mt))) {
 		gap = 0;
@@ -1356,26 +1344,25 @@ static unsigned long mas_leaf_max_gap(struct ma_state *mas)
 	 * Check the first implied pivot optimizes the loop below and slot 1 may
 	 * be skipped if there is a gap in slot 0.
 	 */
-	pivots = ma_pivots(mn, mt);
 	if (likely(!slots[0])) {
-		max_gap = pivots[0] - mas->min + 1;
+		max_gap = pivots[0] - min + 1;
 		i = 2;
 	} else {
 		i = 1;
 	}
 
 	/* reduce max_piv as the special case is checked before the loop */
-	max_piv = ma_data_end(mn, mt, pivots, mas->max) - 1;
+	max_piv = ma_data_end(mn, mt, pivots, max) - 1;
 	/*
 	 * Check end implied pivot which can only be a gap on the right most
 	 * node.
 	 */
-	if (unlikely(mas->max == ULONG_MAX) && !slots[max_piv + 1]) {
+	if (unlikely(max == ULONG_MAX) && !slots[max_piv + 1]) {
 		gap = ULONG_MAX - pivots[max_piv];
 		if (gap > max_gap)
 			max_gap = gap;
 
-		if (max_gap > pivots[max_piv] - mas->min)
+		if (max_gap > pivots[max_piv] - min)
 			return max_gap;
 	}
 
@@ -1395,6 +1382,27 @@ static unsigned long mas_leaf_max_gap(struct ma_state *mas)
 	return max_gap;
 }
 
+/*
+ * mas_leaf_max_gap() - Returns the largest gap in a leaf node
+ * @mas: the maple state
+ *
+ * Return: The maximum gap in the leaf.
+ */
+static inline unsigned long mas_leaf_max_gap(struct ma_state *mas)
+{
+	enum maple_type mt;
+	struct maple_node *mn;
+	unsigned long *pivots;
+	void __rcu **slots;
+
+	mn = mas_mn(mas);
+	mt = mte_node_type(mas->node);
+	slots = ma_slots(mn, mt);
+	pivots = ma_pivots(mn, mt);
+
+	return ma_leaf_max_gap(mn, mt, mas->min, mas->max, pivots, slots);
+}
+
 /*
  * ma_max_gap() - Get the maximum gap in a maple node (non-leaf)
  * @node: The maple node
-- 
2.47.3



  parent reply	other threads:[~2026-01-15 19:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 19:36 [PATCH 00/28] maple_tree: Replace big node with maple copy Liam R. Howlett
2026-01-15 19:36 ` [PATCH 01/28] maple_tree: Move mas_spanning_rebalance loop to function Liam R. Howlett
2026-01-15 19:36 ` [PATCH 02/28] maple_tree: Extract use of big node from mas_wr_spanning_store() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 03/28] maple_tree: Remove unnecessary assignment of orig_l index Liam R. Howlett
2026-01-15 19:36 ` [PATCH 04/28] maple_tree: inline mas_spanning_rebalance() into mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 05/28] maple_tree: Make ma_wr_states reliable for reuse in spanning store Liam R. Howlett
2026-01-15 19:36 ` [PATCH 06/28] maple_tree: Remove l_wr_mas from mas_wr_spanning_rebalance Liam R. Howlett
2026-01-15 19:36 ` [PATCH 07/28] maple_tree: Don't pass through height in mas_wr_spanning_store Liam R. Howlett
2026-01-15 19:36 ` [PATCH 08/28] maple_tree: Move maple_subtree_state from mas_wr_spanning_store to mas_wr_spanning_rebalance Liam R. Howlett
2026-01-15 19:36 ` [PATCH 09/28] maple_tree: Correct right ma_wr_state end pivot in mas_wr_spanning_store() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 10/28] maple_tree: Introduce maple_copy node and use it in mas_spanning_rebalance() Liam R. Howlett
2026-01-16  7:45   ` kernel test robot
2026-01-16 19:46     ` Liam R. Howlett
2026-01-15 19:36 ` [PATCH 11/28] maple_tree: Testing update for spanning store Liam R. Howlett
2026-01-15 19:36 ` [PATCH 12/28] maple_tree: Inline mas_spanning_rebalance_loop() into mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 13/28] maple_tree: Change initial big node setup in mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` Liam R. Howlett [this message]
2026-01-15 19:36 ` [PATCH 15/28] maple_tree: Add gap support, slot and pivot sizes for maple copy Liam R. Howlett
2026-01-15 19:36 ` [PATCH 16/28] maple_tree: Start using maple copy node for destination Liam R. Howlett
2026-01-16  9:36   ` kernel test robot
2026-01-16 20:19     ` Liam R. Howlett
2026-01-16 22:44       ` Andrew Morton
2026-01-19 15:06         ` Liam R. Howlett
2026-01-15 19:36 ` [PATCH 17/28] maple_tree: inline mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 18/28] maple_tree: Remove unnecessary return statements Liam R. Howlett
2026-01-15 19:36 ` [PATCH 19/28] maple_tree: Separate wr_split_store and wr_rebalance store type code path Liam R. Howlett
2026-01-15 19:36 ` [PATCH 20/28] maple_tree: Add cp_is_new_root() helper Liam R. Howlett
2026-01-15 19:36 ` [PATCH 21/28] maple_tree: Use maple copy node for mas_wr_rebalance() operation Liam R. Howlett
2026-01-15 19:36 ` [PATCH 22/28] maple_tree: Add copy_tree_location() helper Liam R. Howlett
2026-01-15 19:36 ` [PATCH 23/28] maple_tree: Add cp_converged() helper Liam R. Howlett
2026-01-15 19:36 ` [PATCH 24/28] maple_tree: Use maple copy node for mas_wr_split() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 25/28] maple_tree: Remove maple big node and subtree structs Liam R. Howlett
2026-01-15 19:36 ` [PATCH 26/28] maple_tree: Pass maple copy node to mas_wmb_replace() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 27/28] maple_tree: Don't pass end to mas_wr_append() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 28/28] maple_tree: Clean up mas_wr_node_store() Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115193647.1695937-15-Liam.Howlett@oracle.com \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lists@nerdbynature.de \
    --cc=maple-tree@lists.infradead.org \
    --cc=sidhartha.kumar@oracle.com \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox