From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Suren Baghdasaryan <surenb@google.com>,
Matthew Wilcox <willy@infradead.org>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Alice Ryhl <aliceryhl@google.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Arnd Bergmann <arnd@arndb.de>,
Christian Kujau <lists@nerdbynature.de>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH 00/28] maple_tree: Replace big node with maple copy
Date: Thu, 15 Jan 2026 14:36:19 -0500 [thread overview]
Message-ID: <20260115193647.1695937-1-Liam.Howlett@oracle.com> (raw)
The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a node (except the
right-most node).
The big node struct is incompatible with future features that are
currently in development. Specifically different node types and
different data type sizes for pivots.
The big node struct was also a stack variable, which caused issues with
certain configurations of kernel build.
This series removes big node by introducing another node type which will
never be written to the tree: maple_copy. The maple copy node operates
more like a scatter/gather operation with a number of sources and
destinations of allocated nodes.
The sources are copied to the destinations, in turn, until the sources
are exhausted. The destination is changed if it is filled or the split
location is reached prior to the source data end.
New data is inserted by using the maple copy node itself as a source
with up to 3 slots and pivots. The data in the maple copy node is the
data being written to the tree along with any fragment of the range(s)
being overwritten.
As with all nodes, the maple copy node is of size 256B. Using a node
type allows for the copy operation to treat the new data stored in the
maple copy node the same as any other source node.
Analysis of the runtime shows no regression or benefit of removing the
larger stack structure. The motivation is the ground work to use new
node types and to help those with odd configurations that have had
issues.
The change was tested by myself using mm_tests on amd64 and by Suren on
android (arm64). Limited testing on s390 qemu was also performed using
stress-ng on the virtual memory, which should cover many corner cases.
Liam R. Howlett (28):
maple_tree: Move mas_spanning_rebalance loop to function
maple_tree: Extract use of big node from mas_wr_spanning_store()
maple_tree: Remove unnecessary assignment of orig_l index
maple_tree: inline mas_spanning_rebalance() into
mas_wr_spanning_rebalance()
maple_tree: Make ma_wr_states reliable for reuse in spanning store
maple_tree: Remove l_wr_mas from mas_wr_spanning_rebalance
maple_tree: Don't pass through height in mas_wr_spanning_store
maple_tree: Move maple_subtree_state from mas_wr_spanning_store to
mas_wr_spanning_rebalance
maple_tree: Correct right ma_wr_state end pivot in
mas_wr_spanning_store()
maple_tree: Introduce maple_copy node and use it in
mas_spanning_rebalance()
maple_tree: Testing update for spanning store
maple_tree: Inline mas_spanning_rebalance_loop() into
mas_wr_spanning_rebalance()
maple_tree: Change initial big node setup in
mas_wr_spanning_rebalance()
maple_tree: Introduce ma_leaf_max_gap()
maple_tree: Add gap support, slot and pivot sizes for maple copy
maple_tree: Start using maple copy node for destination
maple_tree: inline mas_wr_spanning_rebalance()
maple_tree: Remove unnecessary return statements
maple_tree: Separate wr_split_store and wr_rebalance store type code
path
maple_tree: Add cp_is_new_root() helper
maple_tree: Use maple copy node for mas_wr_rebalance() operation
maple_tree: Add copy_tree_location() helper
maple_tree: Add cp_converged() helper
maple_tree: Use maple copy node for mas_wr_split()
maple_tree: Remove maple big node and subtree structs
maple_tree: Pass maple copy node to mas_wmb_replace()
maple_tree: Don't pass end to mas_wr_append()
maple_tree: Clean up mas_wr_node_store()
include/linux/maple_tree.h | 42 +
lib/maple_tree.c | 2184 +++++++++++++-----------------
lib/test_maple_tree.c | 55 +-
tools/testing/radix-tree/maple.c | 183 ++-
4 files changed, 1221 insertions(+), 1243 deletions(-)
--
2.47.3
next reply other threads:[~2026-01-15 19:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 19:36 Liam R. Howlett [this message]
2026-01-15 19:36 ` [PATCH 01/28] maple_tree: Move mas_spanning_rebalance loop to function Liam R. Howlett
2026-01-15 19:36 ` [PATCH 02/28] maple_tree: Extract use of big node from mas_wr_spanning_store() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 03/28] maple_tree: Remove unnecessary assignment of orig_l index Liam R. Howlett
2026-01-15 19:36 ` [PATCH 04/28] maple_tree: inline mas_spanning_rebalance() into mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 05/28] maple_tree: Make ma_wr_states reliable for reuse in spanning store Liam R. Howlett
2026-01-15 19:36 ` [PATCH 06/28] maple_tree: Remove l_wr_mas from mas_wr_spanning_rebalance Liam R. Howlett
2026-01-15 19:36 ` [PATCH 07/28] maple_tree: Don't pass through height in mas_wr_spanning_store Liam R. Howlett
2026-01-15 19:36 ` [PATCH 08/28] maple_tree: Move maple_subtree_state from mas_wr_spanning_store to mas_wr_spanning_rebalance Liam R. Howlett
2026-01-15 19:36 ` [PATCH 09/28] maple_tree: Correct right ma_wr_state end pivot in mas_wr_spanning_store() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 10/28] maple_tree: Introduce maple_copy node and use it in mas_spanning_rebalance() Liam R. Howlett
2026-01-16 7:45 ` kernel test robot
2026-01-16 19:46 ` Liam R. Howlett
2026-01-15 19:36 ` [PATCH 11/28] maple_tree: Testing update for spanning store Liam R. Howlett
2026-01-15 19:36 ` [PATCH 12/28] maple_tree: Inline mas_spanning_rebalance_loop() into mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 13/28] maple_tree: Change initial big node setup in mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 14/28] maple_tree: Introduce ma_leaf_max_gap() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 15/28] maple_tree: Add gap support, slot and pivot sizes for maple copy Liam R. Howlett
2026-01-15 19:36 ` [PATCH 16/28] maple_tree: Start using maple copy node for destination Liam R. Howlett
2026-01-16 9:36 ` kernel test robot
2026-01-16 20:19 ` Liam R. Howlett
2026-01-16 22:44 ` Andrew Morton
2026-01-19 15:06 ` Liam R. Howlett
2026-01-15 19:36 ` [PATCH 17/28] maple_tree: inline mas_wr_spanning_rebalance() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 18/28] maple_tree: Remove unnecessary return statements Liam R. Howlett
2026-01-15 19:36 ` [PATCH 19/28] maple_tree: Separate wr_split_store and wr_rebalance store type code path Liam R. Howlett
2026-01-15 19:36 ` [PATCH 20/28] maple_tree: Add cp_is_new_root() helper Liam R. Howlett
2026-01-15 19:36 ` [PATCH 21/28] maple_tree: Use maple copy node for mas_wr_rebalance() operation Liam R. Howlett
2026-01-15 19:36 ` [PATCH 22/28] maple_tree: Add copy_tree_location() helper Liam R. Howlett
2026-01-15 19:36 ` [PATCH 23/28] maple_tree: Add cp_converged() helper Liam R. Howlett
2026-01-15 19:36 ` [PATCH 24/28] maple_tree: Use maple copy node for mas_wr_split() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 25/28] maple_tree: Remove maple big node and subtree structs Liam R. Howlett
2026-01-15 19:36 ` [PATCH 26/28] maple_tree: Pass maple copy node to mas_wmb_replace() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 27/28] maple_tree: Don't pass end to mas_wr_append() Liam R. Howlett
2026-01-15 19:36 ` [PATCH 28/28] maple_tree: Clean up mas_wr_node_store() Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115193647.1695937-1-Liam.Howlett@oracle.com \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lists@nerdbynature.de \
--cc=maple-tree@lists.infradead.org \
--cc=sidhartha.kumar@oracle.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox