From: Kiryl Shutsemau <kas@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <muchun.song@linux.dev>,
David Hildenbrand <david@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Usama Arif <usamaarif642@gmail.com>,
Frank van der Linden <fvdl@google.com>
Cc: Oscar Salvador <osalvador@suse.de>,
Mike Rapoport <rppt@kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Zi Yan <ziy@nvidia.com>, Baoquan He <bhe@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
kernel-team@meta.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Kiryl Shutsemau <kas@kernel.org>
Subject: [PATCHv3 08/15] mm/sparse: Check memmap alignment for compound_info_has_mask()
Date: Thu, 15 Jan 2026 14:45:54 +0000 [thread overview]
Message-ID: <20260115144604.822702-9-kas@kernel.org> (raw)
In-Reply-To: <20260115144604.822702-1-kas@kernel.org>
If page->compound_info encodes a mask, it is expected that memmap to be
naturally aligned to the maximum folio size.
Add a warning if it is not.
A warning is sufficient as MAX_FOLIO_ORDER is very rarely used, so the
kernel is still likely to be functional if this strict check fails.
Signed-off-by: Kiryl Shutsemau <kas@kernel.org>
---
include/linux/mmzone.h | 1 +
mm/sparse.c | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 590d1a494c4c..322ed4c42cfc 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -92,6 +92,7 @@
#endif
#define MAX_FOLIO_NR_PAGES (1UL << MAX_FOLIO_ORDER)
+#define MAX_FOLIO_SIZE (PAGE_SIZE << MAX_FOLIO_ORDER)
enum migratetype {
MIGRATE_UNMOVABLE,
diff --git a/mm/sparse.c b/mm/sparse.c
index 17c50a6415c2..5f41a3edcc24 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -600,6 +600,11 @@ void __init sparse_init(void)
BUILD_BUG_ON(!is_power_of_2(sizeof(struct mem_section)));
memblocks_present();
+ if (compound_info_has_mask()) {
+ WARN_ON(!IS_ALIGNED((unsigned long)pfn_to_page(0),
+ MAX_FOLIO_SIZE / sizeof(struct page)));
+ }
+
pnum_begin = first_present_section_nr();
nid_begin = sparse_early_nid(__nr_to_section(pnum_begin));
--
2.51.2
next prev parent reply other threads:[~2026-01-15 14:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 14:45 [PATCHv3 00/15] mm: Eliminate fake head pages from vmemmap optimization Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 01/15] x86/vdso32: Prepare for <linux/pgtable.h> inclusion Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 02/15] mm: Move MAX_FOLIO_ORDER definition to mmzone.h Kiryl Shutsemau
2026-01-15 16:35 ` David Hildenbrand (Red Hat)
2026-01-15 16:48 ` David Hildenbrand (Red Hat)
2026-01-15 17:26 ` Kiryl Shutsemau
2026-01-15 17:45 ` David Hildenbrand (Red Hat)
2026-01-15 14:45 ` [PATCHv3 03/15] mm: Change the interface of prep_compound_tail() Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 04/15] mm: Rename the 'compound_head' field in the 'struct page' to 'compound_info' Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 05/15] mm: Move set/clear_compound_head() next to compound_head() Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 06/15] mm: Rework compound_head() for power-of-2 sizeof(struct page) Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 07/15] mm: Make page_zonenum() use head page Kiryl Shutsemau
2026-01-15 14:45 ` Kiryl Shutsemau [this message]
2026-01-15 14:45 ` [PATCHv3 09/15] mm/hugetlb: Refactor code around vmemmap_walk Kiryl Shutsemau
2026-01-19 10:04 ` Muchun Song
2026-01-19 15:26 ` Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 10/15] mm/hugetlb: Remove fake head pages Kiryl Shutsemau
2026-01-15 16:49 ` David Hildenbrand (Red Hat)
2026-01-15 17:23 ` Kiryl Shutsemau
2026-01-15 17:41 ` David Hildenbrand (Red Hat)
2026-01-15 18:58 ` Kiryl Shutsemau
2026-01-15 19:33 ` David Hildenbrand (Red Hat)
2026-01-15 19:46 ` David Hildenbrand (Red Hat)
2026-01-16 2:38 ` Muchun Song
2026-01-16 15:52 ` Kiryl Shutsemau
2026-01-17 2:38 ` Muchun Song
2026-01-19 15:15 ` Kiryl Shutsemau
2026-01-20 2:50 ` Muchun Song
2026-01-16 16:18 ` [PATCHv3.1 " Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 11/15] mm: Drop fake head checks Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 12/15] hugetlb: Remove VMEMMAP_SYNCHRONIZE_RCU Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 13/15] mm/hugetlb: Remove hugetlb_optimize_vmemmap_key static key Kiryl Shutsemau
2026-01-15 14:46 ` [PATCHv3 14/15] mm: Remove the branch from compound_head() Kiryl Shutsemau
2026-01-15 14:46 ` [PATCHv3 15/15] hugetlb: Update vmemmap_dedup.rst Kiryl Shutsemau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115144604.822702-9-kas@kernel.org \
--to=kas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=fvdl@google.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=usamaarif642@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox