From: Andrew Morton <akpm@linux-foundation.org>
To: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: "David Hildenbrand (Red Hat)" <david@kernel.org>,
Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] mm/hugetlb: Remove unnecessary if condition
Date: Thu, 15 Jan 2026 13:59:42 -0800 [thread overview]
Message-ID: <20260115135942.843342c483b44232b599a61f@linux-foundation.org> (raw)
In-Reply-To: <20260115211053.1406264-1-joshua.hahnjy@gmail.com>
On Thu, 15 Jan 2026 16:10:51 -0500 Joshua Hahn <joshua.hahnjy@gmail.com> wrote:
> > > - spin_unlock_irq(&hugetlb_lock);
> > > - }
> > > + spin_lock_irq(&hugetlb_lock);
> > > + hugetlb_cgroup_uncharge_folio_rsvd(
> > > + hstate_index(h), pages_per_huge_page(h),
> > > + folio);
> > > + spin_unlock_irq(&hugetlb_lock);
> > > }
> > > }
> > >
> >
> > MAP_CHG_NEEDED = 1
> >
> > Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
>
> Thank you David, I agree it's helpful to include MAP_CHG_NEEDED != 0.
Oh.
> Will add in the v2! Have a great day : -)
While in there, this:
> > > + hugetlb_cgroup_uncharge_folio_rsvd(
> > > + hstate_index(h), pages_per_huge_page(h),
> > > + folio);
contains now-less-needed 80-column party tricks.
next prev parent reply other threads:[~2026-01-15 21:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 18:14 [PATCH 0/3] mm/hugetlb: A fix and some cleanups Joshua Hahn
2026-01-15 18:14 ` [PATCH 1/3] mm/hugetlb: Restore failed global reservations to subpool Joshua Hahn
2026-01-15 19:19 ` Andrew Morton
2026-01-15 19:45 ` Joshua Hahn
2026-01-15 18:14 ` [PATCH 2/3] mm/hugetlb: Remove unnecessary if condition Joshua Hahn
2026-01-15 20:14 ` David Hildenbrand (Red Hat)
2026-01-15 21:10 ` Joshua Hahn
2026-01-15 21:59 ` Andrew Morton [this message]
2026-01-15 22:04 ` Joshua Hahn
2026-01-16 1:39 ` SeongJae Park
2026-01-16 16:45 ` Joshua Hahn
2026-01-15 18:14 ` [PATCH 3/3] mm/hugetlb: Enforce brace style Joshua Hahn
2026-01-15 20:10 ` David Hildenbrand (Red Hat)
2026-01-15 21:14 ` Joshua Hahn
2026-01-15 21:16 ` David Hildenbrand (Red Hat)
2026-01-16 1:54 ` SeongJae Park
2026-01-15 21:57 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115135942.843342c483b44232b599a61f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox