From: <xu.xin16@zte.com.cn>
To: <akpm@linux-foundation.org>, <david@kernel.org>,
<chengming.zhou@linux.dev>, <hughd@google.com>
Cc: <wang.yaxin@zte.com.cn>, <yang.yang29@zte.com.cn>,
<xu.xin16@zte.com.cn>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] ksm: Initial the addr only once in rmap_walk_ksm
Date: Mon, 12 Jan 2026 21:59:26 +0800 (CST) [thread overview]
Message-ID: <20260112215926745u6X5PObjPFC-IXAXj0BU-@zte.com.cn> (raw)
In-Reply-To: <20260112215315996jocrkFSqeYfhABkZxqs4T@zte.com.cn>
From: xu xin <xu.xin16@zte.com.cn>
This is a minor performance optimization, especially when there are many
for-loop iterations, because the addr variable doesn’t change across
iterations.
Therefore, it only needs to be initialized once before the loop.
Signed-off-by: xu xin <xu.xin16@zte.com.cn>
---
mm/ksm.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/mm/ksm.c b/mm/ksm.c
index cfc182255c7b..335e7151e4a1 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -3171,6 +3171,7 @@ void rmap_walk_ksm(struct folio *folio, struct rmap_walk_control *rwc)
struct anon_vma *anon_vma = rmap_item->anon_vma;
struct anon_vma_chain *vmac;
struct vm_area_struct *vma;
+ unsigned long addr;
cond_resched();
if (!anon_vma_trylock_read(anon_vma)) {
@@ -3180,16 +3181,16 @@ void rmap_walk_ksm(struct folio *folio, struct rmap_walk_control *rwc)
}
anon_vma_lock_read(anon_vma);
}
+
+ /* Ignore the stable/unstable/sqnr flags */
+ addr = rmap_item->address & PAGE_MASK;
+
anon_vma_interval_tree_foreach(vmac, &anon_vma->rb_root,
0, ULONG_MAX) {
- unsigned long addr;
cond_resched();
vma = vmac->vma;
- /* Ignore the stable/unstable/sqnr flags */
- addr = rmap_item->address & PAGE_MASK;
-
if (addr < vma->vm_start || addr >= vma->vm_end)
continue;
/*
--
2.25.1
next parent reply other threads:[~2026-01-12 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260112215315996jocrkFSqeYfhABkZxqs4T@zte.com.cn>
2026-01-12 13:59 ` xu.xin16 [this message]
2026-01-12 14:01 ` [PATCH 2/2] ksm: Optimize rmap_walk_ksm by passing a suitable address range xu.xin16
2026-01-12 17:47 ` Andrew Morton
2026-01-12 19:25 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112215926745u6X5PObjPFC-IXAXj0BU-@zte.com.cn \
--to=xu.xin16@zte.com.cn \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wang.yaxin@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox