* Re: [PATCH 3/5] tracing: Have tracer option be instance specific
[not found] <20251105161935.545400234@kernel.org>
@ 2025-11-06 14:38 ` kernel test robot
2025-11-06 17:19 ` Steven Rostedt
2025-11-06 15:29 ` kernel test robot
2026-01-05 15:23 ` Dan Carpenter
2 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2025-11-06 14:38 UTC (permalink / raw)
To: Steven Rostedt, linux-kernel, linux-trace-kernel
Cc: oe-kbuild-all, Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers,
Andrew Morton, Linux Memory Management List
Hi Steven,
kernel test robot noticed the following build errors:
[auto build test ERROR on trace/for-next]
[cannot apply to linus/master v6.18-rc4 next-20251106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/tracing-Remove-dummy-options-and-flags/20251106-010511
base: https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
patch link: https://lore.kernel.org/r/20251105161935.545400234%40kernel.org
patch subject: [PATCH 3/5] tracing: Have tracer option be instance specific
config: i386-buildonly-randconfig-003-20251106 (https://download.01.org/0day-ci/archive/20251106/202511062223.ocoUvCBI-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251106/202511062223.ocoUvCBI-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511062223.ocoUvCBI-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
kernel/trace/trace.c: In function 'run_tracer_selftest':
>> kernel/trace/trace.c:2174:30: error: 'type' redeclared as different kind of symbol
2174 | struct trace_tracer *type = tracers->trace;
| ^~~~
kernel/trace/trace.c:2171:47: note: previous definition of 'type' with type 'struct tracer *'
2171 | static int run_tracer_selftest(struct tracer *type)
| ~~~~~~~~~~~~~~~^~~~
>> kernel/trace/trace.c:2174:37: error: 'tracers' undeclared (first use in this function)
2174 | struct trace_tracer *type = tracers->trace;
| ^~~~~~~
kernel/trace/trace.c:2174:37: note: each undeclared identifier is reported only once for each function it appears in
>> kernel/trace/trace.c:2180:18: error: invalid use of undefined type 'struct trace_tracer'
2180 | if (!type->selftest || tracing_selftest_disabled)
| ^~
>> kernel/trace/trace.c:2189:38: error: passing argument 1 of 'save_selftest' from incompatible pointer type [-Wincompatible-pointer-types]
2189 | return save_selftest(type);
| ^~~~
| |
| struct trace_tracer *
kernel/trace/trace.c:2158:41: note: expected 'struct tracer *' but argument is of type 'struct trace_tracer *'
2158 | static int save_selftest(struct tracer *type)
| ~~~~~~~~~~~~~~~^~~~
In file included from include/asm-generic/bug.h:22,
from arch/x86/include/asm/bug.h:108,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/mm.h:6,
from include/linux/ring_buffer.h:5,
from kernel/trace/trace.c:15:
kernel/trace/trace.c:2193:29: error: invalid use of undefined type 'struct trace_tracer'
2193 | type->name);
| ^~
include/linux/printk.h:484:33: note: in definition of macro 'printk_index_wrap'
484 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:565:9: note: in expansion of macro 'printk'
565 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~
kernel/trace/trace.c:2192:17: note: in expansion of macro 'pr_warn'
2192 | pr_warn("Selftest for tracer %s skipped due to tracing disabled\n",
| ^~~~~~~
>> kernel/trace/trace.c:2206:27: error: assignment to 'struct tracer *' from incompatible pointer type 'struct trace_tracer *' [-Wincompatible-pointer-types]
2206 | tr->current_trace = type;
| ^
kernel/trace/trace.c:2207:39: error: invalid use of undefined type 'struct trace_tracer'
2207 | tr->current_trace_flags = type->flags ? : type->default_flags;
| ^~
kernel/trace/trace.c:2207:55: error: invalid use of undefined type 'struct trace_tracer'
2207 | tr->current_trace_flags = type->flags ? : type->default_flags;
| ^~
kernel/trace/trace.c:2210:17: error: invalid use of undefined type 'struct trace_tracer'
2210 | if (type->use_max_tr) {
| ^~
kernel/trace/trace.c:2220:44: error: invalid use of undefined type 'struct trace_tracer'
2220 | pr_info("Testing tracer %s: ", type->name);
| ^~
include/linux/printk.h:484:33: note: in definition of macro 'printk_index_wrap'
484 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:585:9: note: in expansion of macro 'printk'
585 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~
kernel/trace/trace.c:2220:9: note: in expansion of macro 'pr_info'
2220 | pr_info("Testing tracer %s: ", type->name);
| ^~~~~~~
kernel/trace/trace.c:2221:19: error: invalid use of undefined type 'struct trace_tracer'
2221 | ret = type->selftest(type, tr);
| ^~
kernel/trace/trace.c:2235:17: error: invalid use of undefined type 'struct trace_tracer'
2235 | if (type->use_max_tr) {
| ^~
>> kernel/trace/trace.c:2176:30: warning: unused variable 'flags' [-Wunused-variable]
2176 | struct tracer_flags *flags;
| ^~~~~
kernel/trace/trace.c: In function 'tracing_trace_options_show':
kernel/trace/trace.c:5172:24: warning: variable 'trace' set but not used [-Wunused-but-set-variable]
5172 | struct tracer *trace;
| ^~~~~
vim +/type +2174 kernel/trace/trace.c
2170
> 2171 static int run_tracer_selftest(struct tracer *type)
2172 {
2173 struct trace_array *tr = &global_trace;
> 2174 struct trace_tracer *type = tracers->trace;
2175 struct tracer_flags *saved_flags = tr->current_trace_flags;
> 2176 struct tracer_flags *flags;
2177 struct tracer *saved_tracer = tr->current_trace;
2178 int ret;
2179
> 2180 if (!type->selftest || tracing_selftest_disabled)
2181 return 0;
2182
2183 /*
2184 * If a tracer registers early in boot up (before scheduling is
2185 * initialized and such), then do not run its selftests yet.
2186 * Instead, run it a little later in the boot process.
2187 */
2188 if (!selftests_can_run)
> 2189 return save_selftest(type);
2190
2191 if (!tracing_is_on()) {
> 2192 pr_warn("Selftest for tracer %s skipped due to tracing disabled\n",
2193 type->name);
2194 return 0;
2195 }
2196
2197 /*
2198 * Run a selftest on this tracer.
2199 * Here we reset the trace buffer, and set the current
2200 * tracer to be this tracer. The tracer can then run some
2201 * internal tracing to verify that everything is in order.
2202 * If we fail, we do not register this tracer.
2203 */
2204 tracing_reset_online_cpus(&tr->array_buffer);
2205
> 2206 tr->current_trace = type;
2207 tr->current_trace_flags = type->flags ? : type->default_flags;
2208
2209 #ifdef CONFIG_TRACER_MAX_TRACE
2210 if (type->use_max_tr) {
2211 /* If we expanded the buffers, make sure the max is expanded too */
2212 if (tr->ring_buffer_expanded)
2213 ring_buffer_resize(tr->max_buffer.buffer, trace_buf_size,
2214 RING_BUFFER_ALL_CPUS);
2215 tr->allocated_snapshot = true;
2216 }
2217 #endif
2218
2219 /* the test is responsible for initializing and enabling */
> 2220 pr_info("Testing tracer %s: ", type->name);
2221 ret = type->selftest(type, tr);
2222 /* the test is responsible for resetting too */
2223 tr->current_trace = saved_tracer;
2224 tr->current_trace_flags = saved_flags;
2225 if (ret) {
2226 printk(KERN_CONT "FAILED!\n");
2227 /* Add the warning after printing 'FAILED' */
2228 WARN_ON(1);
2229 return -1;
2230 }
2231 /* Only reset on passing, to avoid touching corrupted buffers */
2232 tracing_reset_online_cpus(&tr->array_buffer);
2233
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/5] tracing: Have tracer option be instance specific
[not found] <20251105161935.545400234@kernel.org>
2025-11-06 14:38 ` [PATCH 3/5] tracing: Have tracer option be instance specific kernel test robot
@ 2025-11-06 15:29 ` kernel test robot
2026-01-05 15:23 ` Dan Carpenter
2 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2025-11-06 15:29 UTC (permalink / raw)
To: Steven Rostedt, linux-kernel, linux-trace-kernel
Cc: llvm, oe-kbuild-all, Masami Hiramatsu, Mark Rutland,
Mathieu Desnoyers, Andrew Morton, Linux Memory Management List
Hi Steven,
kernel test robot noticed the following build errors:
[auto build test ERROR on trace/for-next]
[cannot apply to linus/master v6.18-rc4 next-20251106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/tracing-Remove-dummy-options-and-flags/20251106-010511
base: https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
patch link: https://lore.kernel.org/r/20251105161935.545400234%40kernel.org
patch subject: [PATCH 3/5] tracing: Have tracer option be instance specific
config: i386-buildonly-randconfig-004-20251106 (https://download.01.org/0day-ci/archive/20251106/202511062257.TSJTBQ2c-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251106/202511062257.TSJTBQ2c-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511062257.TSJTBQ2c-lkp@intel.com/
All errors (new ones prefixed by >>):
>> kernel/trace/trace.c:2174:23: error: redefinition of 'type' with a different type: 'struct trace_tracer *' vs 'struct tracer *'
2174 | struct trace_tracer *type = tracers->trace;
| ^
kernel/trace/trace.c:2171:47: note: previous definition is here
2171 | static int run_tracer_selftest(struct tracer *type)
| ^
>> kernel/trace/trace.c:2174:30: error: use of undeclared identifier 'tracers'
2174 | struct trace_tracer *type = tracers->trace;
| ^
kernel/trace/trace.c:5172:17: warning: variable 'trace' set but not used [-Wunused-but-set-variable]
5172 | struct tracer *trace;
| ^
1 warning and 2 errors generated.
vim +2174 kernel/trace/trace.c
2170
2171 static int run_tracer_selftest(struct tracer *type)
2172 {
2173 struct trace_array *tr = &global_trace;
> 2174 struct trace_tracer *type = tracers->trace;
2175 struct tracer_flags *saved_flags = tr->current_trace_flags;
2176 struct tracer_flags *flags;
2177 struct tracer *saved_tracer = tr->current_trace;
2178 int ret;
2179
2180 if (!type->selftest || tracing_selftest_disabled)
2181 return 0;
2182
2183 /*
2184 * If a tracer registers early in boot up (before scheduling is
2185 * initialized and such), then do not run its selftests yet.
2186 * Instead, run it a little later in the boot process.
2187 */
2188 if (!selftests_can_run)
2189 return save_selftest(type);
2190
2191 if (!tracing_is_on()) {
2192 pr_warn("Selftest for tracer %s skipped due to tracing disabled\n",
2193 type->name);
2194 return 0;
2195 }
2196
2197 /*
2198 * Run a selftest on this tracer.
2199 * Here we reset the trace buffer, and set the current
2200 * tracer to be this tracer. The tracer can then run some
2201 * internal tracing to verify that everything is in order.
2202 * If we fail, we do not register this tracer.
2203 */
2204 tracing_reset_online_cpus(&tr->array_buffer);
2205
2206 tr->current_trace = type;
2207 tr->current_trace_flags = type->flags ? : type->default_flags;
2208
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/5] tracing: Have tracer option be instance specific
2025-11-06 14:38 ` [PATCH 3/5] tracing: Have tracer option be instance specific kernel test robot
@ 2025-11-06 17:19 ` Steven Rostedt
0 siblings, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2025-11-06 17:19 UTC (permalink / raw)
To: kernel test robot
Cc: linux-kernel, linux-trace-kernel, oe-kbuild-all,
Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton,
Linux Memory Management List
On Thu, 6 Nov 2025 22:38:04 +0800
kernel test robot <lkp@intel.com> wrote:
> All error/warnings (new ones prefixed by >>):
>
> kernel/trace/trace.c: In function 'run_tracer_selftest':
> >> kernel/trace/trace.c:2174:30: error: 'type' redeclared as different kind of symbol
> 2174 | struct trace_tracer *type = tracers->trace;
> | ^~~~
> kernel/trace/trace.c:2171:47: note: previous definition of '
Yeah, I caught this last night during my more thorough tests. Silly me
turned off selftests to make a bisect go faster and never turned it back
on. :-p
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/5] tracing: Have tracer option be instance specific
[not found] <20251105161935.545400234@kernel.org>
2025-11-06 14:38 ` [PATCH 3/5] tracing: Have tracer option be instance specific kernel test robot
2025-11-06 15:29 ` kernel test robot
@ 2026-01-05 15:23 ` Dan Carpenter
2026-01-09 15:23 ` Steven Rostedt
2 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2026-01-05 15:23 UTC (permalink / raw)
To: oe-kbuild, Steven Rostedt, linux-kernel, linux-trace-kernel
Cc: lkp, oe-kbuild-all, Masami Hiramatsu, Mark Rutland,
Mathieu Desnoyers, Andrew Morton, Linux Memory Management List
Hi Steven,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/tracing-Remove-dummy-options-and-flags/20251106-010511
base: https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
patch link: https://lore.kernel.org/r/20251105161935.545400234%40kernel.org
patch subject: [PATCH 3/5] tracing: Have tracer option be instance specific
config: i386-randconfig-r072-20251107 (https://download.01.org/0day-ci/archive/20251107/202511071533.domGENBS-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202511071533.domGENBS-lkp@intel.com/
smatch warnings:
kernel/trace/trace.c:6313 tracing_set_tracer() warn: iterator used outside loop: 't'
vim +/t +6313 kernel/trace/trace.c
9c5b9d3d65e4858 Masami Hiramatsu 2020-01-11 6285 int tracing_set_tracer(struct trace_array *tr, const char *buf)
09d23a1d8a82e81 Steven Rostedt (Red Hat 2015-02-03 6286) {
4699bbb369ba1d3 Steven Rostedt 2025-11-05 6287 struct tracer *trace;
4699bbb369ba1d3 Steven Rostedt 2025-11-05 6288 struct tracers *t;
12883efb670c28d Steven Rostedt (Red Hat 2013-03-05 6289) #ifdef CONFIG_TRACER_MAX_TRACE
34600f0e9c33c9c Steven Rostedt 2013-01-22 6290 bool had_max_tr;
12883efb670c28d Steven Rostedt (Red Hat 2013-03-05 6291) #endif
d33b10c0c73adca Steven Rostedt 2024-12-24 6292 int ret;
bc0c38d139ec7fc Steven Rostedt 2008-05-12 6293
d33b10c0c73adca Steven Rostedt 2024-12-24 6294 guard(mutex)(&trace_types_lock);
1027fcb206a0fb8 Steven Rostedt 2009-03-12 6295
7a1d1e4b9639ff0 Steven Rostedt (Google 2024-06-12 6296) update_last_data(tr);
7a1d1e4b9639ff0 Steven Rostedt (Google 2024-06-12 6297)
a1f157c7a3bb342 Zheng Yejian 2023-09-06 6298 if (!tr->ring_buffer_expanded) {
2b6080f28c7cc3e Steven Rostedt 2012-05-11 6299 ret = __tracing_resize_ring_buffer(tr, trace_buf_size,
438ced1720b5840 Vaibhav Nagarnaik 2012-02-02 6300 RING_BUFFER_ALL_CPUS);
73c5162aa362a54 Steven Rostedt 2009-03-11 6301 if (ret < 0)
d33b10c0c73adca Steven Rostedt 2024-12-24 6302 return ret;
73c5162aa362a54 Steven Rostedt 2009-03-11 6303 ret = 0;
73c5162aa362a54 Steven Rostedt 2009-03-11 6304 }
73c5162aa362a54 Steven Rostedt 2009-03-11 6305
4699bbb369ba1d3 Steven Rostedt 2025-11-05 6306 list_for_each_entry(t, &tr->tracers, list) {
4699bbb369ba1d3 Steven Rostedt 2025-11-05 6307 if (strcmp(t->tracer->name, buf) == 0)
bc0c38d139ec7fc Steven Rostedt 2008-05-12 6308 break;
bc0c38d139ec7fc Steven Rostedt 2008-05-12 6309 }
d33b10c0c73adca Steven Rostedt 2024-12-24 6310 if (!t)
t can't be NULL here. It needs to be if (list_entry_is_head()) return;
d33b10c0c73adca Steven Rostedt 2024-12-24 6311 return -EINVAL;
d33b10c0c73adca Steven Rostedt 2024-12-24 6312
4699bbb369ba1d3 Steven Rostedt 2025-11-05 @6313 if (t->tracer == tr->current_trace)
d33b10c0c73adca Steven Rostedt 2024-12-24 6314 return 0;
bc0c38d139ec7fc Steven Rostedt 2008-05-12 6315
4699bbb369ba1d3 Steven Rostedt 2025-11-05 6316 trace = t->tracer;
4699bbb369ba1d3 Steven Rostedt 2025-11-05 6317
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/5] tracing: Have tracer option be instance specific
2026-01-05 15:23 ` Dan Carpenter
@ 2026-01-09 15:23 ` Steven Rostedt
2026-01-09 21:40 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2026-01-09 15:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: oe-kbuild, linux-kernel, linux-trace-kernel, lkp, oe-kbuild-all,
Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton,
Linux Memory Management List
On Mon, 5 Jan 2026 18:23:31 +0300
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> Hi Steven,
Hi Dan,
>
> kernel test robot noticed the following build warnings:
>
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/tracing-Remove-dummy-options-and-flags/20251106-010511
> base: https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
> patch link: https://lore.kernel.org/r/20251105161935.545400234%40kernel.org
This is an old patch (v1) and v3 fixed this issue:
https://lore.kernel.org/all/20251110234341.767135255@kernel.org/
and v4 was applied and is now in mainline.
The patch you are reporting on was sent Nov 5th, the fix was sent Nov 10th.
Why is this sending reports about an old patch that is obsolete? Is there
something wrong with your setup?
-- Steve
> patch subject: [PATCH 3/5] tracing: Have tracer option be instance specific
> config: i386-randconfig-r072-20251107 (https://download.01.org/0day-ci/archive/20251107/202511071533.domGENBS-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202511071533.domGENBS-lkp@intel.com/
>
> smatch warnings:
> kernel/trace/trace.c:6313 tracing_set_tracer() warn: iterator used outside loop: 't'
>
> vim +/t +6313 kernel/trace/trace.c
>
> 9c5b9d3d65e4858 Masami Hiramatsu 2020-01-11 6285 int tracing_set_tracer(struct trace_array *tr, const char *buf)
> 09d23a1d8a82e81 Steven Rostedt (Red Hat 2015-02-03 6286) {
> 4699bbb369ba1d3 Steven Rostedt 2025-11-05 6287 struct tracer *trace;
> 4699bbb369ba1d3 Steven Rostedt 2025-11-05 6288 struct tracers *t;
> 12883efb670c28d Steven Rostedt (Red Hat 2013-03-05 6289) #ifdef CONFIG_TRACER_MAX_TRACE
> 34600f0e9c33c9c Steven Rostedt 2013-01-22 6290 bool had_max_tr;
> 12883efb670c28d Steven Rostedt (Red Hat 2013-03-05 6291) #endif
> d33b10c0c73adca Steven Rostedt 2024-12-24 6292 int ret;
> bc0c38d139ec7fc Steven Rostedt 2008-05-12 6293
> d33b10c0c73adca Steven Rostedt 2024-12-24 6294 guard(mutex)(&trace_types_lock);
> 1027fcb206a0fb8 Steven Rostedt 2009-03-12 6295
> 7a1d1e4b9639ff0 Steven Rostedt (Google 2024-06-12 6296) update_last_data(tr);
> 7a1d1e4b9639ff0 Steven Rostedt (Google 2024-06-12 6297)
> a1f157c7a3bb342 Zheng Yejian 2023-09-06 6298 if (!tr->ring_buffer_expanded) {
> 2b6080f28c7cc3e Steven Rostedt 2012-05-11 6299 ret = __tracing_resize_ring_buffer(tr, trace_buf_size,
> 438ced1720b5840 Vaibhav Nagarnaik 2012-02-02 6300 RING_BUFFER_ALL_CPUS);
> 73c5162aa362a54 Steven Rostedt 2009-03-11 6301 if (ret < 0)
> d33b10c0c73adca Steven Rostedt 2024-12-24 6302 return ret;
> 73c5162aa362a54 Steven Rostedt 2009-03-11 6303 ret = 0;
> 73c5162aa362a54 Steven Rostedt 2009-03-11 6304 }
> 73c5162aa362a54 Steven Rostedt 2009-03-11 6305
> 4699bbb369ba1d3 Steven Rostedt 2025-11-05 6306 list_for_each_entry(t, &tr->tracers, list) {
> 4699bbb369ba1d3 Steven Rostedt 2025-11-05 6307 if (strcmp(t->tracer->name, buf) == 0)
> bc0c38d139ec7fc Steven Rostedt 2008-05-12 6308 break;
> bc0c38d139ec7fc Steven Rostedt 2008-05-12 6309 }
> d33b10c0c73adca Steven Rostedt 2024-12-24 6310 if (!t)
>
> t can't be NULL here. It needs to be if (list_entry_is_head()) return;
>
> d33b10c0c73adca Steven Rostedt 2024-12-24 6311 return -EINVAL;
> d33b10c0c73adca Steven Rostedt 2024-12-24 6312
> 4699bbb369ba1d3 Steven Rostedt 2025-11-05 @6313 if (t->tracer == tr->current_trace)
> d33b10c0c73adca Steven Rostedt 2024-12-24 6314 return 0;
> bc0c38d139ec7fc Steven Rostedt 2008-05-12 6315
> 4699bbb369ba1d3 Steven Rostedt 2025-11-05 6316 trace = t->tracer;
> 4699bbb369ba1d3 Steven Rostedt 2025-11-05 6317
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/5] tracing: Have tracer option be instance specific
2026-01-09 15:23 ` Steven Rostedt
@ 2026-01-09 21:40 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2026-01-09 21:40 UTC (permalink / raw)
To: Steven Rostedt
Cc: oe-kbuild, linux-kernel, linux-trace-kernel, lkp, oe-kbuild-all,
Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton,
Linux Memory Management List
On Fri, Jan 09, 2026 at 10:23:01AM -0500, Steven Rostedt wrote:
> On Mon, 5 Jan 2026 18:23:31 +0300
> Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> > Hi Steven,
>
> Hi Dan,
>
> >
> > kernel test robot noticed the following build warnings:
> >
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/tracing-Remove-dummy-options-and-flags/20251106-010511
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
> > patch link: https://lore.kernel.org/r/20251105161935.545400234%40kernel.org
>
> This is an old patch (v1) and v3 fixed this issue:
> https://lore.kernel.org/all/20251110234341.767135255@kernel.org/
>
> and v4 was applied and is now in mainline.
>
> The patch you are reporting on was sent Nov 5th, the fix was sent Nov 10th.
>
> Why is this sending reports about an old patch that is obsolete? Is there
> something wrong with your setup?
>
> -- Steve
>
Yeah. I appologize. That was my bad. I accidentally was looking
at old emails. I think this was the only one I sent, though.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-01-09 21:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20251105161935.545400234@kernel.org>
2025-11-06 14:38 ` [PATCH 3/5] tracing: Have tracer option be instance specific kernel test robot
2025-11-06 17:19 ` Steven Rostedt
2025-11-06 15:29 ` kernel test robot
2026-01-05 15:23 ` Dan Carpenter
2026-01-09 15:23 ` Steven Rostedt
2026-01-09 21:40 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox