From: Andrew Morton <akpm@linux-foundation.org>
To: Sun Jian <sun.jian.kdev@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>,
David Hildenbrand <david@kernel.org>,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: run_vmtests.sh: fix relative path handling
Date: Thu, 8 Jan 2026 13:28:51 -0800 [thread overview]
Message-ID: <20260108132851.bb6b7813277a5b40ba3aec8f@linux-foundation.org> (raw)
In-Reply-To: <20260108031604.12379-1-sun.jian.kdev@gmail.com>
On Thu, 8 Jan 2026 11:16:04 +0800 Sun Jian <sun.jian.kdev@gmail.com> wrote:
> run_vmtests.sh relies on being invoked from its own directory and uses
> relative paths to run tests.
>
> Change to the script directory at startup so it can be run from any
> working directory without failing.
>
> ...
>
hm, why? Is that a thing people actually do?
Is anyone going to actually test this feature?
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -5,6 +5,10 @@
> # Kselftest framework requirement - SKIP code is 4.
> ksft_skip=4
>
> +# Ensure relative paths work regardless of caller's cwd.
> +SCRIPT_DIR=$(CDPATH= cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)
> +cd "$SCRIPT_DIR" || exit 1
> +
Alternatively we could check that we're in the correct directory and
error out if not.
next prev parent reply other threads:[~2026-01-08 21:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 3:16 Sun Jian
2026-01-08 21:28 ` Andrew Morton [this message]
2026-01-09 2:08 ` sun jian
2026-01-09 13:41 ` David Hildenbrand (Red Hat)
2026-01-09 17:28 ` [PATCH v2] selftests/mm: run_vmtests.sh: fail if invoked from the wrong directory Sun Jian
2026-01-10 1:00 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108132851.bb6b7813277a5b40ba3aec8f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sun.jian.kdev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox